Fix some compile warnings in taglib

This commit is contained in:
Jonas Kvinge
2020-04-23 21:00:16 +02:00
parent ac40094d37
commit c1ac2debb8
24 changed files with 64 additions and 90 deletions

View File

@@ -334,14 +334,14 @@ ByteVector TableOfContentsFrame::renderFields() const
data.append(flags);
data.append((char)(entryCount()));
ByteVectorList::ConstIterator it = d->childElements.begin();
while(it != d->childElements.end()) {
while (it != d->childElements.end()) {
data.append(*it);
data.append('\0');
it++;
}
FrameList l = d->embeddedFrameList;
for(FrameList::ConstIterator it = l.begin(); it != l.end(); ++it)
data.append((*it)->render());
for (FrameList::ConstIterator it2 = l.begin(); it2 != l.end(); ++it2)
data.append((*it2)->render());
return data;
}

View File

@@ -417,7 +417,7 @@ namespace
{"TYER", "TDRC"}, // 2.3 -> 2.4
{"TIME", "TDRC"}, // 2.3 -> 2.4
};
const size_t deprecatedFramesSize = sizeof(deprecatedFrames) / sizeof(deprecatedFrames[0]);;
const size_t deprecatedFramesSize = sizeof(deprecatedFrames) / sizeof(deprecatedFrames[0]);
}
String Frame::frameIDToKey(const ByteVector &id)

View File

@@ -69,7 +69,7 @@ public:
// public members
////////////////////////////////////////////////////////////////////////////////
MPEG::Header::Header(const ByteVector &data) :
MPEG::Header::Header(const ByteVector&) :
d(new HeaderPrivate())
{
debug("MPEG::Header::Header() - This constructor is no longer used.");