From cfd1fe59f3c5e88333ad8f87c50dc3495c67285a Mon Sep 17 00:00:00 2001 From: Jonas Kvinge Date: Sun, 30 Aug 2020 21:40:04 +0200 Subject: [PATCH] Only allow playlist editing if song is editable. Fixes #524 --- src/playlist/playlistview.cpp | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/playlist/playlistview.cpp b/src/playlist/playlistview.cpp index 9766a7d91..8a9dadf8b 100644 --- a/src/playlist/playlistview.cpp +++ b/src/playlist/playlistview.cpp @@ -704,6 +704,11 @@ QModelIndex PlaylistView::PrevEditableIndex(const QModelIndex ¤t) { bool PlaylistView::edit(const QModelIndex &idx, QAbstractItemView::EditTrigger trigger, QEvent *event) { + // Only allow playlist editing if song is editable. + if (trigger == QAbstractItemView::AllEditTriggers && !event && playlist_ && !playlist_->item_at(idx.row())->Metadata().IsEditable()) { + return false; + } + bool result = QAbstractItemView::edit(idx, trigger, event); if (result && trigger == QAbstractItemView::AllEditTriggers && !event) { playlist_->set_editing(idx.row());