Remove unneeded this
This commit is contained in:
@@ -257,7 +257,7 @@ void CoversSettingsPage::AuthenticationSuccess() {
|
||||
if (!provider) return;
|
||||
DisconnectAuthentication(provider);
|
||||
|
||||
if (!this->isVisible() || !ui_->providers->currentItem() || ui_->providers->currentItem()->text() != provider->name()) return;
|
||||
if (!isVisible() || !ui_->providers->currentItem() || ui_->providers->currentItem()->text() != provider->name()) return;
|
||||
|
||||
ui_->login_state->SetLoggedIn(LoginStateWidget::LoggedIn);
|
||||
ui_->button_authenticate->setEnabled(true);
|
||||
@@ -270,7 +270,7 @@ void CoversSettingsPage::AuthenticationFailure(const QStringList &errors) {
|
||||
if (!provider) return;
|
||||
DisconnectAuthentication(provider);
|
||||
|
||||
if (!this->isVisible() || !ui_->providers->currentItem() || ui_->providers->currentItem()->text() != provider->name()) return;
|
||||
if (!isVisible() || !ui_->providers->currentItem() || ui_->providers->currentItem()->text() != provider->name()) return;
|
||||
|
||||
QMessageBox::warning(this, tr("Authentication failed"), errors.join("\n"));
|
||||
|
||||
|
||||
@@ -237,7 +237,7 @@ void LyricsSettingsPage::AuthenticationSuccess() {
|
||||
if (!provider) return;
|
||||
DisconnectAuthentication(provider);
|
||||
|
||||
if (!this->isVisible() || !ui_->providers->currentItem() || ui_->providers->currentItem()->text() != provider->name()) return;
|
||||
if (!isVisible() || !ui_->providers->currentItem() || ui_->providers->currentItem()->text() != provider->name()) return;
|
||||
|
||||
ui_->login_state->SetLoggedIn(LoginStateWidget::LoggedIn);
|
||||
ui_->button_authenticate->setEnabled(true);
|
||||
@@ -250,7 +250,7 @@ void LyricsSettingsPage::AuthenticationFailure(const QStringList &errors) {
|
||||
if (!provider) return;
|
||||
DisconnectAuthentication(provider);
|
||||
|
||||
if (!this->isVisible() || !ui_->providers->currentItem() || ui_->providers->currentItem()->text() != provider->name()) return;
|
||||
if (!isVisible() || !ui_->providers->currentItem() || ui_->providers->currentItem()->text() != provider->name()) return;
|
||||
|
||||
QMessageBox::warning(this, tr("Authentication failed"), errors.join("\n"));
|
||||
|
||||
|
||||
@@ -163,7 +163,7 @@ void QobuzSettingsPage::LogoutClicked() {
|
||||
|
||||
void QobuzSettingsPage::LoginSuccess() {
|
||||
|
||||
if (!this->isVisible()) return;
|
||||
if (!isVisible()) return;
|
||||
ui_->login_state->SetLoggedIn(LoginStateWidget::LoggedIn);
|
||||
ui_->button_login->setEnabled(true);
|
||||
|
||||
@@ -171,7 +171,7 @@ void QobuzSettingsPage::LoginSuccess() {
|
||||
|
||||
void QobuzSettingsPage::LoginFailure(const QString &failure_reason) {
|
||||
|
||||
if (!this->isVisible()) return;
|
||||
if (!isVisible()) return;
|
||||
QMessageBox::warning(this, tr("Authentication failed"), failure_reason);
|
||||
|
||||
}
|
||||
|
||||
@@ -151,7 +151,7 @@ bool SubsonicSettingsPage::eventFilter(QObject *object, QEvent *event) {
|
||||
|
||||
void SubsonicSettingsPage::TestSuccess() {
|
||||
|
||||
if (!this->isVisible()) return;
|
||||
if (!isVisible()) return;
|
||||
ui_->button_test->setEnabled(true);
|
||||
|
||||
QMessageBox::information(this, tr("Test successful!"), tr("Test successful!"));
|
||||
@@ -160,7 +160,7 @@ void SubsonicSettingsPage::TestSuccess() {
|
||||
|
||||
void SubsonicSettingsPage::TestFailure(const QString &failure_reason) {
|
||||
|
||||
if (!this->isVisible()) return;
|
||||
if (!isVisible()) return;
|
||||
ui_->button_test->setEnabled(true);
|
||||
|
||||
QMessageBox::warning(this, tr("Test failed!"), failure_reason);
|
||||
|
||||
@@ -207,7 +207,7 @@ void TidalSettingsPage::LogoutClicked() {
|
||||
|
||||
void TidalSettingsPage::LoginSuccess() {
|
||||
|
||||
if (!this->isVisible()) return;
|
||||
if (!isVisible()) return;
|
||||
ui_->login_state->SetLoggedIn(LoginStateWidget::LoggedIn);
|
||||
ui_->button_login->setEnabled(true);
|
||||
|
||||
@@ -215,7 +215,7 @@ void TidalSettingsPage::LoginSuccess() {
|
||||
|
||||
void TidalSettingsPage::LoginFailure(const QString &failure_reason) {
|
||||
|
||||
if (!this->isVisible()) return;
|
||||
if (!isVisible()) return;
|
||||
QMessageBox::warning(this, tr("Authentication failed"), failure_reason);
|
||||
ui_->button_login->setEnabled(true);
|
||||
|
||||
|
||||
Reference in New Issue
Block a user