Change some explicit usage

This commit is contained in:
Jonas Kvinge
2020-06-26 22:41:38 +02:00
parent 740f9581e6
commit dc36aee7ff
28 changed files with 38 additions and 38 deletions

View File

@@ -65,7 +65,7 @@ class ThreadFunctorBase : public QFutureInterface<ReturnType>, public QRunnable
template <typename ReturnType, typename... Args>
class ThreadFunctor : public ThreadFunctorBase<ReturnType> {
public:
ThreadFunctor(std::function<ReturnType (Args...)> function, Args... args)
explicit ThreadFunctor(std::function<ReturnType (Args...)> function, Args... args)
: function_(std::bind(function, args...)) {
}
@@ -82,7 +82,7 @@ class ThreadFunctor : public ThreadFunctorBase<ReturnType> {
template <typename... Args>
class ThreadFunctor <void, Args...> : public ThreadFunctorBase<void> {
public:
ThreadFunctor(std::function<void (Args...)> function, Args... args)
explicit ThreadFunctor(std::function<void (Args...)> function, Args... args)
: function_(std::bind(function, args...)) {
}

View File

@@ -89,7 +89,7 @@ template <class T>
class DebugBase : public QDebug {
public:
DebugBase() : QDebug(sNullDevice) {}
DebugBase(QtMsgType t) : QDebug(t) {}
explicit DebugBase(QtMsgType t) : QDebug(t) {}
T& space() { return static_cast<T&>(QDebug::space()); }
T& noSpace() { return static_cast<T&>(QDebug::nospace()); }
};
@@ -98,7 +98,7 @@ class DebugBase : public QDebug {
class BufferedDebug : public DebugBase<BufferedDebug> {
public:
BufferedDebug() {}
BufferedDebug(QtMsgType) : buf_(new QBuffer, later_deleter) {
explicit BufferedDebug(QtMsgType) : buf_(new QBuffer, later_deleter) {
buf_->open(QIODevice::WriteOnly);
// QDebug doesn't have a method to set a new io device, but swap() allows the devices to be swapped between two instances.
@@ -117,7 +117,7 @@ class BufferedDebug : public DebugBase<BufferedDebug> {
class LoggedDebug : public DebugBase<LoggedDebug> {
public:
LoggedDebug() {}
LoggedDebug(QtMsgType t) : DebugBase(t) { nospace() << kMessageHandlerMagic; }
explicit LoggedDebug(QtMsgType t) : DebugBase(t) { nospace() << kMessageHandlerMagic; }
};
static void MessageHandler(QtMsgType type, const QMessageLogContext&, const QString &message) {

View File

@@ -31,7 +31,7 @@ class _MessageReplyBase : public QObject {
Q_OBJECT
public:
_MessageReplyBase(QObject *parent = nullptr);
explicit _MessageReplyBase(QObject *parent = nullptr);
virtual int id() const = 0;
bool is_finished() const { return finished_; }
@@ -57,7 +57,7 @@ class _MessageReplyBase : public QObject {
template <typename MessageType>
class MessageReply : public _MessageReplyBase {
public:
MessageReply(const MessageType& request_message, QObject *parent = nullptr);
explicit MessageReply(const MessageType& request_message, QObject *parent = nullptr);
int id() const { return request_message_.id(); }
const MessageType& request_message() const { return request_message_; }

View File

@@ -46,7 +46,7 @@ class _WorkerPoolBase : public QObject {
Q_OBJECT
public:
_WorkerPoolBase(QObject *parent = nullptr);
explicit _WorkerPoolBase(QObject *parent = nullptr);
signals:
// Emitted when a worker failed to start. This usually happens when the worker wasn't found, or couldn't be executed.
@@ -67,7 +67,7 @@ protected slots:
template <typename HandlerType>
class WorkerPool : public _WorkerPoolBase {
public:
WorkerPool(QObject *parent = nullptr);
explicit WorkerPool(QObject *parent = nullptr);
~WorkerPool();
typedef typename HandlerType::MessageType MessageType;

View File

@@ -30,7 +30,7 @@ class QIODevice;
class TagReaderWorker : public AbstractMessageHandler<pb::tagreader::Message> {
public:
TagReaderWorker(QIODevice *socket, QObject *parent = nullptr);
explicit TagReaderWorker(QIODevice *socket, QObject *parent = nullptr);
protected:
void MessageArrived(const pb::tagreader::Message &message);