dryark/strawberry
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

TagReaderClient: Connect TagReaderReplyPtr

Browse Source 
Makes sure TagReaderReplyPtr is not deleted too early.

Partial fix for #1633
This commit is contained in:
Jonas Kvinge
2025-01-14 06:35:51 +01:00
parent 3e0a9fa388
commit decd0a1dc6
1 changed files with 10 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/tagreader/tagreaderclient.cpp
View File

@@ -384,7 +384,11 @@ void TagReaderClient::SaveSongsPlaycountAsync(const SongList &songs) {
Q_ASSERT(QThread::currentThread() != thread()); Q_ASSERT(QThread::currentThread() != thread());
for (const Song &song : songs) { for (const Song &song : songs) {
SaveSongPlaycountAsync(song.url().toLocalFile(), song.playcount()); SharedPtr<QMetaObject::Connection> connection = make_shared<QMetaObject::Connection>();
TagReaderReplyPtr reply = SaveSongPlaycountAsync(song.url().toLocalFile(), song.playcount());
*connection = QObject::connect(&*reply, &TagReaderReply::Finished, this, [reply, connection]() {
QObject::disconnect(*connection);
}, Qt::QueuedConnection);
} }
} }
@@ -417,7 +421,11 @@ void TagReaderClient::SaveSongsRatingAsync(const SongList &songs) {
Q_ASSERT(QThread::currentThread() != thread()); Q_ASSERT(QThread::currentThread() != thread());
for (const Song &song : songs) { for (const Song &song : songs) {
SaveSongRatingAsync(song.url().toLocalFile(), song.rating()); SharedPtr<QMetaObject::Connection> connection = make_shared<QMetaObject::Connection>();
TagReaderReplyPtr reply = SaveSongRatingAsync(song.url().toLocalFile(), song.rating());
*connection = QObject::connect(&*reply, &TagReaderReply::Finished, this, [reply, connection]() {
QObject::disconnect(*connection);
}, Qt::QueuedConnection);
} }
} }