dryark/strawberry
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Optimize Song::InitFromQuery

Browse Source 
Use `QSqlQuery::value(int)` or `QSqlRecord::value(int)` instead of `QSqlQuery::value(QString)`.
Make `SqlRow` use `QSqlRecord` directly instead iterating over all columns.
This commit is contained in:
Jonas Kvinge
2024-04-21 15:42:22 +02:00
parent 7b88be2635
commit df070ac0cf
16 changed files with 266 additions and 184 deletions
Download Patch File Download Diff File Expand all files Collapse all files

30
src/core/sqlrow.h
View File

@@ -1,6 +1,6 @@
/*
* Strawberry Music Player
* Copyright 2018-2021, Jonas Kvinge <jonas@jkvinge.net>
* Copyright 2018-2024, Jonas Kvinge <jonas@jkvinge.net>
*
* Strawberry is free software: you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
@@ -24,33 +24,23 @@
#include <QList>
#include <QVariant>
#include <QUrl>
#include <QSqlQuery>
#include <QSqlRecord>
#include "sqlquery.h"
class SqlRow {
public:
SqlRow(const QSqlQuery &query);
explicit SqlRow(const SqlQuery &query);
const QVariant value(const int number) const;
const QVariant value(const QString &name) const;
QString ValueToString(const QString &n) const;
QUrl ValueToUrl(const QString &n) const;
int ValueToInt(const QString &n) const;
uint ValueToUInt(const QString &n) const;
qint64 ValueToLongLong(const QString &n) const;
float ValueToFloat(const QString &n) const;
bool ValueToBool(const QString& n) const;
int columns() const { return record_.count(); }
const QSqlRecord &record() const { return record_; }
const QVariant value(const int n) const;
private:
SqlRow();
void Init(const QSqlQuery &query);
QMap<int, QVariant> columns_by_number_;
QMap<QString, QVariant> columns_by_name_;
void Init(const SqlQuery &query);
QSqlRecord record_;
};
using SqlRowList = QList<SqlRow>;