From e3a333564a09b2fae6b9a03c626c774896104e47 Mon Sep 17 00:00:00 2001 From: Roman Lebedev Date: Tue, 27 Jun 2023 05:05:27 +0300 Subject: [PATCH] `GstEngine::Load()`: different loudness-normalizing gain means new pipeline This is a bit of a gotcha, there should be a point (where we seek?) where we'd be able to change said gain, but for now this is a simple[r] stop-gap fix. --- src/engine/gstengine.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/engine/gstengine.cpp b/src/engine/gstengine.cpp index 42307a1e1..813c0172d 100644 --- a/src/engine/gstengine.cpp +++ b/src/engine/gstengine.cpp @@ -190,8 +190,9 @@ bool GstEngine::Load(const QUrl &media_url, const QUrl &stream_url, const Engine crossfade = false; } - if (!crossfade && current_pipeline_ && current_pipeline_->stream_url() == stream_url && change & EngineBase::TrackChangeType::Auto) { + if (!crossfade && current_pipeline_ && current_pipeline_->stream_url() == stream_url && current_pipeline_->ebur128_loudness_normalizing_gain_db() == ebur128_loudness_normalizing_gain_db_ && change & EngineBase::TrackChangeType::Auto) { // We're not crossfading, and the pipeline is already playing the URI we want, so just do nothing. + // FIXME: can we handle changing of loudness-normalizing gain here? return true; }