From e56e58b634b1db7319682c2da88552dd5ac7d599 Mon Sep 17 00:00:00 2001 From: Jonas Kvinge Date: Sun, 6 Aug 2023 13:44:57 +0200 Subject: [PATCH] GstEnginePipeline: Always set use-buffering --- src/engine/gstenginepipeline.cpp | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/src/engine/gstenginepipeline.cpp b/src/engine/gstenginepipeline.cpp index f89916d71..e9cd549f6 100644 --- a/src/engine/gstenginepipeline.cpp +++ b/src/engine/gstenginepipeline.cpp @@ -644,15 +644,13 @@ bool GstEnginePipeline::InitAudioBin(QString &error) { // We set this on this queue instead of the playbin because setting it on the playbin only affects network sources. // Disable the default buffer and byte limits, so we only buffer based on time. + qLog(Debug) << "Setting buffer duration:" << buffer_duration_nanosec_ << "low watermark:" << buffer_low_watermark_ << "high watermark:" << buffer_high_watermark_; + g_object_set(G_OBJECT(audioqueue_), "use-buffering", true, nullptr); g_object_set(G_OBJECT(audioqueue_), "max-size-buffers", 0, nullptr); g_object_set(G_OBJECT(audioqueue_), "max-size-bytes", 0, nullptr); - if (buffer_duration_nanosec_ > 0) { - qLog(Debug) << "Setting buffer duration:" << buffer_duration_nanosec_ << "low watermark:" << buffer_low_watermark_ << "high watermark:" << buffer_high_watermark_; - g_object_set(G_OBJECT(audioqueue_), "use-buffering", true, nullptr); - g_object_set(G_OBJECT(audioqueue_), "max-size-time", buffer_duration_nanosec_, nullptr); - g_object_set(G_OBJECT(audioqueue_), "low-watermark", buffer_low_watermark_, nullptr); - g_object_set(G_OBJECT(audioqueue_), "high-watermark", buffer_high_watermark_, nullptr); - } + g_object_set(G_OBJECT(audioqueue_), "max-size-time", buffer_duration_nanosec_, nullptr); + g_object_set(G_OBJECT(audioqueue_), "low-watermark", buffer_low_watermark_, nullptr); + g_object_set(G_OBJECT(audioqueue_), "high-watermark", buffer_high_watermark_, nullptr); // Link all elements