dryark/strawberry
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

MoodbarPipeline: Use bytearray directly

Browse Source
This commit is contained in:
Jonas Kvinge
2025-01-06 21:28:33 +01:00
parent 7527d2ea9a
commit eb83f23125
2 changed files with 10 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
src/moodbar/moodbarpipeline.cpp
View File

@@ -62,18 +62,18 @@ MoodbarPipeline::~MoodbarPipeline() {
} }
GstElement *MoodbarPipeline::CreateElement(const QString &factory_name) { GstElement *MoodbarPipeline::CreateElement(const QByteArray &factory_name) {
GstElement *ret = gst_element_factory_make(factory_name.toLatin1().constData(), nullptr); GstElement *element = gst_element_factory_make(factory_name.constData(), nullptr);
if (ret) { if (element) {
gst_bin_add(GST_BIN(pipeline_), ret); gst_bin_add(GST_BIN(pipeline_), element);
} }
else { else {
qLog(Warning) << "Unable to create gstreamer element" << factory_name; qLog(Warning) << "Unable to create gstreamer element" << factory_name;
} }
return ret; return element;
} }
@@ -100,10 +100,10 @@ void MoodbarPipeline::Start() {
pipeline_ = gst_pipeline_new("moodbar-pipeline"); pipeline_ = gst_pipeline_new("moodbar-pipeline");
GstElement *decodebin = CreateElement(u"uridecodebin"_s); GstElement *decodebin = CreateElement("uridecodebin");
convert_element_ = CreateElement(u"audioconvert"_s); convert_element_ = CreateElement("audioconvert");
GstElement *spectrum = CreateElement(u"strawberry-fastspectrum"_s); GstElement *spectrum = CreateElement("strawberry-fastspectrum");
GstElement *fakesink = CreateElement(u"fakesink"_s); GstElement *fakesink = CreateElement("fakesink");
if (!decodebin || !convert_element_ || !spectrum || !fakesink) { if (!decodebin || !convert_element_ || !spectrum || !fakesink) {
gst_object_unref(GST_OBJECT(pipeline_)); gst_object_unref(GST_OBJECT(pipeline_));

2
src/moodbar/moodbarpipeline.h
View File

@@ -54,7 +54,7 @@ class MoodbarPipeline : public QObject {
void Finished(const bool success); void Finished(const bool success);
private: private:
GstElement *CreateElement(const QString &factory_name); GstElement *CreateElement(const QByteArray &factory_name);
QByteArray ToGstUrl(const QUrl &url); QByteArray ToGstUrl(const QUrl &url);
void ReportError(GstMessage *msg); void ReportError(GstMessage *msg);