Replace async GetFileFromPathAsync().get() with synchronous CreateFromUri() to avoid blocking STA thread. This prevents the "sta thread blocking wait" assertion failure. Co-authored-by: jonaski <10343810+jonaski@users.noreply.github.com>
304 lines
9.7 KiB
C++
304 lines
9.7 KiB
C++
/*
|
|
* Strawberry Music Player
|
|
* Copyright 2025, Jonas Kvinge <jonas@jkvinge.net>
|
|
*
|
|
* Strawberry is free software: you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License as published by
|
|
* the Free Software Foundation, either version 3 of the License, or
|
|
* (at your option) any later version.
|
|
*
|
|
* Strawberry is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with Strawberry. If not, see <http://www.gnu.org/licenses/>.
|
|
*
|
|
*/
|
|
|
|
#include "config.h"
|
|
|
|
#include <windows.h>
|
|
|
|
#include <QObject>
|
|
#include <QString>
|
|
#include <QUrl>
|
|
|
|
// Undefine 'interface' macro from windows.h before including WinRT headers
|
|
#pragma push_macro("interface")
|
|
#undef interface
|
|
|
|
#include <winrt/Windows.Foundation.h>
|
|
#include <winrt/Windows.Media.h>
|
|
#include <winrt/Windows.Storage.h>
|
|
#include <winrt/Windows.Storage.Streams.h>
|
|
|
|
#pragma pop_macro("interface")
|
|
|
|
// Include the interop header for ISystemMediaTransportControlsInterop
|
|
#include <systemmediatransportcontrolsinterop.h>
|
|
|
|
#include "core/logging.h"
|
|
#include "windowsmediacontroller.h"
|
|
|
|
#include "core/song.h"
|
|
#include "core/player.h"
|
|
#include "engine/enginebase.h"
|
|
#include "playlist/playlistmanager.h"
|
|
#include "covermanager/currentalbumcoverloader.h"
|
|
#include "covermanager/albumcoverloaderresult.h"
|
|
|
|
using namespace winrt;
|
|
using namespace Windows::Foundation;
|
|
using namespace Windows::Media;
|
|
using namespace Windows::Storage;
|
|
using namespace Windows::Storage::Streams;
|
|
|
|
// Helper struct to hold the WinRT object
|
|
struct WindowsMediaControllerPrivate {
|
|
SystemMediaTransportControls smtc{nullptr};
|
|
};
|
|
|
|
WindowsMediaController::WindowsMediaController(HWND hwnd,
|
|
const SharedPtr<Player> player,
|
|
const SharedPtr<PlaylistManager> playlist_manager,
|
|
const SharedPtr<CurrentAlbumCoverLoader> current_albumcover_loader,
|
|
QObject *parent)
|
|
: QObject(parent),
|
|
player_(player),
|
|
playlist_manager_(playlist_manager),
|
|
current_albumcover_loader_(current_albumcover_loader),
|
|
smtc_(nullptr),
|
|
apartment_initialized_(false) {
|
|
|
|
try {
|
|
// Initialize WinRT apartment if not already initialized
|
|
// Qt or other components may have already initialized it
|
|
try {
|
|
winrt::init_apartment(winrt::apartment_type::single_threaded);
|
|
apartment_initialized_ = true;
|
|
}
|
|
catch (const hresult_error &e) {
|
|
// Apartment already initialized - this is fine, continue
|
|
if (e.code() != RPC_E_CHANGED_MODE) {
|
|
throw;
|
|
}
|
|
}
|
|
|
|
// Create private implementation
|
|
auto *priv = new WindowsMediaControllerPrivate();
|
|
smtc_ = priv;
|
|
|
|
// Get the SystemMediaTransportControls instance for this window
|
|
// Use the interop interface
|
|
auto interop = winrt::get_activation_factory<SystemMediaTransportControls, ISystemMediaTransportControlsInterop>();
|
|
|
|
if (!interop) {
|
|
qLog(Warning) << "Failed to get ISystemMediaTransportControlsInterop";
|
|
delete priv;
|
|
smtc_ = nullptr;
|
|
return;
|
|
}
|
|
|
|
// Get SMTC for the window
|
|
winrt::com_ptr<IInspectable> inspectable;
|
|
HRESULT hr = interop->GetForWindow(hwnd, winrt::guid_of<SystemMediaTransportControls>(), inspectable.put_void());
|
|
|
|
if (FAILED(hr) || !inspectable) {
|
|
qLog(Warning) << "Failed to get SystemMediaTransportControls for window, HRESULT:" << Qt::hex << static_cast<unsigned int>(hr);
|
|
delete priv;
|
|
smtc_ = nullptr;
|
|
return;
|
|
}
|
|
|
|
// Convert to SystemMediaTransportControls
|
|
priv->smtc = inspectable.as<SystemMediaTransportControls>();
|
|
|
|
if (!priv->smtc) {
|
|
qLog(Warning) << "Failed to cast to SystemMediaTransportControls";
|
|
delete priv;
|
|
smtc_ = nullptr;
|
|
return;
|
|
}
|
|
|
|
// Enable the controls
|
|
priv->smtc.IsEnabled(true);
|
|
priv->smtc.IsPlayEnabled(true);
|
|
priv->smtc.IsPauseEnabled(true);
|
|
priv->smtc.IsStopEnabled(true);
|
|
priv->smtc.IsNextEnabled(true);
|
|
priv->smtc.IsPreviousEnabled(true);
|
|
|
|
// Setup button handlers
|
|
SetupButtonHandlers();
|
|
|
|
// Connect signals from Player
|
|
QObject::connect(&*player_->engine(), &EngineBase::StateChanged, this, &WindowsMediaController::EngineStateChanged);
|
|
QObject::connect(&*playlist_manager_, &PlaylistManager::CurrentSongChanged, this, &WindowsMediaController::CurrentSongChanged);
|
|
QObject::connect(&*current_albumcover_loader_, &CurrentAlbumCoverLoader::AlbumCoverLoaded, this, &WindowsMediaController::AlbumCoverLoaded);
|
|
|
|
qLog(Info) << "Windows Media Transport Controls initialized successfully";
|
|
}
|
|
catch (const hresult_error &e) {
|
|
qLog(Warning) << "Failed to initialize Windows Media Transport Controls:" << QString::fromWCharArray(e.message().c_str());
|
|
if (smtc_) {
|
|
delete static_cast<WindowsMediaControllerPrivate*>(smtc_);
|
|
smtc_ = nullptr;
|
|
}
|
|
}
|
|
catch (...) {
|
|
qLog(Warning) << "Failed to initialize Windows Media Transport Controls: unknown error";
|
|
if (smtc_) {
|
|
delete static_cast<WindowsMediaControllerPrivate*>(smtc_);
|
|
smtc_ = nullptr;
|
|
}
|
|
}
|
|
}
|
|
|
|
WindowsMediaController::~WindowsMediaController() {
|
|
if (smtc_) {
|
|
auto *priv = static_cast<WindowsMediaControllerPrivate*>(smtc_);
|
|
if (priv->smtc) {
|
|
priv->smtc.IsEnabled(false);
|
|
}
|
|
delete priv;
|
|
smtc_ = nullptr;
|
|
}
|
|
// Only uninit if we initialized the apartment
|
|
if (apartment_initialized_) {
|
|
winrt::uninit_apartment();
|
|
}
|
|
}
|
|
|
|
void WindowsMediaController::SetupButtonHandlers() {
|
|
if (!smtc_) return;
|
|
|
|
auto *priv = static_cast<WindowsMediaControllerPrivate*>(smtc_);
|
|
if (!priv->smtc) return;
|
|
|
|
// Handle button pressed events
|
|
priv->smtc.ButtonPressed([this](const SystemMediaTransportControls &, const SystemMediaTransportControlsButtonPressedEventArgs &args) {
|
|
switch (args.Button()) {
|
|
case SystemMediaTransportControlsButton::Play:
|
|
player_->Play();
|
|
break;
|
|
case SystemMediaTransportControlsButton::Pause:
|
|
player_->Pause();
|
|
break;
|
|
case SystemMediaTransportControlsButton::Stop:
|
|
player_->Stop();
|
|
break;
|
|
case SystemMediaTransportControlsButton::Next:
|
|
player_->Next();
|
|
break;
|
|
case SystemMediaTransportControlsButton::Previous:
|
|
player_->Previous();
|
|
break;
|
|
default:
|
|
break;
|
|
}
|
|
});
|
|
}
|
|
|
|
void WindowsMediaController::EngineStateChanged(EngineBase::State newState) {
|
|
UpdatePlaybackStatus(newState);
|
|
}
|
|
|
|
void WindowsMediaController::UpdatePlaybackStatus(EngineBase::State state) {
|
|
if (!smtc_) return;
|
|
|
|
auto *priv = static_cast<WindowsMediaControllerPrivate*>(smtc_);
|
|
if (!priv->smtc) return;
|
|
|
|
try {
|
|
switch (state) {
|
|
case EngineBase::State::Playing:
|
|
priv->smtc.PlaybackStatus(MediaPlaybackStatus::Playing);
|
|
break;
|
|
case EngineBase::State::Paused:
|
|
priv->smtc.PlaybackStatus(MediaPlaybackStatus::Paused);
|
|
break;
|
|
case EngineBase::State::Empty:
|
|
case EngineBase::State::Idle:
|
|
priv->smtc.PlaybackStatus(MediaPlaybackStatus::Stopped);
|
|
break;
|
|
}
|
|
}
|
|
catch (const hresult_error &e) {
|
|
qLog(Warning) << "Failed to update playback status:" << QString::fromWCharArray(e.message().c_str());
|
|
}
|
|
}
|
|
|
|
void WindowsMediaController::CurrentSongChanged(const Song &song) {
|
|
if (!song.is_valid()) {
|
|
return;
|
|
}
|
|
|
|
// Update metadata immediately with what we have
|
|
UpdateMetadata(song, QUrl());
|
|
|
|
// Album cover will be updated via AlbumCoverLoaded signal
|
|
}
|
|
|
|
void WindowsMediaController::AlbumCoverLoaded(const Song &song, const AlbumCoverLoaderResult &result) {
|
|
if (!song.is_valid()) {
|
|
return;
|
|
}
|
|
|
|
// Update metadata with album cover
|
|
UpdateMetadata(song, result.temp_cover_url.isEmpty() ? result.album_cover.cover_url : result.temp_cover_url);
|
|
}
|
|
|
|
void WindowsMediaController::UpdateMetadata(const Song &song, const QUrl &art_url) {
|
|
if (!smtc_) return;
|
|
|
|
auto *priv = static_cast<WindowsMediaControllerPrivate*>(smtc_);
|
|
if (!priv->smtc) return;
|
|
|
|
try {
|
|
// Get the updater
|
|
SystemMediaTransportControlsDisplayUpdater updater = priv->smtc.DisplayUpdater();
|
|
updater.Type(MediaPlaybackType::Music);
|
|
|
|
// Get the music properties
|
|
auto musicProperties = updater.MusicProperties();
|
|
|
|
// Set basic metadata
|
|
if (!song.title().isEmpty()) {
|
|
musicProperties.Title(winrt::hstring(song.title().toStdWString()));
|
|
}
|
|
if (!song.artist().isEmpty()) {
|
|
musicProperties.Artist(winrt::hstring(song.artist().toStdWString()));
|
|
}
|
|
if (!song.album().isEmpty()) {
|
|
musicProperties.AlbumTitle(winrt::hstring(song.album().toStdWString()));
|
|
}
|
|
|
|
// Set album art if available
|
|
if (art_url.isValid() && art_url.isLocalFile()) {
|
|
QString artPath = art_url.toLocalFile();
|
|
if (!artPath.isEmpty()) {
|
|
try {
|
|
// Use file:// URI to avoid async blocking in STA thread
|
|
QString fileUri = QUrl::fromLocalFile(artPath).toString();
|
|
auto thumbnailStream = RandomAccessStreamReference::CreateFromUri(
|
|
winrt::Windows::Foundation::Uri(winrt::hstring(fileUri.toStdWString()))
|
|
);
|
|
updater.Thumbnail(thumbnailStream);
|
|
current_song_art_url_ = artPath;
|
|
}
|
|
catch (const hresult_error &e) {
|
|
qLog(Debug) << "Failed to set album art:" << QString::fromWCharArray(e.message().c_str());
|
|
}
|
|
}
|
|
}
|
|
|
|
// Update the display
|
|
updater.Update();
|
|
}
|
|
catch (const hresult_error &e) {
|
|
qLog(Warning) << "Failed to update metadata:" << QString::fromWCharArray(e.message().c_str());
|
|
}
|
|
}
|