Add CMake options to suppress C++17 deprecation warnings for RapidJSON on Apple Clang

This commit introduces a new compile option in the discord-rpc CMake configuration to suppress C++17 deprecation warnings triggered by RapidJSON when compiled with AppleClang. Additionally, it treats Boost headers as system headers in the Strawberry library to reduce warning noise during builds with strict flags. These changes aim to improve the build experience and maintain cleaner output logs.

3rdparty/discord-rpc/CMakeLists.txt

@@ -33,6 +33,13 @@ if(APPLE)
   target_link_libraries(discord-rpc PRIVATE "-framework AppKit")
 endif()
 
+# RapidJSON (as packaged by Homebrew and others) can trigger C++17 deprecation
+# warnings (e.g. std::iterator) when compiled with AppleClang/libc++.
+# Keep the suppression narrowly scoped to this 3rdparty target.
+if(APPLE AND CMAKE_CXX_COMPILER_ID MATCHES "Clang")
+  target_compile_options(discord-rpc PRIVATE -Wno-deprecated-declarations)
+endif()
+
 if(WIN32)
   target_link_libraries(discord-rpc PRIVATE psapi advapi32)
 endif()

CMakeLists.txt

@@ -1517,6 +1517,21 @@ qt_add_resources(SOURCES data/data.qrc data/icons.qrc)
 
 add_library(strawberry_lib STATIC ${SOURCES})
 
+# Treat Boost headers as system headers to avoid noisy warnings from 3rdparty
+# Boost code (e.g. -Wold-style-cast) when building Strawberry with strict flags.
+set(_strawberry_boost_system_includes "")
+if(TARGET Boost::headers)
+  get_target_property(_strawberry_boost_system_includes Boost::headers INTERFACE_INCLUDE_DIRECTORIES)
+elseif(TARGET Boost::boost)
+  get_target_property(_strawberry_boost_system_includes Boost::boost INTERFACE_INCLUDE_DIRECTORIES)
+elseif(DEFINED Boost_INCLUDE_DIRS)
+  set(_strawberry_boost_system_includes "${Boost_INCLUDE_DIRS}")
+endif()
+if(_strawberry_boost_system_includes)
+  target_include_directories(strawberry_lib SYSTEM PRIVATE ${_strawberry_boost_system_includes})
+endif()
+unset(_strawberry_boost_system_includes)
+
 target_sources(strawberry PRIVATE src/main.cpp)
 
 if(WIN32)