dryark/strawberry
2
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Fix STA thread blocking crash on album art loading

Browse Source 
Replace async GetFileFromPathAsync().get() with synchronous CreateFromUri() to avoid blocking STA thread. This prevents the "sta thread blocking wait" assertion failure.

Co-authored-by: jonaski <10343810+jonaski@users.noreply.github.com>
This commit is contained in:
copilot-swe-agent[bot]
2025-12-28 21:51:28 +00:00
parent 4da4c9e267
commit d2afa8fd66
1 changed files with 5 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/core/windowsmediacontroller.cpp
View File

@@ -50,6 +50,7 @@
#include "covermanager/albumcoverloaderresult.h" #include "covermanager/albumcoverloaderresult.h"
using namespace winrt; using namespace winrt;
using namespace Windows::Foundation;
using namespace Windows::Media; using namespace Windows::Media;
using namespace Windows::Storage; using namespace Windows::Storage;
using namespace Windows::Storage::Streams; using namespace Windows::Storage::Streams;
@@ -279,8 +280,10 @@ void WindowsMediaController::UpdateMetadata(const Song &song, const QUrl &art_ur
QString artPath = art_url.toLocalFile(); QString artPath = art_url.toLocalFile();
if (!artPath.isEmpty()) { if (!artPath.isEmpty()) {
try { try {
auto thumbnailStream = RandomAccessStreamReference::CreateFromFile( // Use file:// URI to avoid async blocking in STA thread
StorageFile::GetFileFromPathAsync(winrt::hstring(artPath.toStdWString())).get() QString fileUri = QUrl::fromLocalFile(artPath).toString();
auto thumbnailStream = RandomAccessStreamReference::CreateFromUri(
winrt::Windows::Foundation::Uri(winrt::hstring(fileUri.toStdWString()))
); );
updater.Thumbnail(thumbnailStream); updater.Thumbnail(thumbnailStream);
current_song_art_url_ = artPath; current_song_art_url_ = artPath;