discord-rpc: Port to Qt Json

.clang-format

@@ -130,10 +130,7 @@ InsertBraces:    false
 InsertTrailingCommas: None
 JavaScriptQuotes: Leave
 JavaScriptWrapImports: true
-KeepEmptyLines:
+KeepEmptyLinesAtTheStartOfBlocks: true
-  AtEndOfFile: true
-  AtStartOfBlock: true
-  AtStartOfFile: true
 LambdaBodyIndentation: Signature
 MacroBlockBegin: ''
 MacroBlockEnd:   ''

.github/workflows/build.yml

@@ -15,7 +15,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        opensuse_version: [ 'tumbleweed', 'leap:15.6', 'leap:16.0' ]
+        opensuse_version: [ 'tumbleweed', 'leap:15.6' ]
     container:
       image: opensuse/${{matrix.opensuse_version}}
     steps:
@@ -27,11 +27,11 @@ jobs:
       - name: Upgrade packages (Leap)
         if: matrix.opensuse_version != 'tumbleweed'
         run: zypper -n --gpg-auto-import-keys up
-      - name: Install gcc
+      - name: Install gcc (Tumbleweed)
-        if: matrix.opensuse_version != 'leap:15.6'
+        if: matrix.opensuse_version == 'tumbleweed'
         run: zypper -n --gpg-auto-import-keys in gcc gcc-c++
-      - name: Install gcc (leap:15.6)
+      - name: Install gcc (Leap)
-        if: matrix.opensuse_version == 'leap:15.6'
+        if: matrix.opensuse_version != 'tumbleweed'
         run: zypper -n --gpg-auto-import-keys in gcc14 gcc14-c++
       - name: Install packages
         run: >
@@ -83,7 +83,7 @@ jobs:
             sparsehash-devel
             rapidjson-devel
       - name: Install kdsingleapplication-qt6-devel
-        if: matrix.opensuse_version != 'leap:15.6'
+        if: matrix.opensuse_version == 'tumbleweed'
         run: zypper -n --gpg-auto-import-keys in kdsingleapplication-qt6-devel
       - name: Build and install KDSingleApplication
         if: matrix.opensuse_version == 'leap:15.6'
@@ -97,7 +97,7 @@ jobs:
           cmake --build build --config Release --parallel 4
           cmake --install build
       - name: Checkout
-        uses: actions/checkout@v6
+        uses: actions/checkout@v4
         with:
           fetch-depth: 0
           submodules: recursive
@@ -115,14 +115,14 @@ jobs:
       - name: Copy source tarball
         working-directory: build
         run: cp strawberry-*.tar.xz /usr/src/packages/SOURCES/
-      - name: Build RPM
+      - name: Build RPM (Tumbleweed)
-        if: matrix.opensuse_version != 'leap:15.6'
+        if: matrix.opensuse_version == 'tumbleweed'
         env:
           RPM_BUILD_NCPUS: 4
         working-directory: build
         run: rpmbuild -ba strawberry.spec
-      - name: Build RPM (leap:15.6)
+      - name: Build RPM (Leap)
-        if: matrix.opensuse_version == 'leap:15.6'
+        if: matrix.opensuse_version != 'tumbleweed'
         env:
           RPM_BUILD_NCPUS: 4
           CC: gcc-14
@@ -134,14 +134,14 @@ jobs:
         run: echo "subdir=$(echo ${{matrix.opensuse_version}} | sed 's/leap:/lp/g' | sed 's/\.//g')" > $GITHUB_OUTPUT
       - name: Upload source
         if: matrix.opensuse_version == 'tumbleweed'
-        uses: actions/upload-artifact@v6
+        uses: actions/upload-artifact@v4
         with:
           name: source
           path: |
             /usr/src/packages/SOURCES/*.xz
       - name: Upload rpm
         if: matrix.opensuse_version != 'tumbleweed'
-        uses: actions/upload-artifact@v6
+        uses: actions/upload-artifact@v4
         with:
           name: opensuse-${{steps.set-subdir.outputs.subdir}}
           path: |
@@ -156,7 +156,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        fedora_version: [ '41', '42', '43' ]
+        fedora_version: [ '39', '40', '41', '42' ]
     container:
       image: fedora:${{matrix.fedora_version}}
     steps:
@@ -209,7 +209,7 @@ jobs:
             sparsehash-devel
             rapidjson-devel
       - name: Checkout
-        uses: actions/checkout@v6
+        uses: actions/checkout@v4
         with:
           fetch-depth: 0
           submodules: recursive
@@ -234,7 +234,7 @@ jobs:
         working-directory: build
         run: rpmbuild -ba strawberry.spec
       - name: Upload artifacts
-        uses: actions/upload-artifact@v6
+        uses: actions/upload-artifact@v4
         with:
           name: fedora-${{matrix.fedora_version}}
           path: |
@@ -307,7 +307,7 @@ jobs:
       - name: Remove files
         run: rm -rf /usr/lib64/qt6/lib/cmake/Qt6Sql/{Qt6QMYSQL*,Qt6QODBCD*,Qt6QPSQL*,Qt6QIBase*}
       - name: Checkout
-        uses: actions/checkout@v6
+        uses: actions/checkout@v4
         with:
           fetch-depth: 0
           submodules: recursive
@@ -333,7 +333,7 @@ jobs:
         run: rpmbuild -ba strawberry.spec
       - name: Upload artifacts
         if: matrix.openmandriva_version != 'cooker'
-        uses: actions/upload-artifact@v6
+        uses: actions/upload-artifact@v4
         with:
           name: openmandriva-${{matrix.openmandriva_version}}
           path: |
@@ -409,7 +409,7 @@ jobs:
           cmake --build build --config Release --parallel 4
           cmake --install build
       - name: Checkout
-        uses: actions/checkout@v6
+        uses: actions/checkout@v4
         with:
           fetch-depth: 0
           submodules: recursive
@@ -434,7 +434,7 @@ jobs:
         working-directory: build
         run: rpmbuild -ba strawberry.spec
       - name: Upload artifacts
-        uses: actions/upload-artifact@v6
+        uses: actions/upload-artifact@v4
         with:
           name: mageia-${{matrix.mageia_version}}
           path: |
@@ -449,7 +449,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        debian_version: [ 'bookworm', 'trixie', 'forky' ]
+        debian_version: [ 'bookworm', 'trixie' ]
     container:
       image: debian:${{matrix.debian_version}}
     steps:
@@ -499,11 +499,7 @@ jobs:
             qt6-tools-dev-tools
             qt6-l10n-tools
             rapidjson-dev
-      - name: Install KDSingleApplication
-        if: matrix.debian_version != 'bookworm'
-        run: apt install -y libkdsingleapplication-qt6-dev
       - name: Build and install KDSingleApplication
-        if: matrix.debian_version == 'bookworm'
         run: |
           git clone --depth 1 --recurse-submodules https://github.com/KDAB/KDSingleApplication
           cd KDSingleApplication
@@ -511,7 +507,7 @@ jobs:
           cmake --build build --config Release --parallel 4
           cmake --install build
       - name: Checkout
-        uses: actions/checkout@v6
+        uses: actions/checkout@v4
         with:
           fetch-depth: 0
           submodules: recursive
@@ -528,7 +524,7 @@ jobs:
       - name: Copy deb
         run: cp ../*.deb .
       - name: Upload artifacts
-        uses: actions/upload-artifact@v6
+        uses: actions/upload-artifact@v4
         with:
           name: debian-${{matrix.debian_version}}
           path: |
@@ -542,7 +538,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        ubuntu_version: [ 'noble', 'plucky', 'questing' ]
+        ubuntu_version: [ 'noble', 'oracular', 'plucky' ]
     container:
       image: ubuntu:${{matrix.ubuntu_version}}
     steps:
@@ -595,11 +591,7 @@ jobs:
             qt6-tools-dev-tools
             qt6-l10n-tools
             rapidjson-dev
-      - name: Install KDSingleApplication
-        if: matrix.ubuntu_version != 'noble' && matrix.ubuntu_version != 'plucky'
-        run: apt install -y libkdsingleapplication-qt6-dev
       - name: Build and install KDSingleApplication
-        if: matrix.ubuntu_version == 'noble' || matrix.ubuntu_version == 'plucky'
         run: |
           git clone --depth 1 --recurse-submodules https://github.com/KDAB/KDSingleApplication
           cd KDSingleApplication
@@ -607,7 +599,7 @@ jobs:
           cmake --build build --config Release --parallel 4
           cmake --install build
       - name: Checkout
-        uses: actions/checkout@v6
+        uses: actions/checkout@v4
         with:
           fetch-depth: 0
           submodules: recursive
@@ -624,7 +616,7 @@ jobs:
       - name: Copy deb
         run: cp ../*.deb ../*.ddeb .
       - name: Upload artifacts
-        uses: actions/upload-artifact@v6
+        uses: actions/upload-artifact@v4
         with:
           name: ubuntu-${{matrix.ubuntu_version}}
           path: |
@@ -639,7 +631,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        ubuntu_version: [ 'noble', 'plucky', 'questing' ]
+        ubuntu_version: [ 'noble', 'oracular', 'plucky' ]
     container:
       image: ubuntu:${{matrix.ubuntu_version}}
     steps:
@@ -699,7 +691,7 @@ jobs:
           DEBIAN_FRONTEND: noninteractive
         run: apt install -y keyboxd
       - name: Checkout
-        uses: actions/checkout@v6
+        uses: actions/checkout@v4
         with:
           fetch-depth: 0
           submodules: recursive
@@ -735,22 +727,16 @@ jobs:
     runs-on: ubuntu-latest
     steps:
     - name: Checkout
-      uses: actions/checkout@v6
+      uses: actions/checkout@v4
       with:
         fetch-depth: 0
         submodules: recursive
-    - name: Free disk space
-      run: |
-        df -h
-        sudo rm -rf /usr/share/dotnet /usr/local/lib/android /opt/ghc
-        sudo apt-get clean
-        df -h
     - name: Build FreeBSD
       id: build-freebsd
-      uses: vmactions/freebsd-vm@v1.3.2
+      uses: vmactions/freebsd-vm@v1.2.0
       with:
         usesh: true
-        mem: 8192
+        mem: 4096
         prepare: pkg install -y git cmake pkgconf boost-libs alsa-lib glib qt6-base qt6-tools sqlite gstreamer1 gstreamer1-plugins chromaprint libebur128 taglib libcdio libmtp gdk-pixbuf2 libgpod fftw3 icu kdsingleapplication googletest pulseaudio sparsehash rapidjson
         run: |
           set -e
@@ -766,13 +752,13 @@ jobs:
     runs-on: ubuntu-latest
     steps:
     - name: Checkout
-      uses: actions/checkout@v6
+      uses: actions/checkout@v4
       with:
         fetch-depth: 0
         submodules: recursive
     - name: Build OpenBSD
       id: build-openbsd
-      uses: vmactions/openbsd-vm@v1.2.9
+      uses: vmactions/openbsd-vm@v1.1.7
       with:
         usesh: true
         mem: 4096
@@ -793,7 +779,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        runner: [ 'macos-15-intel', 'macos-15' ]
+        runner: [ 'macos-13', 'macos-15' ]
         buildtype: [ 'release' ]
 
     runs-on: ${{ matrix.runner }}
@@ -802,7 +788,7 @@ jobs:
 
       - name: Set MACOSX_DEPLOYMENT_TARGET
         run: |
-          for i in 12 13 14 15; do
+          for i in 13 14 15; do
             if [ -d "/Library/Developer/CommandLineTools/SDKs/MacOSX${i}.sdk" ]; then
               echo "Using macOS SDK ${i}"
               echo "MACOSX_DEPLOYMENT_TARGET=${i}.0" >> $GITHUB_ENV
@@ -832,20 +818,20 @@ jobs:
           rm -f uninstall.sh
 
       - name: Checkout
-        uses: actions/checkout@v6
+        uses: actions/checkout@v4
         with:
           fetch-depth: 0
           submodules: recursive
 
       - name: Import certificate file
         if: github.repository == 'strawberrymusicplayer/strawberry' && github.event.pull_request.head.repo.fork == false
-        uses: apple-actions/import-codesign-certs@v6
+        uses: apple-actions/import-codesign-certs@v5
         with:
           p12-file-base64: ${{ secrets.APPLE_DEVELOPER_ID_CERTIFICATE }}
           p12-password: ${{ secrets.APPLE_DEVELOPER_ID_CERTIFICATE_PASSWORD }}
 
       - name: Download macOS dependencies
-        run: curl -f -O -L https://github.com/strawberrymusicplayer/strawberry-macos-dependencies$(test "${{env.arch}}" = "x86_64" && echo "-intel" || echo "")/releases/latest/download/strawberry-macos-${{env.arch}}-${{env.buildtype}}.tar.xz
+        run: curl -f -O -L https://github.com/strawberrymusicplayer/strawberry-macos-dependencies/releases/latest/download/strawberry-macos-${{env.arch}}-${{env.buildtype}}.tar.xz
 
       - name: Extract macOS dependencies
         run: sudo tar -C / -xf strawberry-macos-${{env.arch}}-${{env.buildtype}}.tar.xz
@@ -896,9 +882,9 @@ jobs:
         run: make deploy
 
       - name: Manually Codesign
-        if: github.repository == 'strawberrymusicplayer/strawberry' && github.event.pull_request.head.repo.fork == false && matrix.runner == 'macos-15-intel'
+        if: github.repository == 'strawberrymusicplayer/strawberry' && github.event.pull_request.head.repo.fork == false && matrix.runner == 'macos-13'
         working-directory: build
-        run: codesign -s 383J84DVB6 -f strawberry.app/Contents/Frameworks/{libpcre2-8.0.dylib,libpcre2-16.0.dylib,libpng16.16.dylib,libfreetype.6.dylib,libzstd.1.dylib,libbrotlicommon.1.dylib,libbrotlienc.1.dylib} strawberry.app/Contents/Frameworks/png.framework/png strawberry.app
+        run: codesign -s 383J84DVB6 -f strawberry.app/Contents/Frameworks/{libpcre2-8.0.dylib,libpcre2-16.0.dylib,libpng16.16.dylib,libfreetype.6.dylib,libzstd.1.dylib} strawberry.app/Contents/Frameworks/png.framework/png strawberry.app
 
       - name: Manually Codesign
         if: github.repository == 'strawberrymusicplayer/strawberry' && github.event.pull_request.head.repo.fork == false && matrix.runner == 'macos-15'
@@ -960,7 +946,7 @@ jobs:
 
       - name: Set MACOSX_DEPLOYMENT_TARGET
         run: |
-          for i in 12 13 14 15; do
+          for i in 13 14 15; do
             if [ -d "/Library/Developer/CommandLineTools/SDKs/MacOSX${i}.sdk" ]; then
               echo "Using macOS SDK ${i}"
               echo "MACOSX_DEPLOYMENT_TARGET=${i}.0" >> $GITHUB_ENV
@@ -983,7 +969,7 @@ jobs:
         run: echo "cmake_buildtype=$(echo ${{env.buildtype}} | awk '{print toupper(substr($0,0,1))tolower(substr($0,2))}')" >> $GITHUB_ENV
 
       - name: Checkout
-        uses: actions/checkout@v6
+        uses: actions/checkout@v4
         with:
           fetch-depth: 0
           submodules: recursive
@@ -1086,7 +1072,7 @@ jobs:
         run: echo "cmake_buildtype=$(echo ${{matrix.buildtype}} | sed 's/.*/\u&/')" >> $GITHUB_ENV
 
       - name: Checkout
-        uses: actions/checkout@v6
+        uses: actions/checkout@v4
         with:
           fetch-depth: 0
           submodules: recursive
@@ -1260,42 +1246,12 @@ jobs:
   build-windows-msvc:
     name: Build Windows MSVC
     if: github.repository != 'strawberrymusicplayer/strawberry-private' && github.ref != 'refs/heads/l10n_master'
+    runs-on: windows-2022
     strategy:
       fail-fast: false
       matrix:
-       include:
+        arch: [ 'x86', 'x86_64' ]
-         - name: "x86_64 debug"
+        buildtype: [ 'release' ]
-           runner: windows-2022
-           arch: x86_64
-           buildtype: debug
-
-         - name: "x86_64 release"
-           runner: windows-2022
-           arch: x86_64
-           buildtype: release
-
-         - name: "x86 debug"
-           runner: windows-2022
-           arch: x86
-           buildtype: debug
-
-         - name: "x86 release"
-           runner: windows-2022
-           arch: x86
-           buildtype: release
-
-         - name: "arm64 debug"
-           runner: windows-11-arm
-           arch: arm64
-           buildtype: debug
-
-         - name: "arm64 release"
-           runner: windows-11-arm
-           arch: arm64
-           buildtype: release
-
-    runs-on: ${{matrix.runner}}
-
     steps:
 
       - name: Set prefix path
@@ -1309,20 +1265,6 @@ jobs:
         shell: bash
         run: echo "cmake_buildtype=$(echo ${{matrix.buildtype}} | sed 's/.*/\u&/')" >> $GITHUB_ENV
 
-      - name: Show SDK versions
-        shell: bash
-        run: ls -la "c:/Program Files (x86)/Windows Kits/10/include"
-
-      - name: Set SDK version
-        if: matrix.arch != 'arm64'
-        shell: bash
-        run: echo "sdk_version=10.0.22621.0" >> $GITHUB_ENV
-
-      - name: Set SDK version
-        if: matrix.arch == 'arm64'
-        shell: bash
-        run: echo "sdk_version=10.0.26100.0" >> $GITHUB_ENV
-
       - name: Install rsync
         shell: cmd
         run: choco install --no-progress rsync
@@ -1351,9 +1293,7 @@ jobs:
 
       - name: Copy bin files
         shell: bash
-        run: |
+        run: cp /c/strawberry/c/bin/{patch.exe,strip.exe,strings.exe,objdump.exe} ${{env.prefix_path_unix}}/bin
-          cp /c/mingw64/bin/{strip.exe,strings.exe,objdump.exe} ${{env.prefix_path_unix}}/bin
-          cp /c/strawberry/c/bin/patch.exe ${{env.prefix_path_unix}}/bin
 
       - name: Delete conflicting files
         shell: bash
@@ -1407,11 +1347,11 @@ jobs:
         uses: ilammy/msvc-dev-cmd@v1
         with:
           arch: ${{matrix.arch}}
-          sdk: ${{env.sdk_version}}
+          sdk: 10.0.20348.0
           vsversion: 2022
 
       - name: Checkout
-        uses: actions/checkout@v6
+        uses: actions/checkout@v4
         with:
           fetch-depth: 0
           submodules: recursive
@@ -1424,18 +1364,15 @@ jobs:
         shell: cmd
         run: cmake -E make_directory build
 
-      - name: Set ENABLE_WIN32_CONSOLE
+      - name: Set ENABLE_WIN32_CONSOLE (debug)
+        if: matrix.buildtype == 'debug'
         shell: bash
-        run: echo "enable_win32_console=$(test "${{matrix.buildtype}}" = "debug" && echo "ON" || echo "OFF")" >> $GITHUB_ENV
+        run: echo "win32_console=ON" >> $GITHUB_ENV
 
-      - name: Set ENABLE_SPOTIFY
+      - name: Set ENABLE_WIN32_CONSOLE (release)
+        if: matrix.buildtype == 'release'
         shell: bash
-        run: echo "enable_spotify=$(test -f "${{env.prefix_path_unix}}/lib/gstreamer-1.0/gstspotify.dll" && echo "ON" || echo "OFF")" >> $GITHUB_ENV
+        run: echo "win32_console=OFF" >> $GITHUB_ENV
-
-      - name: Remove -lm from .pc files
-        if: matrix.arch == 'arm64'
-        shell: bash
-        run: sed -i 's/\-lm$//g' ${{env.prefix_path_unix}}/lib/pkgconfig/*.pc
 
       - name: Run CMake
         shell: cmd
@@ -1447,14 +1384,14 @@ jobs:
           -DCMAKE_BUILD_TYPE="${{env.cmake_buildtype}}"
           -DCMAKE_PREFIX_PATH="${{env.prefix_path_forwardslash}}/lib/cmake"
           -DARCH="${{matrix.arch}}"
-          -DENABLE_WIN32_CONSOLE=${{env.enable_win32_console}}
+          -DENABLE_WIN32_CONSOLE=${{env.win32_console}}
           -DPKG_CONFIG_EXECUTABLE="${{env.prefix_path_forwardslash}}/bin/pkg-config.exe"
           -DICU_ROOT="${{env.prefix_path_forwardslash}}"
           -DENABLE_GIO=OFF
           -DENABLE_AUDIOCD=OFF
           -DENABLE_MTP=OFF
           -DENABLE_GPOD=OFF
-          -DENABLE_SPOTIFY=${{env.enable_spotify}}
+          -DENABLE_SPOTIFY=ON
 
       - name: Run Make
         shell: cmd
@@ -1644,11 +1581,11 @@ jobs:
           DEBIAN_FRONTEND: noninteractive
         run: sudo apt install -y git rsync
       - name: Checkout
-        uses: actions/checkout@v6
+        uses: actions/checkout@v4
         with:
           fetch-depth: 0
       - name: Download artifacts
-        uses: actions/download-artifact@v7
+        uses: actions/download-artifact@v4
         with:
           path: artifacts
       - name: SSH Setup
@@ -1692,7 +1629,7 @@ jobs:
           DEBIAN_FRONTEND: noninteractive
         run: sudo apt install -y git jq gh
       - name: Checkout
-        uses: actions/checkout@v6
+        uses: actions/checkout@v4
         with:
           fetch-depth: 0
       - name: Show release assets
@@ -1700,7 +1637,7 @@ jobs:
           GITHUB_TOKEN: ${{secrets.GITHUB_TOKEN}}
         run: gh release view "${{github.event.release.tag_name}}" --json assets | jq -r '.assets[].name'
       - name: Download artifacts
-        uses: actions/download-artifact@v7
+        uses: actions/download-artifact@v4
         with:
           path: artifacts
       - name: Add artifacts to release

.gitignore

@@ -1,7 +1,6 @@
 /build
 /bin
 /CMakeLists.txt.user
-/.qtcreator
 /.kdev4
 /strawberry.kdev4
 /.vscode
@@ -13,4 +12,3 @@
 /CMakeSettings.json
 /dist/scripts/maketarball.sh
 /debian/changelog
-_codeql_detected_source_root

3rdparty/discord-rpc/CMakeLists.txt

@@ -37,5 +37,6 @@ if(WIN32)
   target_link_libraries(discord-rpc PRIVATE psapi advapi32)
 endif()
 
-target_include_directories(discord-rpc SYSTEM PRIVATE ${RapidJSON_INCLUDE_DIRS})
+target_link_libraries(discord-rpc PRIVATE Qt${QT_VERSION_MAJOR}::Core)
+
 target_include_directories(discord-rpc PRIVATE ${CMAKE_CURRENT_SOURCE_DIR})

3rdparty/discord-rpc/discord_connection.h

@@ -35,7 +35,7 @@ int GetProcessId();
 
 struct BaseConnection {
   static BaseConnection *Create();
-  static void Destroy(BaseConnection*&);
+  static void Destroy(BaseConnection *&);
   bool isOpen = false;
   bool Open();
   bool Close();

3rdparty/discord-rpc/discord_connection_unix.cpp

@@ -39,11 +39,11 @@ int GetProcessId() {
 }
 
 struct BaseConnectionUnix : public BaseConnection {
-  int sock{ -1 };
+  int sock { -1 };
 };
 
 static BaseConnectionUnix Connection;
-static sockaddr_un PipeAddr{};
+static sockaddr_un PipeAddr {};
 #ifdef MSG_NOSIGNAL
 static int MsgFlags = MSG_NOSIGNAL;
 #else
@@ -105,7 +105,7 @@ bool BaseConnection::Open() {
 
 bool BaseConnection::Close() {
 
-  auto self = reinterpret_cast<BaseConnectionUnix*>(this);
+  auto self = reinterpret_cast<BaseConnectionUnix *>(this);
   if (self->sock == -1) {
     return false;
   }

3rdparty/discord-rpc/discord_connection_win.cpp

@@ -38,7 +38,7 @@ int GetProcessId() {
 }
 
 struct BaseConnectionWin : public BaseConnection {
-  HANDLE pipe{ INVALID_HANDLE_VALUE };
+  HANDLE pipe { INVALID_HANDLE_VALUE };
 };
 
 static BaseConnectionWin Connection;
@@ -57,10 +57,10 @@ void BaseConnection::Destroy(BaseConnection *&c) {
 
 bool BaseConnection::Open() {
 
-  wchar_t pipeName[]{ L"\\\\?\\pipe\\discord-ipc-0" };
+  wchar_t pipeName[] { L"\\\\?\\pipe\\discord-ipc-0" };
   const size_t pipeDigit = sizeof(pipeName) / sizeof(wchar_t) - 2;
   pipeName[pipeDigit] = L'0';
-  auto self = reinterpret_cast<BaseConnectionWin*>(this);
+  auto self = reinterpret_cast<BaseConnectionWin *>(this);
   for (;;) {
     self->pipe = ::CreateFileW(pipeName, GENERIC_READ | GENERIC_WRITE, 0, nullptr, OPEN_EXISTING, 0, nullptr);
     if (self->pipe != INVALID_HANDLE_VALUE) {
@@ -88,7 +88,7 @@ bool BaseConnection::Open() {
 
 bool BaseConnection::Close() {
 
-  auto self = reinterpret_cast<BaseConnectionWin*>(this);
+  auto self = reinterpret_cast<BaseConnectionWin *>(this);
   ::CloseHandle(self->pipe);
   self->pipe = INVALID_HANDLE_VALUE;
   self->isOpen = false;
@@ -102,7 +102,7 @@ bool BaseConnection::Write(const void *data, size_t length) {
   if (length == 0) {
     return true;
   }
-  auto self = reinterpret_cast<BaseConnectionWin*>(this);
+  auto self = reinterpret_cast<BaseConnectionWin *>(this);
   assert(self);
   if (!self) {
     return false;
@@ -127,7 +127,7 @@ bool BaseConnection::Read(void *data, size_t length) {
   if (!data) {
     return false;
   }
-  auto self = reinterpret_cast<BaseConnectionWin*>(this);
+  auto self = reinterpret_cast<BaseConnectionWin *>(this);
   assert(self);
   if (!self) {
     return false;

3rdparty/discord-rpc/discord_msg_queue.h

@@ -34,9 +34,9 @@ namespace discord_rpc {
 template<typename ElementType, std::size_t QueueSize>
 class MsgQueue {
   ElementType queue_[QueueSize];
-  std::atomic_uint nextAdd_{ 0 };
+  std::atomic_uint nextAdd_ { 0 };
-  std::atomic_uint nextSend_{ 0 };
+  std::atomic_uint nextSend_ { 0 };
-  std::atomic_uint pendingSends_{ 0 };
+  std::atomic_uint pendingSends_ { 0 };
 
  public:
   MsgQueue() {}

3rdparty/discord-rpc/discord_register.h

@@ -24,11 +24,13 @@
 #ifndef DISCORD_REGISTER_H
 #define DISCORD_REGISTER_H
 
+#include <QString>
+
 #ifdef __cplusplus
 extern "C" {
 #endif
 
-void Discord_Register(const char *applicationId, const char *command);
+void Discord_Register(const QString &applicationId, const char *command);
 
 #ifdef __cplusplus
 }

3rdparty/discord-rpc/discord_register_linux.cpp

@@ -21,9 +21,6 @@
  *
  */
 
-#include "discord_rpc.h"
-#include "discord_register.h"
-
 #include <cstdio>
 #include <errno.h>
 #include <cstdlib>
@@ -32,6 +29,11 @@
 #include <sys/types.h>
 #include <unistd.h>
 
+#include <QString>
+
+#include "discord_rpc.h"
+#include "discord_register.h"
+
 namespace {
 
 static bool Mkdir(const char *path) {
@@ -48,7 +50,7 @@ static bool Mkdir(const char *path) {
 }  // namespace
 
 // We want to register games so we can run them from Discord client as discord-<appid>://
-extern "C" void Discord_Register(const char *applicationId, const char *command) {
+extern "C" void Discord_Register(const QString &applicationId, const char *command) {
 
   // Add a desktop file and update some mime handlers so that xdg-open does the right thing.
 
@@ -75,13 +77,13 @@ extern "C" void Discord_Register(const char *applicationId, const char *command)
                                        "Categories=Discord;Games;\n"
                                        "MimeType=x-scheme-handler/discord-%s;\n";
   char desktopFile[2048]{};
-  int fileLen = snprintf(desktopFile, sizeof(desktopFile), desktopFileFormat, applicationId, command, applicationId);
+  int fileLen = snprintf(desktopFile, sizeof(desktopFile), desktopFileFormat, applicationId.toUtf8().constData(), command, applicationId.toUtf8().constData());
   if (fileLen <= 0) {
     return;
   }
 
   char desktopFilename[256]{};
-  (void)snprintf(desktopFilename, sizeof(desktopFilename), "/discord-%s.desktop", applicationId);
+  (void)snprintf(desktopFilename, sizeof(desktopFilename), "/discord-%s.desktop", applicationId.toUtf8().constData());
 
   char desktopFilePath[1024]{};
   (void)snprintf(desktopFilePath, sizeof(desktopFilePath), "%s/.local", home);
@@ -111,8 +113,8 @@ extern "C" void Discord_Register(const char *applicationId, const char *command)
   snprintf(xdgMimeCommand,
            sizeof(xdgMimeCommand),
            "xdg-mime default discord-%s.desktop x-scheme-handler/discord-%s",
-           applicationId,
+           applicationId.toUtf8().constData(),
-           applicationId);
+           applicationId.toUtf8().constData());
   if (system(xdgMimeCommand) < 0) {
     fprintf(stderr, "Failed to register mime handler\n");
   }

3rdparty/discord-rpc/discord_register_osx.m

@@ -84,15 +84,17 @@ static void RegisterURL(const char *applicationId) {
 
 }
 
-void Discord_Register(const char *applicationId, const char *command) {
+void Discord_Register(const QString &applicationId, const char *command) {
+
+  const QByteArray applicationIdData = applicationId.toUtf8();
 
   if (command) {
-    RegisterCommand(applicationId, command);
+    RegisterCommand(applicationIdData.constData(), command);
   }
   else {
     // raii lite
     @autoreleasepool {
-      RegisterURL(applicationId);
+      RegisterURL(applicationIdData.constData());
     }
   }
 

3rdparty/discord-rpc/discord_register_win.cpp

@@ -147,10 +147,10 @@ static void Discord_RegisterW(const wchar_t *applicationId, const wchar_t *comma
 
 }
 
-extern "C" void Discord_Register(const char *applicationId, const char *command) {
+extern "C" void Discord_Register(const QString &applicationId, const char *command) {
 
   wchar_t appId[32]{};
-  MultiByteToWideChar(CP_UTF8, 0, applicationId, -1, appId, 32);
+  MultiByteToWideChar(CP_UTF8, 0, applicationId.toUtf8().constData(), -1, appId, 32);
 
   wchar_t openCommand[1024]{};
   const wchar_t *wcommand = nullptr;
@@ -163,3 +163,4 @@ extern "C" void Discord_Register(const char *applicationId, const char *command)
   Discord_RegisterW(appId, wcommand);
 
 }
+

3rdparty/discord-rpc/discord_rpc.cpp

@@ -27,6 +27,10 @@
 #include <condition_variable>
 #include <thread>
 
+#include <QString>
+#include <QJsonDocument>
+#include <QJsonObject>
+
 #include "discord_rpc.h"
 #include "discord_backoff.h"
 #include "discord_register.h"
@@ -34,15 +38,13 @@
 #include "discord_rpc_connection.h"
 #include "discord_serialization.h"
 
-using namespace discord_rpc;
+using namespace Qt::Literals::StringLiterals;
 
-static void Discord_UpdateConnection();
+namespace discord_rpc {
 
-namespace {
+constexpr size_t MaxMessageSize { 16 * 1024 };
-
+constexpr size_t MessageQueueSize { 8 };
-constexpr size_t MaxMessageSize{ 16 * 1024 };
+constexpr size_t JoinQueueSize { 8 };
-constexpr size_t MessageQueueSize{ 8 };
-constexpr size_t JoinQueueSize{ 8 };
 
 struct QueuedMessage {
   size_t length;
@@ -56,38 +58,40 @@ struct QueuedMessage {
   }
 };
 
-struct User {
+class User {
+ public:
+  explicit User() {}
   // snowflake (64bit int), turned into a ascii decimal string, at most 20 chars +1 null
   // terminator = 21
-  char userId[32];
+  QString userId;
   // 32 unicode glyphs is max name size => 4 bytes per glyph in the worst case, +1 for null
   // terminator = 129
-  char username[344];
+  QString username;
   // 4 decimal digits + 1 null terminator = 5
-  char discriminator[8];
+  QString discriminator;
   // optional 'a_' + md5 hex digest (32 bytes) + null terminator = 35
-  char avatar[128];
+  QString avatar;
   // Rounded way up because I'm paranoid about games breaking from future changes in these sizes
 };
 
-static RpcConnection *Connection{ nullptr };
+static RpcConnection *Connection { nullptr };
-static DiscordEventHandlers QueuedHandlers{};
+static DiscordEventHandlers QueuedHandlers {};
-static DiscordEventHandlers Handlers{};
+static DiscordEventHandlers Handlers {};
-static std::atomic_bool WasJustConnected{ false };
+static std::atomic_bool WasJustConnected { false };
-static std::atomic_bool WasJustDisconnected{ false };
+static std::atomic_bool WasJustDisconnected { false };
-static std::atomic_bool GotErrorMessage{ false };
+static std::atomic_bool GotErrorMessage { false };
-static std::atomic_bool WasJoinGame{ false };
+static std::atomic_bool WasJoinGame { false };
-static std::atomic_bool WasSpectateGame{ false };
+static std::atomic_bool WasSpectateGame { false };
-static std::atomic_bool UpdatePresence{ false };
+static std::atomic_bool UpdatePresence { false };
-static char JoinGameSecret[256];
+static QString JoinGameSecret;
-static char SpectateGameSecret[256];
+static QString SpectateGameSecret;
-static int LastErrorCode{ 0 };
+static int LastErrorCode { 0 };
-static char LastErrorMessage[256];
+static QString LastErrorMessage;
-static int LastDisconnectErrorCode{ 0 };
+static int LastDisconnectErrorCode { 0 };
-static char LastDisconnectErrorMessage[256];
+static QString LastDisconnectErrorMessage;
 static std::mutex PresenceMutex;
 static std::mutex HandlerMutex;
-static QueuedMessage QueuedPresence{};
+static QueuedMessage QueuedPresence {};
 static MsgQueue<QueuedMessage, MessageQueueSize> SendQueue;
 static MsgQueue<User, JoinQueueSize> JoinAskQueue;
 static User connectedUser;
@@ -95,12 +99,13 @@ static User connectedUser;
 // We want to auto connect, and retry on failure, but not as fast as possible. This does expoential backoff from 0.5 seconds to 1 minute
 static Backoff ReconnectTimeMs(500, 60 * 1000);
 static auto NextConnect = std::chrono::system_clock::now();
-static int Pid{ 0 };
+static int Pid { 0 };
-static int Nonce{ 1 };
+static int Nonce { 1 };
 
+static void Discord_UpdateConnection(void);
 class IoThreadHolder {
  private:
-  std::atomic_bool keepRunning{ true };
+  std::atomic_bool keepRunning { true };
   std::mutex waitForIOMutex;
   std::condition_variable waitForIOActivity;
   std::thread ioThread;
@@ -109,14 +114,14 @@ class IoThreadHolder {
   void Start() {
     keepRunning.store(true);
     ioThread = std::thread([&]() {
-        const std::chrono::duration<int64_t, std::milli> maxWait { 500LL };
+      const std::chrono::duration<int64_t, std::milli> maxWait { 500LL };
+      Discord_UpdateConnection();
+      while (keepRunning.load()) {
+        std::unique_lock<std::mutex> lock(waitForIOMutex);
+        waitForIOActivity.wait_for(lock, maxWait);
         Discord_UpdateConnection();
-        while (keepRunning.load()) {
+      }
-          std::unique_lock<std::mutex> lock(waitForIOMutex);
+    });
-          waitForIOActivity.wait_for(lock, maxWait);
-          Discord_UpdateConnection();
-        }
-      });
   }
 
   void Notify() { waitForIOActivity.notify_all(); }
@@ -131,8 +136,7 @@ class IoThreadHolder {
 
   ~IoThreadHolder() { Stop(); }
 };
-
+static IoThreadHolder *IoThread { nullptr };
-static IoThreadHolder *IoThread{ nullptr };
 
 static void UpdateReconnectTime() {
 
@@ -140,6 +144,110 @@ static void UpdateReconnectTime() {
 
 }
 
+static void Discord_UpdateConnection() {
+
+  if (!Connection) {
+    return;
+  }
+
+  if (!Connection->IsOpen()) {
+    if (std::chrono::system_clock::now() >= NextConnect) {
+      UpdateReconnectTime();
+      Connection->Open();
+    }
+  }
+  else {
+    // reads
+
+    for (;;) {
+      QJsonDocument json_document;
+      if (!Connection->Read(json_document)) {
+        break;
+      }
+
+      const QJsonObject json_object = json_document.object();
+      const QString event_name = json_object["evt"_L1].toString();
+      const QString nonce = json_object["nonce"_L1].toString();
+
+      if (json_object.contains("nonce"_L1)) {
+        // in responses only -- should use to match up response when needed.
+
+        if (event_name == "ERROR"_L1) {
+          const QJsonObject data = json_object["data"_L1].toObject();
+          LastErrorCode = data["code"_L1].toInt();
+          LastErrorMessage = data["message"_L1].toString();
+          GotErrorMessage.store(true);
+        }
+      }
+      else {
+        // should have evt == name of event, optional data
+        if (event_name.isEmpty()) {
+          continue;
+        }
+
+        const QJsonObject data = json_object["data"_L1].toObject();
+
+        if (event_name == "ACTIVITY_JOIN"_L1) {
+          if (data.contains("secret"_L1)) {
+            JoinGameSecret = data["secret"_L1].toString();
+            WasJoinGame.store(true);
+          }
+        }
+        else if (event_name == "ACTIVITY_SPECTATE"_L1) {
+          if (data.contains("secret"_L1)) {
+            SpectateGameSecret = data["secret"_L1].toString();
+            WasSpectateGame.store(true);
+          }
+        }
+        else if (event_name == "ACTIVITY_JOIN_REQUEST"_L1) {
+          const QJsonObject user = data["user"_L1].toObject();
+          const QString userId = user["id"_L1].toString();
+          const QString username = user["username"_L1].toString();
+          const QString avatar = user["avatar"_L1].toString();
+          const auto joinReq = JoinAskQueue.GetNextAddMessage();
+          if (!userId.isEmpty() && !username.isEmpty() && joinReq) {
+            joinReq->userId = userId;
+            joinReq->username = username;
+            const QString discriminator = user["discriminator"_L1].toString();
+            if (!discriminator.isEmpty()) {
+              joinReq->discriminator =  discriminator;
+            }
+            if (!avatar.isEmpty()) {
+              joinReq->avatar = avatar;
+            }
+            else {
+              joinReq->avatar.clear();
+            }
+            JoinAskQueue.CommitAdd();
+          }
+        }
+      }
+    }
+
+    // writes
+    if (UpdatePresence.exchange(false) && QueuedPresence.length) {
+      QueuedMessage local;
+      {
+        std::lock_guard<std::mutex> guard(PresenceMutex);
+        local.Copy(QueuedPresence);
+      }
+      if (!Connection->Write(local.buffer, local.length)) {
+        // if we fail to send, requeue
+        std::lock_guard<std::mutex> guard(PresenceMutex);
+        QueuedPresence.Copy(local);
+        UpdatePresence.exchange(true);
+      }
+    }
+
+    while (SendQueue.HavePendingSends()) {
+      auto qmessage = SendQueue.GetNextSendMessage();
+      Connection->Write(qmessage->buffer, qmessage->length);
+      SendQueue.CommitSend();
+    }
+  }
+
+}
+
 static void SignalIOActivity() {
 
   if (IoThread != nullptr) {
@@ -176,115 +284,7 @@ static bool DeregisterForEvent(const char *evtName) {
 
 }
 
-} // namespace
+extern "C" void Discord_Initialize(const QString &applicationId, DiscordEventHandlers *handlers, const int autoRegister) {
-
-static void Discord_UpdateConnection() {
-
-  if (!Connection) {
-    return;
-  }
-
-  if (!Connection->IsOpen()) {
-    if (std::chrono::system_clock::now() >= NextConnect) {
-      UpdateReconnectTime();
-      Connection->Open();
-    }
-  }
-  else {
-    // reads
-
-    for (;;) {
-      JsonDocument message;
-
-      if (!Connection->Read(message)) {
-        break;
-      }
-
-      const char *evtName = GetStrMember(&message, "evt");
-      const char *nonce = GetStrMember(&message, "nonce");
-
-      if (nonce) {
-        // in responses only -- should use to match up response when needed.
-
-        if (evtName && strcmp(evtName, "ERROR") == 0) {
-          auto data = GetObjMember(&message, "data");
-          LastErrorCode = GetIntMember(data, "code");
-          StringCopy(LastErrorMessage, GetStrMember(data, "message", ""));
-          GotErrorMessage.store(true);
-        }
-      }
-      else {
-        // should have evt == name of event, optional data
-        if (evtName == nullptr) {
-          continue;
-        }
-
-        auto data = GetObjMember(&message, "data");
-
-        if (strcmp(evtName, "ACTIVITY_JOIN") == 0) {
-          auto secret = GetStrMember(data, "secret");
-          if (secret) {
-            StringCopy(JoinGameSecret, secret);
-            WasJoinGame.store(true);
-          }
-        }
-        else if (strcmp(evtName, "ACTIVITY_SPECTATE") == 0) {
-          auto secret = GetStrMember(data, "secret");
-          if (secret) {
-            StringCopy(SpectateGameSecret, secret);
-            WasSpectateGame.store(true);
-          }
-        }
-        else if (strcmp(evtName, "ACTIVITY_JOIN_REQUEST") == 0) {
-          auto user = GetObjMember(data, "user");
-          auto userId = GetStrMember(user, "id");
-          auto username = GetStrMember(user, "username");
-          auto avatar = GetStrMember(user, "avatar");
-          auto joinReq = JoinAskQueue.GetNextAddMessage();
-          if (userId && username && joinReq) {
-            StringCopy(joinReq->userId, userId);
-            StringCopy(joinReq->username, username);
-            auto discriminator = GetStrMember(user, "discriminator");
-            if (discriminator) {
-              StringCopy(joinReq->discriminator, discriminator);
-            }
-            if (avatar) {
-              StringCopy(joinReq->avatar, avatar);
-            }
-            else {
-              joinReq->avatar[0] = 0;
-            }
-            JoinAskQueue.CommitAdd();
-          }
-        }
-      }
-    }
-
-    // writes
-    if (UpdatePresence.exchange(false) && QueuedPresence.length) {
-      QueuedMessage local;
-      {
-        std::lock_guard<std::mutex> guard(PresenceMutex);
-        local.Copy(QueuedPresence);
-      }
-      if (!Connection->Write(local.buffer, local.length)) {
-        // if we fail to send, requeue
-        std::lock_guard<std::mutex> guard(PresenceMutex);
-        QueuedPresence.Copy(local);
-        UpdatePresence.exchange(true);
-      }
-    }
-
-    while (SendQueue.HavePendingSends()) {
-      auto qmessage = SendQueue.GetNextSendMessage();
-      Connection->Write(qmessage->buffer, qmessage->length);
-      SendQueue.CommitSend();
-    }
-  }
-
-}
-
-extern "C" void Discord_Initialize(const char *applicationId, DiscordEventHandlers *handlers, const int autoRegister) {
 
   IoThread = new (std::nothrow) IoThreadHolder();
   if (IoThread == nullptr) {
@@ -315,37 +315,38 @@ extern "C" void Discord_Initialize(const char *applicationId, DiscordEventHandle
   }
 
   Connection = RpcConnection::Create(applicationId);
-  Connection->onConnect = [](JsonDocument &readyMessage) {
+  Connection->onConnect = [](QJsonDocument &readyMessage) {
     Discord_UpdateHandlers(&QueuedHandlers);
     if (QueuedPresence.length > 0) {
       UpdatePresence.exchange(true);
       SignalIOActivity();
     }
-    auto data = GetObjMember(&readyMessage, "data");
+    const QJsonValue json_object = readyMessage.object();
-    auto user = GetObjMember(data, "user");
+    auto data = json_object["data"_L1].toObject();
-    auto userId = GetStrMember(user, "id");
+    auto user = data["user"_L1].toObject();
-    auto username = GetStrMember(user, "username");
+    auto userId = user["id"_L1].toString();
-    auto avatar = GetStrMember(user, "avatar");
+    auto username = user["username"_L1].toString();
-    if (userId && username) {
+    auto avatar = user["avatar"_L1].toString();
-      StringCopy(connectedUser.userId, userId);
+    if (!userId.isEmpty() && !username.isEmpty()) {
-      StringCopy(connectedUser.username, username);
+      connectedUser.userId = userId;
-      auto discriminator = GetStrMember(user, "discriminator");
+      connectedUser.username = username;
-      if (discriminator) {
+      const QString discriminator = user["discriminator"_L1].toString();
-        StringCopy(connectedUser.discriminator, discriminator);
+      if (!discriminator.isEmpty()) {
+        connectedUser.discriminator = discriminator;
       }
-      if (avatar) {
+      if (!avatar.isEmpty()) {
-        StringCopy(connectedUser.avatar, avatar);
+        connectedUser.avatar = avatar;
       }
       else {
-        connectedUser.avatar[0] = 0;
+        connectedUser = User();
       }
     }
     WasJustConnected.exchange(true);
     ReconnectTimeMs.reset();
   };
-  Connection->onDisconnect = [](int err, const char *message) {
+  Connection->onDisconnect = [](int err, QString &message) {
     LastDisconnectErrorCode = err;
-    StringCopy(LastDisconnectErrorMessage, message);
+    LastDisconnectErrorMessage = message;
     WasJustDisconnected.exchange(true);
     UpdateReconnectTime();
   };
@@ -354,7 +355,7 @@ extern "C" void Discord_Initialize(const char *applicationId, DiscordEventHandle
 
 }
 
-extern "C" void Discord_Shutdown() {
+extern "C" void Discord_Shutdown(void) {
 
   if (!Connection) {
     return;
@@ -374,7 +375,7 @@ extern "C" void Discord_Shutdown() {
 
 }
 
-extern "C" void Discord_UpdatePresence(const DiscordRichPresence *presence) {
+extern "C" void Discord_UpdatePresence(const DiscordRichPresence &presence) {
 
   {
     std::lock_guard<std::mutex> guard(PresenceMutex);
@@ -386,8 +387,8 @@ extern "C" void Discord_UpdatePresence(const DiscordRichPresence *presence) {
 
 }
 
-extern "C" void Discord_ClearPresence(void) {
+extern "C" void Discord_ClearPresence() {
-  Discord_UpdatePresence(nullptr);
+  Discord_UpdatePresence();
 }
 
 extern "C" void Discord_Respond(const char *userId, /* DISCORD_REPLY_ */ int reply) {
@@ -429,7 +430,7 @@ extern "C" void Discord_RunCallbacks() {
   if (WasJustConnected.exchange(false)) {
     std::lock_guard<std::mutex> guard(HandlerMutex);
     if (Handlers.ready) {
-      DiscordUser du{ connectedUser.userId, connectedUser.username, connectedUser.discriminator, connectedUser.avatar };
+      DiscordUser du { connectedUser.userId, connectedUser.username, connectedUser.discriminator, connectedUser.avatar };
       Handlers.ready(&du);
     }
   }
@@ -465,7 +466,7 @@ extern "C" void Discord_RunCallbacks() {
     {
       std::lock_guard<std::mutex> guard(HandlerMutex);
       if (Handlers.joinRequest) {
-        DiscordUser du{ req->userId, req->username, req->discriminator, req->avatar };
+        DiscordUser du { req->userId, req->username, req->discriminator, req->avatar };
         Handlers.joinRequest(&du);
       }
     }
@@ -486,12 +487,12 @@ extern "C" void Discord_UpdateHandlers(DiscordEventHandlers *newHandlers) {
 
   if (newHandlers) {
 #define HANDLE_EVENT_REGISTRATION(handler_name, event)            \
-        if (!Handlers.handler_name && newHandlers->handler_name) {      \
+  if (!Handlers.handler_name && newHandlers->handler_name) {      \
-          RegisterForEvent(event);                                      \
+    RegisterForEvent(event);                                      \
-        }                                                               \
+  }                                                               \
-        else if (Handlers.handler_name && !newHandlers->handler_name) { \
+  else if (Handlers.handler_name && !newHandlers->handler_name) { \
-          DeregisterForEvent(event);                                    \
+    DeregisterForEvent(event);                                    \
-        }
+  }
 
     std::lock_guard<std::mutex> guard(HandlerMutex);
     HANDLE_EVENT_REGISTRATION(joinGame, "ACTIVITY_JOIN")
@@ -508,3 +509,5 @@ extern "C" void Discord_UpdateHandlers(DiscordEventHandlers *newHandlers) {
   }
 
 }
+
+}  // namespace discord_rpc

3rdparty/discord-rpc/discord_rpc.h

@@ -25,46 +25,49 @@
 #define DISCORD_RPC_H
 
 #include <cstdint>
+#include <QString>
+
+namespace discord_rpc {
 
 #ifdef __cplusplus
 extern "C" {
 #endif
 
-typedef struct DiscordRichPresence {
+class DiscordRichPresence {
+ public:
   int type;
-  int status_display_type;
+  QString name;    /* max 128 bytes */
-  const char *name;    /* max 128 bytes */
+  QString state;   /* max 128 bytes */
-  const char *state;   /* max 128 bytes */
+  QString details; /* max 128 bytes */
-  const char *details; /* max 128 bytes */
+  qint64 startTimestamp;
-  int64_t startTimestamp;
+  qint64 endTimestamp;
-  int64_t endTimestamp;
+  QString largeImageKey;  /* max 32 bytes */
-  const char *largeImageKey;  /* max 32 bytes */
+  QString largeImageText; /* max 128 bytes */
-  const char *largeImageText; /* max 128 bytes */
+  QString smallImageKey;  /* max 32 bytes */
-  const char *smallImageKey;  /* max 32 bytes */
+  QString smallImageText; /* max 128 bytes */
-  const char *smallImageText; /* max 128 bytes */
+  QString partyId;        /* max 128 bytes */
-  const char *partyId;        /* max 128 bytes */
   int partySize;
   int partyMax;
   int partyPrivacy;
-  const char *matchSecret;    /* max 128 bytes */
+  QString matchSecret;    /* max 128 bytes */
-  const char *joinSecret;     /* max 128 bytes */
+  QString joinSecret;     /* max 128 bytes */
-  const char *spectateSecret; /* max 128 bytes */
+  QString spectateSecret; /* max 128 bytes */
-  int8_t instance;
+  qint8 instance;
-} DiscordRichPresence;
+};
 
 typedef struct DiscordUser {
-  const char *userId;
+  const QString userId;
-  const char *username;
+  const QString username;
-  const char *discriminator;
+  const QString discriminator;
-  const char *avatar;
+  const QString avatar;
 } DiscordUser;
 
 typedef struct DiscordEventHandlers {
   void (*ready)(const DiscordUser *request);
-  void (*disconnected)(int errorCode, const char *message);
+  void (*disconnected)(int errorCode, const QString &message);
-  void (*errored)(int errorCode, const char *message);
+  void (*errored)(int errorCode, const QString &message);
-  void (*joinGame)(const char *joinSecret);
+  void (*joinGame)(const QString &joinSecret);
-  void (*spectateGame)(const char *spectateSecret);
+  void (*spectateGame)(const QString &spectateSecret);
   void (*joinRequest)(const DiscordUser *request);
 } DiscordEventHandlers;
 
@@ -74,14 +77,14 @@ typedef struct DiscordEventHandlers {
 #define DISCORD_PARTY_PRIVATE 0
 #define DISCORD_PARTY_PUBLIC  1
 
-void Discord_Initialize(const char *applicationId, DiscordEventHandlers *handlers, const int autoRegister);
+void Discord_Initialize(const QString &applicationId, DiscordEventHandlers *handlers, const int autoRegister);
-void Discord_Shutdown(void);
+void Discord_Shutdown();
 
 // checks for incoming messages, dispatches callbacks
-void Discord_RunCallbacks(void);
+void Discord_RunCallbacks();
 
-void Discord_UpdatePresence(const DiscordRichPresence *presence);
+void Discord_UpdatePresence(const DiscordRichPresence &presence = DiscordRichPresence());
-void Discord_ClearPresence(void);
+void Discord_ClearPresence();
 
 void Discord_Respond(const char *userid, /* DISCORD_REPLY_ */ int reply);
 
@@ -91,4 +94,6 @@ void Discord_UpdateHandlers(DiscordEventHandlers *handlers);
 } /* extern "C" */
 #endif
 
+}  // namespace discord_rpc
+
 #endif  // DISCORD_RPC_H

3rdparty/discord-rpc/discord_rpc_connection.cpp

@@ -21,18 +21,24 @@
  *
  */
 
+#include <QString>
+#include <QJsonDocument>
+#include <QJsonObject>
+
 #include "discord_rpc_connection.h"
 #include "discord_serialization.h"
 
+using namespace Qt::Literals::StringLiterals;
+
 namespace discord_rpc {
 
 static const int RpcVersion = 1;
 static RpcConnection Instance;
 
-RpcConnection *RpcConnection::Create(const char *applicationId) {
+RpcConnection *RpcConnection::Create(const QString &applicationId) {
 
   Instance.connection = BaseConnection::Create();
-  StringCopy(Instance.appId, applicationId);
+  Instance.appId = applicationId;
   return &Instance;
 
 }
@@ -56,14 +62,15 @@ void RpcConnection::Open() {
   }
 
   if (state == State::SentHandshake) {
-    JsonDocument message;
+    QJsonDocument json_document;
-    if (Read(message)) {
+    if (Read(json_document)) {
-      auto cmd = GetStrMember(&message, "cmd");
+      const QJsonObject json_object = json_document.object();
-      auto evt = GetStrMember(&message, "evt");
+      const QString cmd = json_object["cmd"_L1].toString();
-      if (cmd && evt && !strcmp(cmd, "DISPATCH") && !strcmp(evt, "READY")) {
+      const QString evt = json_object["evt"_L1].toString();
+      if (cmd == "DISPATCH"_L1 && evt == "READY"_L1) {
         state = State::Connected;
         if (onConnect) {
-          onConnect(message);
+          onConnect(json_document);
         }
       }
     }
@@ -106,7 +113,7 @@ bool RpcConnection::Write(const void *data, size_t length) {
 
 }
 
-bool RpcConnection::Read(JsonDocument &message) {
+bool RpcConnection::Read(QJsonDocument &message) {
 
   if (state != State::Connected && state != State::SentHandshake) {
     return false;
@@ -117,7 +124,7 @@ bool RpcConnection::Read(JsonDocument &message) {
     if (!didRead) {
       if (!connection->isOpen) {
         lastErrorCode = static_cast<int>(ErrorCode::PipeClosed);
-        StringCopy(lastErrorMessage, "Pipe closed");
+        lastErrorMessage = "Pipe closed"_L1;
         Close();
       }
       return false;
@@ -127,7 +134,7 @@ bool RpcConnection::Read(JsonDocument &message) {
       didRead = connection->Read(readFrame.message, readFrame.length);
       if (!didRead) {
         lastErrorCode = static_cast<int>(ErrorCode::ReadCorrupt);
-        StringCopy(lastErrorMessage, "Partial data in frame");
+        lastErrorMessage = "Partial data in frame"_L1;
         Close();
         return false;
       }
@@ -136,14 +143,14 @@ bool RpcConnection::Read(JsonDocument &message) {
 
     switch (readFrame.opcode) {
       case Opcode::Close: {
-        message.ParseInsitu(readFrame.message);
+        message = QJsonDocument::fromJson(readFrame.message);
-        lastErrorCode = GetIntMember(&message, "code");
+        lastErrorCode = message["code"_L1].toInt();
-        StringCopy(lastErrorMessage, GetStrMember(&message, "message", ""));
+        lastErrorMessage = message["message"_L1].toString();
         Close();
         return false;
       }
       case Opcode::Frame:
-        message.ParseInsitu(readFrame.message);
+        message = QJsonDocument::fromJson(readFrame.message);
         return true;
       case Opcode::Ping:
         readFrame.opcode = Opcode::Pong;
@@ -157,7 +164,7 @@ bool RpcConnection::Read(JsonDocument &message) {
       default:
         // something bad happened
         lastErrorCode = static_cast<int>(ErrorCode::ReadCorrupt);
-        StringCopy(lastErrorMessage, "Bad ipc frame");
+        lastErrorMessage = "Bad ipc frame"_L1;
         Close();
         return false;
     }

3rdparty/discord-rpc/discord_rpc_connection.h

@@ -24,6 +24,9 @@
 #ifndef DISCORD_RPC_CONNECTION_H
 #define DISCORD_RPC_CONNECTION_H
 
+#include <QString>
+#include <QJsonDocument>
+
 #include "discord_connection.h"
 #include "discord_serialization.h"
 
@@ -63,24 +66,24 @@ struct RpcConnection {
     Connected,
   };
 
-  BaseConnection *connection{ nullptr };
+  BaseConnection *connection { nullptr };
-  State state{ State::Disconnected };
+  State state { State::Disconnected };
-  void (*onConnect)(JsonDocument &message) { nullptr };
+  void (*onConnect)(QJsonDocument &message) { nullptr };
-  void (*onDisconnect)(int errorCode, const char *message) { nullptr };
+  void (*onDisconnect)(int errorCode, QString &message) { nullptr };
-  char appId[64]{};
+  QString appId;
-  int lastErrorCode{ 0 };
+  int lastErrorCode { 0 };
-  char lastErrorMessage[256]{};
+  QString lastErrorMessage;
   RpcConnection::MessageFrame sendFrame;
 
-  static RpcConnection *Create(const char *applicationId);
+  static RpcConnection *Create(const QString &applicationId);
-  static void Destroy(RpcConnection*&);
+  static void Destroy(RpcConnection *&);
 
   inline bool IsOpen() const { return state == State::Connected; }
 
   void Open();
   void Close();
   bool Write(const void *data, size_t length);
-  bool Read(JsonDocument &message);
+  bool Read(QJsonDocument &message);
 };
 
 }  // namespace discord_rpc

3rdparty/discord-rpc/discord_serialization.cpp

@@ -21,10 +21,15 @@
  *
  */
 
+#include <QString>
+#include <QJsonDocument>
+#include <QJsonObject>
+
 #include "discord_serialization.h"
-#include "discord_connection.h"
 #include "discord_rpc.h"
 
+using namespace Qt::Literals::StringLiterals;
+
 namespace discord_rpc {
 
 template<typename T>
@@ -53,232 +58,129 @@ void NumberToString(char *dest, T number) {
 
 }
 
-// it's ever so slightly faster to not have to strlen the key
+void WriteOptionalString(QJsonObject &json_object, const QString &key, const QString &value);
-template<typename T>
+void WriteOptionalString(QJsonObject &json_object, const QString &key, const QString &value) {
-void WriteKey(JsonWriter &w, T &k) {
-  w.Key(k, sizeof(T) - 1);
-}
 
-struct WriteObject {
+  if (!value.isEmpty()) {
-  JsonWriter &writer;
+    json_object[key] = value;
-  WriteObject(JsonWriter &w)
-      : writer(w) {
-    writer.StartObject();
-  }
-  template<typename T>
-  WriteObject(JsonWriter &w, T &name)
-      : writer(w) {
-    WriteKey(writer, name);
-    writer.StartObject();
-  }
-  ~WriteObject() { writer.EndObject(); }
-};
-
-struct WriteArray {
-  JsonWriter &writer;
-  template<typename T>
-  WriteArray(JsonWriter &w, T &name)
-      : writer(w) {
-    WriteKey(writer, name);
-    writer.StartArray();
-  }
-  ~WriteArray() { writer.EndArray(); }
-};
-
-template<typename T>
-void WriteOptionalString(JsonWriter &w, T &k, const char *value) {
-
-  if (value && value[0]) {
-    w.Key(k, sizeof(T) - 1);
-    w.String(value);
   }
 
 }
 
-static void JsonWriteNonce(JsonWriter &writer, const int nonce) {
+static QString JsonWriteNonce(const int nonce) {
 
-  WriteKey(writer, "nonce");
+  char nonce_buffer[32]{};
-  char nonceBuffer[32];
+  NumberToString(nonce_buffer, nonce);
-  NumberToString(nonceBuffer, nonce);
+
-  writer.String(nonceBuffer);
+  return QString::fromLatin1(nonce_buffer);
 
 }
 
-size_t JsonWriteRichPresenceObj(char *dest, const size_t maxLen, const int nonce, const int pid, const DiscordRichPresence *presence) {
+size_t JsonWriteRichPresenceObj(char *dest, const size_t maxLen, const int nonce, const int pid, const DiscordRichPresence &presence) {
 
-  JsonWriter writer(dest, maxLen);
+  QJsonObject json_object;
 
-  {
+  json_object["nonce"_L1] = JsonWriteNonce(nonce);
-    WriteObject top(writer);
+  json_object["cmd"_L1] = "SET_ACTIVITY"_L1;
 
-    JsonWriteNonce(writer, nonce);
+  QJsonObject args;
+  args["pid"_L1] = pid;
 
-    WriteKey(writer, "cmd");
+  QJsonObject activity;
-    writer.String("SET_ACTIVITY");
 
-    {
+  if (presence.type >= 0 && presence.type <= 5) {
-      WriteObject args(writer, "args");
+    activity["type"_L1] = presence.type;
+  }
 
-      WriteKey(writer, "pid");
+  activity["state"_L1] = presence.state;
-      writer.Int(pid);
+  activity["details"_L1] = presence.details;
 
-      if (presence != nullptr) {
+  if (presence.startTimestamp != 0 || presence.endTimestamp != 0) {
-        WriteObject activity(writer, "activity");
+    QJsonObject timestamps;
-
+    if (presence.startTimestamp != 0) {
-        if (presence->type >= 0 && presence->type <= 5) {
+      timestamps["start"_L1] = presence.startTimestamp;
-          WriteKey(writer, "type");
-          writer.Int(presence->type);
-
-          WriteKey(writer, "status_display_type");
-          writer.Int(presence->status_display_type);
-        }
-
-        WriteOptionalString(writer, "name", presence->name);
-        WriteOptionalString(writer, "state", presence->state);
-        WriteOptionalString(writer, "details", presence->details);
-
-        if (presence->startTimestamp || presence->endTimestamp) {
-          WriteObject timestamps(writer, "timestamps");
-
-          if (presence->startTimestamp) {
-            WriteKey(writer, "start");
-            writer.Int64(presence->startTimestamp);
-          }
-
-          if (presence->endTimestamp) {
-            WriteKey(writer, "end");
-            writer.Int64(presence->endTimestamp);
-          }
-        }
-
-        if ((presence->largeImageKey && presence->largeImageKey[0]) ||
-            (presence->largeImageText && presence->largeImageText[0]) ||
-            (presence->smallImageKey && presence->smallImageKey[0]) ||
-            (presence->smallImageText && presence->smallImageText[0])) {
-          WriteObject assets(writer, "assets");
-          WriteOptionalString(writer, "large_image", presence->largeImageKey);
-          WriteOptionalString(writer, "large_text", presence->largeImageText);
-          WriteOptionalString(writer, "small_image", presence->smallImageKey);
-          WriteOptionalString(writer, "small_text", presence->smallImageText);
-        }
-
-        if ((presence->partyId && presence->partyId[0]) || presence->partySize ||
-            presence->partyMax || presence->partyPrivacy) {
-          WriteObject party(writer, "party");
-          WriteOptionalString(writer, "id", presence->partyId);
-          if (presence->partySize && presence->partyMax) {
-            WriteArray size(writer, "size");
-            writer.Int(presence->partySize);
-            writer.Int(presence->partyMax);
-          }
-
-          if (presence->partyPrivacy) {
-            WriteKey(writer, "privacy");
-            writer.Int(presence->partyPrivacy);
-          }
-        }
-
-        if ((presence->matchSecret && presence->matchSecret[0]) ||
-            (presence->joinSecret && presence->joinSecret[0]) ||
-            (presence->spectateSecret && presence->spectateSecret[0])) {
-          WriteObject secrets(writer, "secrets");
-          WriteOptionalString(writer, "match", presence->matchSecret);
-          WriteOptionalString(writer, "join", presence->joinSecret);
-          WriteOptionalString(writer, "spectate", presence->spectateSecret);
-        }
-
-        writer.Key("instance");
-        writer.Bool(presence->instance != 0);
-      }
     }
+    if (presence.endTimestamp != 0) {
+      timestamps["end"_L1] = presence.endTimestamp;
+    }
+    activity["timestamps"_L1] = timestamps;
   }
 
-  return writer.Size();
+  if (!presence.largeImageKey.isEmpty() || !presence.largeImageText.isEmpty() || !presence.smallImageKey.isEmpty() || !presence.smallImageText.isEmpty()) {
-}
+    QJsonObject assets;
-
+    WriteOptionalString(assets, "large_image"_L1, presence.largeImageKey);
-size_t JsonWriteHandshakeObj(char *dest, size_t maxLen, int version, const char *applicationId) {
+    WriteOptionalString(assets, "large_text"_L1, presence.largeImageText);
-
+    WriteOptionalString(assets, "small_image"_L1, presence.smallImageKey);
-  JsonWriter writer(dest, maxLen);
+    WriteOptionalString(assets, "small_text"_L1, presence.smallImageText);
-
+    activity["assets"_L1] = assets;
-  {
-    WriteObject obj(writer);
-    WriteKey(writer, "v");
-    writer.Int(version);
-    WriteKey(writer, "client_id");
-    writer.String(applicationId);
   }
 
-  return writer.Size();
+  activity["instance"_L1] = presence.instance != 0;
+  args["activity"_L1] = activity;
+  json_object["args"_L1] = args;
+
+  QJsonDocument json_document(json_object);
+  QByteArray data = json_document.toJson(QJsonDocument::Compact);
+  strncpy(dest, data.constData(), maxLen);
+
+  return data.length();
 
 }
 
-size_t JsonWriteSubscribeCommand(char *dest, size_t maxLen, int nonce, const char *evtName) {
+size_t JsonWriteHandshakeObj(char *dest, const size_t maxLen, const int version, const QString &applicationId) {
 
-  JsonWriter writer(dest, maxLen);
+  QJsonObject json_object;
+  json_object["v"_L1] = version;
+  json_object["client_id"_L1] = applicationId;
+  const QJsonDocument json_document(json_object);
+  const QByteArray data = json_document.toJson(QJsonDocument::Compact);
+  strncpy(dest, data.constData(), maxLen);
 
-  {
+  return data.length();
-    WriteObject obj(writer);
-
-    JsonWriteNonce(writer, nonce);
-
-    WriteKey(writer, "cmd");
-    writer.String("SUBSCRIBE");
-
-    WriteKey(writer, "evt");
-    writer.String(evtName);
-  }
-
-  return writer.Size();
 
 }
 
-size_t JsonWriteUnsubscribeCommand(char *dest, size_t maxLen, int nonce, const char *evtName) {
+size_t JsonWriteSubscribeCommand(char *dest, const size_t maxLen, const int nonce, const char *evtName) {
 
-  JsonWriter writer(dest, maxLen);
+  QJsonObject json_object;
+  json_object["nonce"_L1] = JsonWriteNonce(nonce);
+  json_object["cmd"_L1] = "SUBSCRIBE"_L1;
+  json_object["evt"_L1] = QLatin1String(evtName);
+  const QJsonDocument json_document(json_object);
+  const QByteArray data = json_document.toJson(QJsonDocument::Compact);
+  strncpy(dest, data.constData(), maxLen);
 
-  {
+  return data.length();
-    WriteObject obj(writer);
 
-    JsonWriteNonce(writer, nonce);
+}
 
-    WriteKey(writer, "cmd");
+size_t JsonWriteUnsubscribeCommand(char *dest, const size_t maxLen, const int nonce, const char *evtName) {
-    writer.String("UNSUBSCRIBE");
 
-    WriteKey(writer, "evt");
+  QJsonObject json_object;
-    writer.String(evtName);
+  json_object["nonce"_L1] = JsonWriteNonce(nonce);
-  }
+  json_object["cmd"_L1] = "UNSUBSCRIBE"_L1;
+  json_object["evt"_L1] = QLatin1String(evtName);
+  const QJsonDocument json_document(json_object);
+  const QByteArray data = json_document.toJson(QJsonDocument::Compact);
+  strncpy(dest, data.constData(), maxLen);
 
-  return writer.Size();
+  return data.length();
 
 }
 
 size_t JsonWriteJoinReply(char *dest, size_t maxLen, const char *userId, const int reply, const int nonce) {
 
-  JsonWriter writer(dest, maxLen);
+  QJsonObject json_object;
+  json_object["nonce"_L1] = JsonWriteNonce(nonce);
+  json_object["cmd"_L1] = reply == DISCORD_REPLY_YES ? "SEND_ACTIVITY_JOIN_INVITE"_L1 : "CLOSE_ACTIVITY_JOIN_REQUEST"_L1;
+  QJsonObject args;
+  args["user_id"_L1] = QLatin1String(userId);
+  json_object["args"_L1] = args;
+  const QJsonDocument json_document(json_object);
+  const QByteArray data = json_document.toJson(QJsonDocument::Compact);
+  strncpy(dest, data.constData(), maxLen);
 
-  {
+  return data.length();
-    WriteObject obj(writer);
-
-    WriteKey(writer, "cmd");
-    if (reply == DISCORD_REPLY_YES) {
-      writer.String("SEND_ACTIVITY_JOIN_INVITE");
-    }
-    else {
-      writer.String("CLOSE_ACTIVITY_JOIN_REQUEST");
-    }
-
-    WriteKey(writer, "args");
-    {
-      WriteObject args(writer);
-
-      WriteKey(writer, "user_id");
-      writer.String(userId);
-    }
-
-    JsonWriteNonce(writer, nonce);
-  }
-
-  return writer.Size();
 
 }
 

3rdparty/discord-rpc/discord_serialization.h

@@ -24,190 +24,18 @@
 #ifndef DISCORD_SERIALIZATION_H
 #define DISCORD_SERIALIZATION_H
 
-#include <rapidjson/document.h>
+#include <cstddef>
-#include <rapidjson/stringbuffer.h>
+#include <QString>
-#include <rapidjson/writer.h>
-
-struct DiscordRichPresence;
 
 namespace discord_rpc {
 
-// if only there was a standard library function for this
+size_t JsonWriteHandshakeObj(char *dest, size_t maxLen, int version, const QString &applicationId);
-template<size_t Len>
+class DiscordRichPresence;
-inline size_t StringCopy(char (&dest)[Len], const char *src) {
+size_t JsonWriteRichPresenceObj(char *dest, const size_t maxLen, const int nonce, const int pid, const DiscordRichPresence &presence);
-  if (!src || !Len) {
-    return 0;
-  }
-  size_t copied;
-  char *out = dest;
-  for (copied = 1; *src && copied < Len; ++copied) {
-    *out++ = *src++;
-  }
-  *out = 0;
-  return copied - 1;
-}
-
-size_t JsonWriteHandshakeObj(char *dest, size_t maxLen, int version, const char *applicationId);
-
-// Commands
-size_t JsonWriteRichPresenceObj(char *dest, const size_t maxLen, const int nonce, const int pid, const DiscordRichPresence *presence);
 size_t JsonWriteSubscribeCommand(char *dest, size_t maxLen, int nonce, const char *evtName);
-
 size_t JsonWriteUnsubscribeCommand(char *dest, size_t maxLen, int nonce, const char *evtName);
-
 size_t JsonWriteJoinReply(char *dest, size_t maxLen, const char *userId, int reply, int nonce);
 
-// I want to use as few allocations as I can get away with, and to do that with RapidJson, you need
-// to supply some of your own allocators for stuff rather than use the defaults
-
-class LinearAllocator {
- public:
-  char *buffer_;
-  char *end_;
-  LinearAllocator() {
-    assert(0);  // needed for some default case in rapidjson, should not use
-  }
-  LinearAllocator(char *buffer, size_t size)
-      : buffer_(buffer), end_(buffer + size) {
-  }
-  static const bool kNeedFree = false;
-  void *Malloc(size_t size) {
-    char *res = buffer_;
-    buffer_ += size;
-    if (buffer_ > end_) {
-      buffer_ = res;
-      return nullptr;
-    }
-    return res;
-  }
-  void *Realloc(void *originalPtr, size_t originalSize, size_t newSize) {
-    if (newSize == 0) {
-      return nullptr;
-    }
-    // allocate how much you need in the first place
-    assert(!originalPtr && !originalSize);
-    // unused parameter warning
-    (void)(originalPtr);
-    (void)(originalSize);
-    return Malloc(newSize);
-  }
-  static void Free(void *ptr) {
-    /* shrug */
-    (void)ptr;
-  }
-};
-
-template<size_t Size>
-class FixedLinearAllocator : public LinearAllocator {
- public:
-  char fixedBuffer_[Size];
-  FixedLinearAllocator()
-      : LinearAllocator(fixedBuffer_, Size) {
-  }
-  static const bool kNeedFree = false;
-};
-
-// wonder why this isn't a thing already, maybe I missed it
-class DirectStringBuffer {
- public:
-  using Ch = char;
-  char *buffer_;
-  char *end_;
-  char *current_;
-
-  DirectStringBuffer(char *buffer, size_t maxLen)
-      : buffer_(buffer), end_(buffer + maxLen), current_(buffer) {
-  }
-
-  void Put(char c) {
-    if (current_ < end_) {
-      *current_++ = c;
-    }
-  }
-  void Flush() {}
-  size_t GetSize() const { return static_cast<size_t>(current_ - buffer_); }
-};
-
-using MallocAllocator = rapidjson::CrtAllocator;
-using PoolAllocator = rapidjson::MemoryPoolAllocator<MallocAllocator>;
-using UTF8 = rapidjson::UTF8<char>;
-// Writer appears to need about 16 bytes per nested object level (with 64bit size_t)
-using StackAllocator = FixedLinearAllocator<2048>;
-constexpr size_t WriterNestingLevels = 2048 / (2 * sizeof(size_t));
-using JsonWriterBase =
-  rapidjson::Writer<DirectStringBuffer, UTF8, UTF8, StackAllocator, rapidjson::kWriteNoFlags>;
-class JsonWriter : public JsonWriterBase {
- public:
-  DirectStringBuffer stringBuffer_;
-  StackAllocator stackAlloc_;
-
-  JsonWriter(char *dest, size_t maxLen)
-      : JsonWriterBase(stringBuffer_, &stackAlloc_, WriterNestingLevels), stringBuffer_(dest, maxLen), stackAlloc_() {
-  }
-
-  size_t Size() const { return stringBuffer_.GetSize(); }
-};
-
-using JsonDocumentBase = rapidjson::GenericDocument<UTF8, PoolAllocator, StackAllocator>;
-class JsonDocument : public JsonDocumentBase {
- public:
-  static const int kDefaultChunkCapacity = 32 * 1024;
-  // json parser will use this buffer first, then allocate more if needed; I seriously doubt we
-  // send any messages that would use all of this, though.
-  char parseBuffer_[32 * 1024];
-  MallocAllocator mallocAllocator_;
-  PoolAllocator poolAllocator_;
-  StackAllocator stackAllocator_;
-  JsonDocument()
-      : JsonDocumentBase(rapidjson::kObjectType,
-                         &poolAllocator_,
-                         sizeof(stackAllocator_.fixedBuffer_),
-                         &stackAllocator_),
-        poolAllocator_(parseBuffer_, sizeof(parseBuffer_), kDefaultChunkCapacity, &mallocAllocator_), stackAllocator_() {
-  }
-};
-
-using JsonValue = rapidjson::GenericValue<UTF8, PoolAllocator>;
-
-inline JsonValue *GetObjMember(JsonValue *obj, const char *name) {
-
-  if (obj) {
-    auto member = obj->FindMember(name);
-    if (member != obj->MemberEnd() && member->value.IsObject()) {
-      return &member->value;
-    }
-  }
-
-  return nullptr;
-
-}
-
-inline int GetIntMember(JsonValue *obj, const char *name, int notFoundDefault = 0) {
-
-  if (obj) {
-    auto member = obj->FindMember(name);
-    if (member != obj->MemberEnd() && member->value.IsInt()) {
-      return member->value.GetInt();
-    }
-  }
-
-  return notFoundDefault;
-
-}
-
-inline const char *GetStrMember(JsonValue *obj, const char *name, const char *notFoundDefault = nullptr) {
-
-  if (obj) {
-    auto member = obj->FindMember(name);
-    if (member != obj->MemberEnd() && member->value.IsString()) {
-      return member->value.GetString();
-    }
-  }
-
-  return notFoundDefault;
-
-}
-
 }  // namespace discord_rpc
 
 #endif  // DISCORD_SERIALIZATION_H

CMakeLists.txt

@@ -212,8 +212,6 @@ find_package(GTest)
 
 pkg_check_modules(LIBSPARSEHASH IMPORTED_TARGET libsparsehash)
 
-find_package(RapidJSON)
-
 set(QT_VERSION_MAJOR 6)
 set(QT_MIN_VERSION 6.4.0)
 set(QT_DEFAULT_MAJOR_VERSION ${QT_VERSION_MAJOR})
@@ -259,18 +257,7 @@ if(APPLE)
 endif()
 
 if(WIN32)
-  find_package(getopt NAMES getopt getopt-win unofficial-getopt-win32 REQUIRED)
+  find_package(getopt-win REQUIRED)
-  if(TARGET getopt::getopt)
-    set(GETOPT_LIBRARIES getopt::getopt)
-  elseif(TARGET getopt-win::getopt)
-    set(GETOPT_LIBRARIES getopt-win::getopt)
-  elseif(TARGET getopt::getopt_shared)
-    set(GETOPT_LIBRARIES getopt::getopt_shared)
-  elseif(TARGET unofficial::getopt-win32::getopt)
-    set(GETOPT_LIBRARIES unofficial::getopt-win32::getopt)
-  else()
-    message(FATAL_ERROR "Missing getopt")
-  endif()
 endif()
 
 if(APPLE OR WIN32)
@@ -377,16 +364,7 @@ optional_component(STREAMTAGREADER ON "Stream tagreader"
   DEPENDS "sparsehash" LIBSPARSEHASH_FOUND
 )
 
-optional_component(DISCORD_RPC ON "Discord Rich Presence"
+optional_component(DISCORD_RPC ON "Discord Rich Presence")
-  DEPENDS "RapidJSON" RapidJSON_FOUND
-
-optional_component(DROPBOX ON "Streaming: Dropbox"
-  DEPENDS "Stream tagreader" HAVE_STREAMTAGREADER
-)
-
-optional_component(ONEDRIVE ON "Streaming: OneDrive"
-  DEPENDS "Stream tagreader" HAVE_STREAMTAGREADER
-)
 
 if(HAVE_SONGFINGERPRINTING OR HAVE_MUSICBRAINZ)
   set(HAVE_CHROMAPRINT ON)
@@ -708,7 +686,6 @@ set(SOURCES
   src/lyrics/elyricsnetlyricsprovider.cpp
   src/lyrics/letraslyricsprovider.cpp
   src/lyrics/lyricfindlyricsprovider.cpp
-  src/lyrics/lrcliblyricsprovider.cpp
 
   src/settings/settingsdialog.cpp
   src/settings/settingspage.cpp
@@ -783,7 +760,6 @@ set(SOURCES
   src/streaming/streamingcollectionviewcontainer.cpp
   src/streaming/streamingsearchview.cpp
   src/streaming/streamsongmimedata.cpp
-  src/streaming/cloudstoragestreamingservice.cpp
 
   src/radios/radioservices.cpp
   src/radios/radiobackend.cpp
@@ -803,7 +779,9 @@ set(SOURCES
   src/scrobbler/scrobblercache.cpp
   src/scrobbler/scrobblercacheitem.cpp
   src/scrobbler/scrobblemetadata.cpp
+  src/scrobbler/scrobblingapi20.cpp
   src/scrobbler/lastfmscrobbler.cpp
+  src/scrobbler/librefmscrobbler.cpp
   src/scrobbler/listenbrainzscrobbler.cpp
   src/scrobbler/lastfmimport.cpp
 
@@ -1006,7 +984,6 @@ set(HEADERS
   src/lyrics/elyricsnetlyricsprovider.h
   src/lyrics/letraslyricsprovider.h
   src/lyrics/lyricfindlyricsprovider.h
-  src/lyrics/lrcliblyricsprovider.h
 
   src/settings/settingsdialog.h
   src/settings/settingspage.h
@@ -1080,7 +1057,6 @@ set(HEADERS
   src/streaming/streamingtabsview.h
   src/streaming/streamingcollectionview.h
   src/streaming/streamingcollectionviewcontainer.h
-  src/streaming/cloudstoragestreamingservice.h
 
   src/radios/radioservices.h
   src/radios/radiobackend.h
@@ -1096,7 +1072,9 @@ set(HEADERS
   src/scrobbler/scrobblersettingsservice.h
   src/scrobbler/scrobblerservice.h
   src/scrobbler/scrobblercache.h
+  src/scrobbler/scrobblingapi20.h
   src/scrobbler/lastfmscrobbler.h
+  src/scrobbler/librefmscrobbler.h
   src/scrobbler/listenbrainzscrobbler.h
   src/scrobbler/lastfmimport.h
 
@@ -1472,7 +1450,6 @@ optional_source(HAVE_QOBUZ
     src/qobuz/qobuzrequest.cpp
     src/qobuz/qobuzstreamurlrequest.cpp
     src/qobuz/qobuzfavoriterequest.cpp
-    src/qobuz/qobuzcredentialfetcher.cpp
     src/settings/qobuzsettingspage.cpp
     src/covermanager/qobuzcoverprovider.cpp
   HEADERS
@@ -1482,32 +1459,12 @@ optional_source(HAVE_QOBUZ
     src/qobuz/qobuzrequest.h
     src/qobuz/qobuzstreamurlrequest.h
     src/qobuz/qobuzfavoriterequest.h
-    src/qobuz/qobuzcredentialfetcher.h
     src/settings/qobuzsettingspage.h
     src/covermanager/qobuzcoverprovider.h
   UI
     src/settings/qobuzsettingspage.ui
 )
 
-optional_source(HAVE_DROPBOX
-  SOURCES
-    src/dropbox/dropboxservice.cpp
-    src/dropbox/dropboxurlhandler.cpp
-    src/dropbox/dropboxbaserequest.cpp
-    src/dropbox/dropboxsongsrequest.cpp
-    src/dropbox/dropboxstreamurlrequest.cpp
-    src/settings/dropboxsettingspage.cpp
-  HEADERS
-    src/dropbox/dropboxservice.h
-    src/dropbox/dropboxurlhandler.h
-    src/dropbox/dropboxbaserequest.h
-    src/dropbox/dropboxsongsrequest.h
-    src/dropbox/dropboxstreamurlrequest.h
-    src/settings/dropboxsettingspage.h
-  UI
-    src/settings/dropboxsettingspage.ui
-)
-
 qt_wrap_cpp(SOURCES ${HEADERS})
 qt_wrap_ui(SOURCES ${UI})
 qt_add_resources(SOURCES data/data.qrc data/icons.qrc)
@@ -1593,10 +1550,9 @@ target_link_libraries(strawberry_lib PUBLIC
   $<$<BOOL:${HAVE_MTP}>:PkgConfig::LIBMTP>
   $<$<BOOL:${HAVE_GPOD}>:PkgConfig::LIBGPOD PkgConfig::GDK_PIXBUF>
   $<$<BOOL:${HAVE_QTSPARKLE}>:qtsparkle-qt${QT_VERSION_MAJOR}::qtsparkle>
-  $<$<BOOL:${WIN32}>:dsound dwmapi ${GETOPT_LIBRARIES}>
+  $<$<BOOL:${WIN32}>:dsound dwmapi getopt-win::getopt>
   $<$<BOOL:${MSVC}>:WindowsApp>
   KDAB::kdsingleapplication
-  $<$<BOOL:${HAVE_DISCORD_RPC}>:discord-rpc>
 )
 
 if(APPLE)
@@ -1615,6 +1571,10 @@ if(APPLE)
   endif()
 endif()
 
+if(HAVE_DISCORD_RPC)
+  target_link_libraries(strawberry_lib PRIVATE discord-rpc)
+endif()
+
 target_link_libraries(strawberry PUBLIC strawberry_lib)
 
 if(NOT APPLE)

Changelog

@@ -2,111 +2,6 @@ Strawberry Music Player
 =======================
 ChangeLog
 
-Version 1.2.16 (2025.12.16):
-
-    * Make Discord Rich presence use filename if song title is missing
-    * Added better error message when a GStreamer plugin is missing
-    * Preserve track order in album shuffle mode when restarting playback (#1623)
-    * Possible fixes for context word wrap
-    * Added lyrics from lrclib.net
-    * Added option to turn off the use of sort tags for the collection
-    * Fixed Spotify login
-    * Fixed error dialog shown minimized if another Strawberry window than the mainwindow was active
-    * Fixed seeking to the end of the track and back causing seeking to stop working (#1675)
-    * Set current index when automatically selecting track (#1825)
-    * Make icon size for shuffle and repeat buttons adjust to screen resolution (#1838)
-    * Fixed song being removed from playlist when dragging to another application (#1815)
-    * Don't automatically scroll on dynamic playlists (#1427)
-
-Version 1.2.15 (2025.11.25):
-
-    * Fixed system default language not respected
-    * Fixed length filter search
-    * Fixed playlist parser converting Spotify URL's
-    * Removed use of deprecated QStyle::State_Editing
-    * Ignore connection closed errors for ListenBrainz
-    * (Windows) Support building with vcpkg unofficial::getopt-win32::getopt
-
-Version 1.2.14 (2025.10.25):
-
-  Bugfixes:
-    * Fixed showing error dialog minimized when main window is not current active window (#1739)
-    * Fixed Discord timestamp update when seeking (#1813)
-    * Fixed CD metadata lookup to respect MusicBrainz rate limiting
-    * Fixed Tidal Open API cover provider
-    * (Windows) Fixed device selection with WASAPI2
-
-  Enhancements/Other:
-    * Removed libre.fm support
-    * Rewrote MusicBrainzClient to use Json instead of XML
-    * Subsonic will now use cover art from album when available
-    * Added option to remove "Remastered", etc from song titles for Tidal, Qobuz and Spotify
-    * Added webm to supported file extensions
-    * (Windows|MinGW) Added WASAPI2 support
-    * (Windows) Added experimental exclusive mode for WASAPI2
-
-Version 1.2.13 (2025.08.31):
-
-  Bugfixes:
-    * Fixed playlist alternating row colors no longer working with some styles (#1806)
-    * Fixed "Open Audio CD" no longer working (#1803)
-    * Fixed systemtray icon playback status not working with scaling (#1782)
-    * Fixed build without MusicBrainz (#1799)
-    * Fixed build without MTP (#1804)
-
-  Enhancements:
-    * Added Discord status text option (#1796)
-    * Read Vorbis/FLAC "Other" embedded covers if front cover is not available (#1793)
-
-Version 1.2.12 (2025.08.12):
-
-  Bugfixes:
-    * Fixed scrobbling for radio streams.
-    * Fixed CDDA memory leaks.
-    * Fixed device view CDDA loading (#1676).
-    * Fixed collection directory editing (#1767).
-    * Fixed devices sometimes being duplicated in the database.
-    * Fixed alternating playlist row colors with Windows 11 style.
-    * Fixed broken file filter for GME formats.
-    * Fixed collection scanning for GME formats.
-    * Fixed Chartlyrics.
-    * Fixed network cache file descriptor leak on lyrics search with workaround for QTBUG-135641.
-    * Fixed parsing Tidal urls with certain stream URL replies.
-    * Fixed pixelated window icon on Wayland (#1753).
-    * Fixed saving collection grouping with special characters in the name (#1758).
-    * Fixed Spotify token not automatically updated on renewal when playing (#1769).
-    * (macOS/Windows) Fixed network cache file descriptor leak with patch for QTBUG-135641.
-    * (Windows|MSVC) Fixed installer to not restart the computer after installing Visual C++ Redistributable.
-
-  Enhancements:
-    * Implemented edit tag dialog reset for year, track, disc and rating.
-    * Added ALAC to supported filetypes for iPods.
-    * Added CD-TEXT support.
-    * Added back Genius lyrics.
-    * Added support for reporting more info to ListenBrainz.
-    * Added support for BPM, mood and initial key tags.
-    * Added support for sort tags to collection, playlists and smart playlists.
-
-Version 1.2.11 (2025.05.15):
-
-    * Fixed playlist songs sometimes not updated with new cover.
-    * Fixed context album cover showing even when it's disabled in the setting (#1744).
-    * Fixed crash when dragging songs to a closed playlist (#1741).
-    * Enable startup notify in desktop file.
-    * (Windows|MSVC) Add experimental support for native ARM64 builds.
-    * (Windows|MinGW) Fixed crash on exit.
-
-Version 1.2.10 (2025.04.18):
-
-  Bugfixes:
-    * Fixed Discord rich presence showing bogus artist and album.
-    * Fixed incorrect ID3v2 comment tag.
-    * (macOS|Windows MSVC) Fixed stuck playback of some streams.
-
-  Enhancements:
-    * Removed Genius lyrics (longer working properly because of website changes).
-    * (macOS|Windows MSVC) Added back Spotify
-
 Version 1.2.9 (2025.04.08):
 
   Bugfixes:

README.md

@@ -1,137 +1,117 @@
-# :strawberry: Strawberry Music Player [![Build Status](https://github.com/strawberrymusicplayer/strawberry/workflows/Build/badge.svg)](https://github.com/strawberrymusicplayer/strawberry/actions)
+:strawberry: Strawberry Music Player [![Build Status](https://github.com/strawberrymusicplayer/strawberry/workflows/Build/badge.svg)](https://github.com/strawberrymusicplayer/strawberry/actions)
+=======================
 [![Sponsor](https://img.shields.io/badge/-Sponsor-green?logo=github)](https://github.com/sponsors/jonaski)
 [![Patreon](https://img.shields.io/badge/patreon-donate-green.svg)](https://patreon.com/jonaskvinge)
 [![PayPal](https://img.shields.io/badge/Donate-PayPal-green.svg)](https://paypal.me/jonaskvinge)
 
-Strawberry is a **music player and music collection organizer**, originally forked from *Clementine* in 2018.
+Strawberry is a music player and music collection organizer. It is a fork of Clementine released in 2018 aimed at music collectors and audiophiles. It's written in C++ using the Qt framework.
-It’s written in **C++ using the Qt framework**, designed for **audiophiles and music collectors**.
 
-![Screenshot of Strawberry Music Player](https://raw.githubusercontent.com/strawberrymusicplayer/strawberry/master/data/screenshot/screenshot.png)
+![Browse](https://raw.githubusercontent.com/strawberrymusicplayer/strawberry/master/data/screenshot/screenshot.png)
 
----
+Resources:
 
-## :globe_with_meridians: Resources
+  * Website: https://www.strawberrymusicplayer.org/
+  * Wiki: https://wiki.strawberrymusicplayer.org/
+  * Forum: https://forum.strawberrymusicplayer.org/
+  * Github: https://github.com/strawberrymusicplayer/strawberry
+  * Latest builds: https://builds.strawberrymusicplayer.org/
+  * openSUSE buildservice: https://build.opensuse.org/package/show/home:jonaski:audio/strawberry
+  * Ubuntu PPA: https://launchpad.net/~jonaski/+archive/ubuntu/strawberry
+  * Ubuntu Unstable PPA: https://launchpad.net/~jonaski/+archive/ubuntu/strawberry-unstable
+  * Translations: https://crowdin.com/project/strawberrymusicplayer/
 
-- **Website:** https://www.strawberrymusicplayer.org
+### :bangbang: Opening an issue
-- **Wiki:** https://wiki.strawberrymusicplayer.org
-- **Forum:** https://forum.strawberrymusicplayer.org
-- **GitHub:** https://github.com/strawberrymusicplayer/strawberry
-- **Latest builds:** https://builds.strawberrymusicplayer.org
-- **openSUSE Build Service:**
-  - Stable: https://build.opensuse.org/package/show/home:jonaski:strawberry/strawberry
-  - Unstable: https://build.opensuse.org/package/show/home:jonaski:strawberry-dev/strawberry
-- **Ubuntu PPAs:**
-  - Stable: https://launchpad.net/~jonaski/+archive/ubuntu/strawberry
-  - Unstable: https://launchpad.net/~jonaski/+archive/ubuntu/strawberry-unstable
-- **Translations:** https://crowdin.com/project/strawberrymusicplayer
 
----
+* Read the FAQ: https://wiki.strawberrymusicplayer.org/wiki/FAQ
+* Search for the issue to see if it is already solved, or if there is an open issue for it already. If there is an open issue already, you can comment on it if you have additional information that could be useful to us.
+* For technical problems, discussion, questions and feature suggestions use the forum (https://forum.strawberrymusicplayer.org/) instead. The forum is better suited for discussion.
+* We do not take feature requests from users on GitHub. Any issues related to feature requests will be closed. This does not necessarily mean that we won't add new features, but we don't have time to take feature requests or answer questions about new features from users. It is still possible to suggest or discuss new features on the forum (https://forum.strawberrymusicplayer.org/).
+* We do not maintain the Flatpak package. Do not report issues related to Flatpak unless the issue can be reproduced with a native package, use Flatpak support instead https://flatpak.org/about/
 
-## :warning: Opening an Issue
+### :moneybag: Sponsoring
 
-Before creating a new GitHub issue:
+The program is free software, released under GPL. If you like this program and can make use of it, consider sponsoring or donating to help fund the project.
+There are currently 4 options for sponsoring:
 
-1. **Read the [FAQ](https://wiki.strawberrymusicplayer.org/wiki/FAQ)**.
-2. **Search existing issues** to avoid duplicates. If one already exists, comment there with any additional information.
-3. **Use the [forum](https://forum.strawberrymusicplayer.org/)** for technical problems, discussions or feature suggestions — it’s better suited for back-and-forth conversation.
-4. **Feature requests are not accepted on GitHub.** Issues created for feature requests will be closed. You can still discuss ideas on the forum.
-5. **Flatpak users:** We do **not** maintain the Flatpak package. Report Flatpak-specific issues via [Flatpak support](https://flatpak.org/about/).
-
----
-
-## :moneybag: Sponsoring
-
-Strawberry is **free software released under the GPL**.
-If you enjoy using it, please consider **supporting development** through sponsorship or donation.
-
-**Sponsorship options:**
 1. [Patreon](https://www.patreon.com/jonaskvinge)
 2. [GitHub](https://github.com/sponsors/jonaski)
 3. [Ko-fi](https://ko-fi.com/jonaskvinge)
 4. [PayPal](https://paypal.me/jonaskvinge)
 
-Supporting open-source developers helps ensure continued maintenance and improvements.
+Funding developers is a way to contribute to open source projects you appreciate, it helps developers get the resources they need, and recognize contributors working behind the scenes to make open source better for everyone.
 
----
+### :heavy_check_mark: Features
 
-## :white_check_mark: Features
+  * Play and organize music
+  * Supports WAV, FLAC, WavPack, Ogg FLAC, Ogg Vorbis, Ogg Opus, Ogg Speex, MPC, TrueAudio, AIFF, MP4, MP3, ASF and Monkey's Audio.
+  * Audio CD playback
+  * Native desktop notifications
+  * Playlist management
+  * Smart and dynamic playlists
+  * Advanced audio output and device configuration for bit-perfect playback on Linux
+  * In-player song loudness analysis and song playback loudness normalization, as per EBU R 128
+  * Edit tags on audio files
+  * Fetch tags from MusicBrainz
+  * Album cover art from [Last.fm](https://www.last.fm/), [Musicbrainz](https://musicbrainz.org/), [Discogs](https://www.discogs.com/), [Musixmatch](https://www.musixmatch.com/), [Deezer](https://www.deezer.com/), [Tidal](https://www.tidal.com/), [Qobuz](https://www.qobuz.com/) and [Spotify](https://www.spotify.com/)
+  * Song lyrics from [Genius](https://genius.com/), [Musixmatch](https://www.musixmatch.com/), [ChartLyrics](http://www.chartlyrics.com/), [lyrics.ovh](https://lyrics.ovh/), [lololyrics.com](https://www.lololyrics.com/), [songlyrics.com](https://www.songlyrics.com/), [azlyrics.com](https://www.azlyrics.com/) and [elyrics.net](https://www.elyrics.net/)
+  * Support for multiple backends
+  * Audio analyzer
+  * Audio equalizer
+  * Transfer music to mass-storage USB players, MTP compatible devices and iPod Nano/Classic
+  * Scrobbler with support for [Last.fm](https://www.last.fm/), [Libre.fm](https://libre.fm/) and [ListenBrainz](https://listenbrainz.org/)
+  * Streaming from Subsonic compatible servers
+  * Unofficial Tidal, Spotify and Qobuz integration
+  * Discord rich presence
 
-- Play and organize your music collection
-- Supports formats: WAV, FLAC, WavPack, Ogg Vorbis, Opus, MPC, TrueAudio, AIFF, MP4, MP3, ASF, and Monkey’s Audio
-- Audio CD playback
-- Bit-perfect playback on Linux
-- Native desktop notifications
-- Advanced playlist management
-- Smart and dynamic playlists
-- Loudness analysis and EBU R128 normalization
-- Editing tags and fetching missing tags via [MusicBrainz](https://musicbrainz.org/)
-- Album art from: [Last.fm](https://www.last.fm/), [MusicBrainz](https://musicbrainz.org/), [Discogs](https://www.discogs.com/), [Musixmatch](https://www.musixmatch.com/), [Deezer](https://www.deezer.com/), [Tidal](https://www.tidal.com/), [Qobuz](https://www.qobuz.com/), [Spotify](https://www.spotify.com/)
-- Lyrics from: [Genius](https://genius.com/), [Musixmatch](https://www.musixmatch.com/), [ChartLyrics](http://www.chartlyrics.com/), [lyrics.ovh](https://lyrics.ovh/), [lololyrics](https://www.lololyrics.com/), [songlyrics](https://www.songlyrics.com/), [azlyrics](https://www.azlyrics.com/), [elyrics](https://www.elyrics.net/), [letras](https://www.letras.mus.br), [LyricFind](https://lyrics.lyricfind.com) and [lrclib.net](https://lrclib.net/)
-- Audio analyzer and equalizer
-- Transfer music to USB, MTP and iPod devices
-- Scrobbling to [Last.fm](https://www.last.fm/) and [ListenBrainz](https://listenbrainz.org/)
-- Streaming from Subsonic-compatible servers
-- Unofficial integrations: Tidal, Spotify, and Qobuz
-- Discord Rich Presence
 
----
+It has so far been tested to work on Linux, OpenBSD, FreeBSD, macOS and Windows.
 
-:white_check_mark: Tested on **Linux**, **OpenBSD**, **FreeBSD**, **macOS**, and **Windows**.
+**Access to macOS and Windows releases are currently restricted to sponsors, a 5 USD monthly sponsorship is required. You can sponsor strawberry through <a href="https://www.patreon.com/jonaskvinge">Patreon</a> for direct access to new releases. If you are sponsoring through GitHub, Ko-fi or PayPal, please e-mail support AT strawberrymusicplayer.org for access to downloads.**
 
-> **Note:** macOS and Windows releases are currently **available to sponsors only**.
+### :heavy_exclamation_mark: Requirements
-> A monthly sponsorship via [Patreon](https://www.patreon.com/jonaskvinge) grants direct access to new releases.
 
----
+To build Strawberry from source you need the following installed on your system with the additional development packages/headers:
 
-## :gear: Requirements
+* [CMake 3.13 or higher](https://cmake.org/)
+* C/C++ compiler ([GCC](https://gcc.gnu.org/), [Clang](https://clang.llvm.org/) or [MSVC](https://visualstudio.microsoft.com/vs/features/cplusplus/))
+* [pkg-config](https://www.freedesktop.org/wiki/Software/pkg-config/) or [pkgconf](https://github.com/pkgconf/pkgconf)
+* [Boost](https://www.boost.org/)
+* [GLib](https://developer.gnome.org/glib/)
+* [Qt 6.4.0 or higher with components Core, Concurrent, Gui, Widgets, Network, Sql and D-Bus](https://www.qt.io/)
+* [SQLite 3.9 or newer](https://www.sqlite.org)
+* [ALSA (Required on Linux)](https://www.alsa-project.org/)
+* [GStreamer](https://gstreamer.freedesktop.org/)
+* [TagLib 1.12 or higher](https://www.taglib.org/)
+* [ICU](https://unicode-org.github.io/icu/)
+* [KDSingleApplication 1.1.0 or higher](https://github.com/KDAB/KDSingleApplication)
 
-To build Strawberry from source, you’ll need:
+Optional dependencies:
 
-**Dependencies:**
+* Song fingerprinting and MusicBrainz tagging: [Chromaprint](https://acoustid.org/chromaprint)
-- [CMake ≥= 3.13](https://cmake.org/)
+* Moodbar: [fftw3](http://www.fftw.org/)
-- C/C++ compiler ([GCC](https://gcc.gnu.org/), [Clang](https://clang.llvm.org/), or [MSVC](https://visualstudio.microsoft.com/vs/features/cplusplus/))
+* PulseAudio integration: [PulseAudio](https://www.freedesktop.org/wiki/Software/PulseAudio/?)
-- [pkg-config](https://www.freedesktop.org/wiki/Software/pkg-config/) or [pkgconf](https://github.com/pkgconf/pkgconf)
+* Audio CD: [libcdio](https://www.gnu.org/software/libcdio/)
-- [Boost](https://www.boost.org/)
+* MTP devices: [libmtp](http://libmtp.sourceforge.net/)
-- [GLib](https://developer.gnome.org/glib/)
+* iPod Classic devices: [libgpod](http://www.gtkpod.org/libgpod/)
-- [Qt ≥= 6.4](https://www.qt.io/) (Core, Concurrent, Gui, Widgets, Network, SQL, D-Bus)
+* EBU R 128 loudness normalization [libebur128](https://github.com/jiixyj/libebur128)
-- [SQLite ≥= 3.9](https://www.sqlite.org)
-- [ALSA (Linux only)](https://www.alsa-project.org/)
-- [GStreamer](https://gstreamer.freedesktop.org/)
-- [TagLib ≥= 1.12](https://www.taglib.org/)
-- [ICU](https://unicode-org.github.io/icu/)
-- [KDSingleApplication ≥= 1.1.0](https://github.com/KDAB/KDSingleApplication)
 
-**Dependencies for optional features:**
+You should also install the gstreamer plugins base and good, and optionally bad, ugly and libav to support all audio formats.
-- Fingerprinting & tagging: [Chromaprint](https://acoustid.org/chromaprint)
-- Moodbar: [FFTW3](http://www.fftw.org/)
-- PulseAudio integration: [PulseAudio](https://www.freedesktop.org/wiki/Software/PulseAudio/)
-- Audio CD support: [libcdio](https://www.gnu.org/software/libcdio/)
-- MTP devices: [libmtp](http://libmtp.sourceforge.net/)
-- iPod Classic: [libgpod](http://www.gtkpod.org/libgpod/)
-- EBU R128 normalization: [libebur128](https://github.com/jiixyj/libebur128)
-- Discord presence: [RapidJSON](https://rapidjson.org/)
 
-Also install GStreamer plugins **base**, **good**, and optionally **bad**, **ugly** and **libav** for full codec support.
+### :wrench: Build from source
 
----
+### Get the code:
-
-## :wrench: Build from Source
-
-**Get the code:**
 
     git clone --recursive https://github.com/strawberrymusicplayer/strawberry
 
-**Build and install:**
+### Build and install:
 
     cd strawberry
     cmake -S . -B build
     cmake --build build --parallel $(nproc)
     sudo cmake --install build
 
-For building on Windows with Visual Studio 2022, see: :point_right: https://github.com/strawberrymusicplayer/strawberry-msvc
+To build on Windows with Visual Studio 2022, see https://github.com/strawberrymusicplayer/strawberry-msvc
 
----
+### :penguin: Packaging status
-
-## :package: Packaging status
 
 [![Packaging status](https://repology.org/badge/vertical-allrepos/strawberry.svg?columns=3&header=Strawberry&exclude_unsupported=1)](https://repology.org/metapackage/strawberry/versions)

cmake/Version.cmake

@@ -1,6 +1,6 @@
 set(STRAWBERRY_VERSION_MAJOR 1)
 set(STRAWBERRY_VERSION_MINOR 2)
-set(STRAWBERRY_VERSION_PATCH 16)
+set(STRAWBERRY_VERSION_PATCH 9)
 #set(STRAWBERRY_VERSION_PRERELEASE rc1)
 
 set(INCLUDE_GIT_REVISION ON)

data/data.qrc

@@ -12,7 +12,6 @@
         <file>schema/schema-18.sql</file>
         <file>schema/schema-19.sql</file>
         <file>schema/schema-20.sql</file>
-        <file>schema/schema-21.sql</file>
         <file>schema/device-schema.sql</file>
         <file>style/strawberry.css</file>
         <file>style/smartplaylistsearchterm.css</file>

data/icons.qrc

@@ -98,7 +98,6 @@
         <file>icons/128x128/somafm.png</file>
         <file>icons/128x128/radioparadise.png</file>
         <file>icons/128x128/musicbrainz.png</file>
-        <file>icons/128x128/dropbox.png</file>
         <file>icons/64x64/albums.png</file>
         <file>icons/64x64/alsa.png</file>
         <file>icons/64x64/application-exit.png</file>
@@ -198,7 +197,6 @@
         <file>icons/64x64/somafm.png</file>
         <file>icons/64x64/radioparadise.png</file>
         <file>icons/64x64/musicbrainz.png</file>
-        <file>icons/64x64/dropbox.png</file>
         <file>icons/48x48/albums.png</file>
         <file>icons/48x48/alsa.png</file>
         <file>icons/48x48/application-exit.png</file>
@@ -302,7 +300,6 @@
         <file>icons/48x48/somafm.png</file>
         <file>icons/48x48/radioparadise.png</file>
         <file>icons/48x48/musicbrainz.png</file>
-        <file>icons/48x48/dropbox.png</file>
         <file>icons/32x32/albums.png</file>
         <file>icons/32x32/alsa.png</file>
         <file>icons/32x32/application-exit.png</file>
@@ -406,7 +403,6 @@
         <file>icons/32x32/somafm.png</file>
         <file>icons/32x32/radioparadise.png</file>
         <file>icons/32x32/musicbrainz.png</file>
-        <file>icons/32x32/dropbox.png</file>
         <file>icons/22x22/albums.png</file>
         <file>icons/22x22/alsa.png</file>
         <file>icons/22x22/application-exit.png</file>
@@ -510,6 +506,5 @@
         <file>icons/22x22/somafm.png</file>
         <file>icons/22x22/radioparadise.png</file>
         <file>icons/22x22/musicbrainz.png</file>
-        <file>icons/22x22/dropbox.png</file>
     </qresource>
 </RCC>

data/schema/device-schema.sql

@@ -12,13 +12,9 @@ CREATE TABLE device_%deviceid_subdirectories (
 CREATE TABLE device_%deviceid_songs (
 
   title TEXT,
-  titlesort TEXT,
   album TEXT,
-  albumsort TEXT,
   artist TEXT,
-  artistsort TEXT,
   albumartist TEXT,
-  albumartistsort TEXT,
   track INTEGER NOT NULL DEFAULT -1,
   disc INTEGER NOT NULL DEFAULT -1,
   year INTEGER NOT NULL DEFAULT -1,
@@ -26,9 +22,7 @@ CREATE TABLE device_%deviceid_songs (
   genre TEXT,
   compilation INTEGER NOT NULL DEFAULT 0,
   composer TEXT,
-  composersort TEXT,
   performer TEXT,
-  performersort TEXT,
   grouping TEXT,
   comment TEXT,
   lyrics TEXT,
@@ -92,11 +86,7 @@ CREATE TABLE device_%deviceid_songs (
   musicbrainz_work_id TEXT,
 
   ebur128_integrated_loudness_lufs REAL,
-  ebur128_loudness_range_lu REAL,
+  ebur128_loudness_range_lu REAL
-
-  bpm REAL,
-  mood TEXT,
-  initial_key TEXT
 
 );
 
@@ -104,4 +94,4 @@ CREATE INDEX idx_device_%deviceid_songs_album ON device_%deviceid_songs (album);
 
 CREATE INDEX idx_device_%deviceid_songs_comp_artist ON device_%deviceid_songs (compilation_effective, artist);
 
-UPDATE devices SET schema_version=6 WHERE ROWID=%deviceid;
+UPDATE devices SET schema_version=5 WHERE ROWID=%deviceid;

data/schema/schema-21.sql

@@ -1,43 +0,0 @@
-DROP INDEX IF EXISTS idx_albumartistsort;
-
-DROP INDEX IF EXISTS idx_albumsort;
-
-DROP INDEX IF EXISTS idx_artistsort;
-
-DROP INDEX IF EXISTS idx_composersort;
-
-DROP INDEX IF EXISTS idx_performersort;
-
-DROP INDEX IF EXISTS idx_titlesort;
-
-ALTER TABLE %allsongstables ADD COLUMN albumartistsort TEXT;
-
-ALTER TABLE %allsongstables ADD COLUMN albumsort TEXT;
-
-ALTER TABLE %allsongstables ADD COLUMN artistsort TEXT;
-
-ALTER TABLE %allsongstables ADD COLUMN composersort TEXT;
-
-ALTER TABLE %allsongstables ADD COLUMN performersort TEXT;
-
-ALTER TABLE %allsongstables ADD COLUMN titlesort TEXT;
-
-ALTER TABLE %allsongstables ADD COLUMN bpm REAL;
-
-ALTER TABLE %allsongstables ADD COLUMN mood TEXT;
-
-ALTER TABLE %allsongstables ADD COLUMN initial_key TEXT;
-
-CREATE INDEX IF NOT EXISTS idx_albumartistsort ON songs (albumartistsort);
-
-CREATE INDEX IF NOT EXISTS idx_albumsort ON songs (album);
-
-CREATE INDEX IF NOT EXISTS idx_artistsort ON songs (artistsort);
-
-CREATE INDEX IF NOT EXISTS idx_composersort ON songs (title);
-
-CREATE INDEX IF NOT EXISTS idx_performersort ON songs (title);
-
-CREATE INDEX IF NOT EXISTS idx_titlesort ON songs (title);
-
-UPDATE schema_version SET version=21;

data/schema/schema-22.sql

@@ -1,82 +0,0 @@
-CREATE TABLE IF NOT EXISTS dropbox_songs (
-
-  title TEXT,
-  album TEXT,
-  artist TEXT,
-  albumartist TEXT,
-  track INTEGER NOT NULL DEFAULT -1,
-  disc INTEGER NOT NULL DEFAULT -1,
-  year INTEGER NOT NULL DEFAULT -1,
-  originalyear INTEGER NOT NULL DEFAULT -1,
-  genre TEXT,
-  compilation INTEGER NOT NULL DEFAULT 0,
-  composer TEXT,
-  performer TEXT,
-  grouping TEXT,
-  comment TEXT,
-  lyrics TEXT,
-
-  artist_id TEXT,
-  album_id TEXT,
-  song_id TEXT,
-
-  beginning INTEGER NOT NULL DEFAULT 0,
-  length INTEGER NOT NULL DEFAULT 0,
-
-  bitrate INTEGER NOT NULL DEFAULT -1,
-  samplerate INTEGER NOT NULL DEFAULT -1,
-  bitdepth INTEGER NOT NULL DEFAULT -1,
-
-  source INTEGER NOT NULL DEFAULT 0,
-  directory_id INTEGER NOT NULL DEFAULT -1,
-  url TEXT NOT NULL,
-  filetype INTEGER NOT NULL DEFAULT 0,
-  filesize INTEGER NOT NULL DEFAULT -1,
-  mtime INTEGER NOT NULL DEFAULT -1,
-  ctime INTEGER NOT NULL DEFAULT -1,
-  unavailable INTEGER DEFAULT 0,
-
-  fingerprint TEXT,
-
-  playcount INTEGER NOT NULL DEFAULT 0,
-  skipcount INTEGER NOT NULL DEFAULT 0,
-  lastplayed INTEGER NOT NULL DEFAULT -1,
-  lastseen INTEGER NOT NULL DEFAULT -1,
-
-  compilation_detected INTEGER DEFAULT 0,
-  compilation_on INTEGER NOT NULL DEFAULT 0,
-  compilation_off INTEGER NOT NULL DEFAULT 0,
-  compilation_effective INTEGER NOT NULL DEFAULT 0,
-
-  art_embedded INTEGER DEFAULT 0,
-  art_automatic TEXT,
-  art_manual TEXT,
-  art_unset INTEGER DEFAULT 0,
-
-  effective_albumartist TEXT,
-  effective_originalyear INTEGER NOT NULL DEFAULT 0,
-
-  cue_path TEXT,
-
-  rating INTEGER DEFAULT -1,
-
-  acoustid_id TEXT,
-  acoustid_fingerprint TEXT,
-
-  musicbrainz_album_artist_id TEXT,
-  musicbrainz_artist_id TEXT,
-  musicbrainz_original_artist_id TEXT,
-  musicbrainz_album_id TEXT,
-  musicbrainz_original_album_id TEXT,
-  musicbrainz_recording_id TEXT,
-  musicbrainz_track_id TEXT,
-  musicbrainz_disc_id TEXT,
-  musicbrainz_release_group_id TEXT,
-  musicbrainz_work_id TEXT,
-
-  ebur128_integrated_loudness_lufs REAL,
-  ebur128_loudness_range_lu REAL
-
-);
-
-UPDATE schema_version SET version=22;

data/schema/schema.sql

@@ -4,7 +4,7 @@ CREATE TABLE IF NOT EXISTS schema_version (
 
 DELETE FROM schema_version;
 
-INSERT INTO schema_version (version) VALUES (21);
+INSERT INTO schema_version (version) VALUES (20);
 
 CREATE TABLE IF NOT EXISTS directories (
   path TEXT NOT NULL,
@@ -20,13 +20,9 @@ CREATE TABLE IF NOT EXISTS subdirectories (
 CREATE TABLE IF NOT EXISTS songs (
 
   title TEXT,
-  titlesort TEXT,
   album TEXT,
-  albumsort TEXT,
   artist TEXT,
-  artistsort TEXT,
   albumartist TEXT,
-  albumartistsort TEXT,
   track INTEGER NOT NULL DEFAULT -1,
   disc INTEGER NOT NULL DEFAULT -1,
   year INTEGER NOT NULL DEFAULT -1,
@@ -34,9 +30,7 @@ CREATE TABLE IF NOT EXISTS songs (
   genre TEXT,
   compilation INTEGER NOT NULL DEFAULT 0,
   composer TEXT,
-  composersort TEXT,
   performer TEXT,
-  performersort TEXT,
   grouping TEXT,
   comment TEXT,
   lyrics TEXT,
@@ -100,24 +94,16 @@ CREATE TABLE IF NOT EXISTS songs (
   musicbrainz_work_id TEXT,
 
   ebur128_integrated_loudness_lufs REAL,
-  ebur128_loudness_range_lu REAL,
+  ebur128_loudness_range_lu REAL
-
-  bpm REAL,
-  mood TEXT,
-  initial_key TEXT
 
 );
 
 CREATE TABLE IF NOT EXISTS subsonic_songs (
 
   title TEXT,
-  titlesort TEXT,
   album TEXT,
-  albumsort TEXT,
   artist TEXT,
-  artistsort TEXT,
   albumartist TEXT,
-  albumartistsort TEXT,
   track INTEGER NOT NULL DEFAULT -1,
   disc INTEGER NOT NULL DEFAULT -1,
   year INTEGER NOT NULL DEFAULT -1,
@@ -125,9 +111,7 @@ CREATE TABLE IF NOT EXISTS subsonic_songs (
   genre TEXT,
   compilation INTEGER NOT NULL DEFAULT 0,
   composer TEXT,
-  composersort TEXT,
   performer TEXT,
-  performersort TEXT,
   grouping TEXT,
   comment TEXT,
   lyrics TEXT,
@@ -191,24 +175,16 @@ CREATE TABLE IF NOT EXISTS subsonic_songs (
   musicbrainz_work_id TEXT,
 
   ebur128_integrated_loudness_lufs REAL,
-  ebur128_loudness_range_lu REAL,
+  ebur128_loudness_range_lu REAL
-
-  bpm REAL,
-  mood TEXT,
-  initial_key TEXT
 
 );
 
 CREATE TABLE IF NOT EXISTS tidal_artists_songs (
 
   title TEXT,
-  titlesort TEXT,
   album TEXT,
-  albumsort TEXT,
   artist TEXT,
-  artistsort TEXT,
   albumartist TEXT,
-  albumartistsort TEXT,
   track INTEGER NOT NULL DEFAULT -1,
   disc INTEGER NOT NULL DEFAULT -1,
   year INTEGER NOT NULL DEFAULT -1,
@@ -216,9 +192,7 @@ CREATE TABLE IF NOT EXISTS tidal_artists_songs (
   genre TEXT,
   compilation INTEGER NOT NULL DEFAULT 0,
   composer TEXT,
-  composersort TEXT,
   performer TEXT,
-  performersort TEXT,
   grouping TEXT,
   comment TEXT,
   lyrics TEXT,
@@ -282,24 +256,16 @@ CREATE TABLE IF NOT EXISTS tidal_artists_songs (
   musicbrainz_work_id TEXT,
 
   ebur128_integrated_loudness_lufs REAL,
-  ebur128_loudness_range_lu REAL,
+  ebur128_loudness_range_lu REAL
-
-  bpm REAL,
-  mood TEXT,
-  initial_key TEXT
 
 );
 
 CREATE TABLE IF NOT EXISTS tidal_albums_songs (
 
   title TEXT,
-  titlesort TEXT,
   album TEXT,
-  albumsort TEXT,
   artist TEXT,
-  artistsort TEXT,
   albumartist TEXT,
-  albumartistsort TEXT,
   track INTEGER NOT NULL DEFAULT -1,
   disc INTEGER NOT NULL DEFAULT -1,
   year INTEGER NOT NULL DEFAULT -1,
@@ -307,9 +273,7 @@ CREATE TABLE IF NOT EXISTS tidal_albums_songs (
   genre TEXT,
   compilation INTEGER NOT NULL DEFAULT 0,
   composer TEXT,
-  composersort TEXT,
   performer TEXT,
-  performersort TEXT,
   grouping TEXT,
   comment TEXT,
   lyrics TEXT,
@@ -373,24 +337,16 @@ CREATE TABLE IF NOT EXISTS tidal_albums_songs (
   musicbrainz_work_id TEXT,
 
   ebur128_integrated_loudness_lufs REAL,
-  ebur128_loudness_range_lu REAL,
+  ebur128_loudness_range_lu REAL
-
-  bpm REAL,
-  mood TEXT,
-  initial_key TEXT
 
 );
 
 CREATE TABLE IF NOT EXISTS tidal_songs (
 
   title TEXT,
-  titlesort TEXT,
   album TEXT,
-  albumsort TEXT,
   artist TEXT,
-  artistsort TEXT,
   albumartist TEXT,
-  albumartistsort TEXT,
   track INTEGER NOT NULL DEFAULT -1,
   disc INTEGER NOT NULL DEFAULT -1,
   year INTEGER NOT NULL DEFAULT -1,
@@ -398,9 +354,7 @@ CREATE TABLE IF NOT EXISTS tidal_songs (
   genre TEXT,
   compilation INTEGER NOT NULL DEFAULT 0,
   composer TEXT,
-  composersort TEXT,
   performer TEXT,
-  performersort TEXT,
   grouping TEXT,
   comment TEXT,
   lyrics TEXT,
@@ -464,24 +418,16 @@ CREATE TABLE IF NOT EXISTS tidal_songs (
   musicbrainz_work_id TEXT,
 
   ebur128_integrated_loudness_lufs REAL,
-  ebur128_loudness_range_lu REAL,
+  ebur128_loudness_range_lu REAL
-
-  bpm REAL,
-  mood TEXT,
-  initial_key TEXT
 
 );
 
 CREATE TABLE IF NOT EXISTS spotify_artists_songs (
 
   title TEXT,
-  titlesort TEXT,
   album TEXT,
-  albumsort TEXT,
   artist TEXT,
-  artistsort TEXT,
   albumartist TEXT,
-  albumartistsort TEXT,
   track INTEGER NOT NULL DEFAULT -1,
   disc INTEGER NOT NULL DEFAULT -1,
   year INTEGER NOT NULL DEFAULT -1,
@@ -489,9 +435,7 @@ CREATE TABLE IF NOT EXISTS spotify_artists_songs (
   genre TEXT,
   compilation INTEGER NOT NULL DEFAULT 0,
   composer TEXT,
-  composersort TEXT,
   performer TEXT,
-  performersort TEXT,
   grouping TEXT,
   comment TEXT,
   lyrics TEXT,
@@ -555,24 +499,16 @@ CREATE TABLE IF NOT EXISTS spotify_artists_songs (
   musicbrainz_work_id TEXT,
 
   ebur128_integrated_loudness_lufs REAL,
-  ebur128_loudness_range_lu REAL,
+  ebur128_loudness_range_lu REAL
-
-  bpm REAL,
-  mood TEXT,
-  initial_key TEXT
 
 );
 
 CREATE TABLE IF NOT EXISTS spotify_albums_songs (
 
   title TEXT,
-  titlesort TEXT,
   album TEXT,
-  albumsort TEXT,
   artist TEXT,
-  artistsort TEXT,
   albumartist TEXT,
-  albumartistsort TEXT,
   track INTEGER NOT NULL DEFAULT -1,
   disc INTEGER NOT NULL DEFAULT -1,
   year INTEGER NOT NULL DEFAULT -1,
@@ -580,9 +516,7 @@ CREATE TABLE IF NOT EXISTS spotify_albums_songs (
   genre TEXT,
   compilation INTEGER NOT NULL DEFAULT 0,
   composer TEXT,
-  composersort TEXT,
   performer TEXT,
-  performersort TEXT,
   grouping TEXT,
   comment TEXT,
   lyrics TEXT,
@@ -646,24 +580,16 @@ CREATE TABLE IF NOT EXISTS spotify_albums_songs (
   musicbrainz_work_id TEXT,
 
   ebur128_integrated_loudness_lufs REAL,
-  ebur128_loudness_range_lu REAL,
+  ebur128_loudness_range_lu REAL
-
-  bpm REAL,
-  mood TEXT,
-  initial_key TEXT
 
 );
 
 CREATE TABLE IF NOT EXISTS spotify_songs (
 
   title TEXT,
-  titlesort TEXT,
   album TEXT,
-  albumsort TEXT,
   artist TEXT,
-  artistsort TEXT,
   albumartist TEXT,
-  albumartistsort TEXT,
   track INTEGER NOT NULL DEFAULT -1,
   disc INTEGER NOT NULL DEFAULT -1,
   year INTEGER NOT NULL DEFAULT -1,
@@ -671,9 +597,7 @@ CREATE TABLE IF NOT EXISTS spotify_songs (
   genre TEXT,
   compilation INTEGER NOT NULL DEFAULT 0,
   composer TEXT,
-  composersort TEXT,
   performer TEXT,
-  performersort TEXT,
   grouping TEXT,
   comment TEXT,
   lyrics TEXT,
@@ -737,24 +661,16 @@ CREATE TABLE IF NOT EXISTS spotify_songs (
   musicbrainz_work_id TEXT,
 
   ebur128_integrated_loudness_lufs REAL,
-  ebur128_loudness_range_lu REAL,
+  ebur128_loudness_range_lu REAL
-
-  bpm REAL,
-  mood TEXT,
-  initial_key TEXT
 
 );
 
 CREATE TABLE IF NOT EXISTS qobuz_artists_songs (
 
   title TEXT,
-  titlesort TEXT,
   album TEXT,
-  albumsort TEXT,
   artist TEXT,
-  artistsort TEXT,
   albumartist TEXT,
-  albumartistsort TEXT,
   track INTEGER NOT NULL DEFAULT -1,
   disc INTEGER NOT NULL DEFAULT -1,
   year INTEGER NOT NULL DEFAULT -1,
@@ -762,9 +678,7 @@ CREATE TABLE IF NOT EXISTS qobuz_artists_songs (
   genre TEXT,
   compilation INTEGER NOT NULL DEFAULT 0,
   composer TEXT,
-  composersort TEXT,
   performer TEXT,
-  performersort TEXT,
   grouping TEXT,
   comment TEXT,
   lyrics TEXT,
@@ -828,24 +742,16 @@ CREATE TABLE IF NOT EXISTS qobuz_artists_songs (
   musicbrainz_work_id TEXT,
 
   ebur128_integrated_loudness_lufs REAL,
-  ebur128_loudness_range_lu REAL,
+  ebur128_loudness_range_lu REAL
-
-  bpm REAL,
-  mood TEXT,
-  initial_key TEXT
 
 );
 
 CREATE TABLE IF NOT EXISTS qobuz_albums_songs (
 
   title TEXT,
-  titlesort TEXT,
   album TEXT,
-  albumsort TEXT,
   artist TEXT,
-  artistsort TEXT,
   albumartist TEXT,
-  albumartistsort TEXT,
   track INTEGER NOT NULL DEFAULT -1,
   disc INTEGER NOT NULL DEFAULT -1,
   year INTEGER NOT NULL DEFAULT -1,
@@ -853,9 +759,7 @@ CREATE TABLE IF NOT EXISTS qobuz_albums_songs (
   genre TEXT,
   compilation INTEGER NOT NULL DEFAULT 0,
   composer TEXT,
-  composersort TEXT,
   performer TEXT,
-  performersort TEXT,
   grouping TEXT,
   comment TEXT,
   lyrics TEXT,
@@ -919,107 +823,12 @@ CREATE TABLE IF NOT EXISTS qobuz_albums_songs (
   musicbrainz_work_id TEXT,
 
   ebur128_integrated_loudness_lufs REAL,
-  ebur128_loudness_range_lu REAL,
+  ebur128_loudness_range_lu REAL
-
-  bpm REAL,
-  mood TEXT,
-  initial_key TEXT
 
 );
 
 CREATE TABLE IF NOT EXISTS qobuz_songs (
 
-  title TEXT,
-  titlesort TEXT,
-  album TEXT,
-  albumsort TEXT,
-  artist TEXT,
-  artistsort TEXT,
-  albumartist TEXT,
-  albumartistsort TEXT,
-  track INTEGER NOT NULL DEFAULT -1,
-  disc INTEGER NOT NULL DEFAULT -1,
-  year INTEGER NOT NULL DEFAULT -1,
-  originalyear INTEGER NOT NULL DEFAULT -1,
-  genre TEXT,
-  compilation INTEGER NOT NULL DEFAULT 0,
-  composer TEXT,
-  composersort TEXT,
-  performer TEXT,
-  performersort TEXT,
-  grouping TEXT,
-  comment TEXT,
-  lyrics TEXT,
-
-  artist_id TEXT,
-  album_id TEXT,
-  song_id TEXT,
-
-  beginning INTEGER NOT NULL DEFAULT 0,
-  length INTEGER NOT NULL DEFAULT 0,
-
-  bitrate INTEGER NOT NULL DEFAULT -1,
-  samplerate INTEGER NOT NULL DEFAULT -1,
-  bitdepth INTEGER NOT NULL DEFAULT -1,
-
-  source INTEGER NOT NULL DEFAULT 0,
-  directory_id INTEGER NOT NULL DEFAULT -1,
-  url TEXT NOT NULL,
-  filetype INTEGER NOT NULL DEFAULT 0,
-  filesize INTEGER NOT NULL DEFAULT -1,
-  mtime INTEGER NOT NULL DEFAULT -1,
-  ctime INTEGER NOT NULL DEFAULT -1,
-  unavailable INTEGER DEFAULT 0,
-
-  fingerprint TEXT,
-
-  playcount INTEGER NOT NULL DEFAULT 0,
-  skipcount INTEGER NOT NULL DEFAULT 0,
-  lastplayed INTEGER NOT NULL DEFAULT -1,
-  lastseen INTEGER NOT NULL DEFAULT -1,
-
-  compilation_detected INTEGER DEFAULT 0,
-  compilation_on INTEGER NOT NULL DEFAULT 0,
-  compilation_off INTEGER NOT NULL DEFAULT 0,
-  compilation_effective INTEGER NOT NULL DEFAULT 0,
-
-  art_embedded INTEGER DEFAULT 0,
-  art_automatic TEXT,
-  art_manual TEXT,
-  art_unset INTEGER DEFAULT 0,
-
-  effective_albumartist TEXT,
-  effective_originalyear INTEGER NOT NULL DEFAULT 0,
-
-  cue_path TEXT,
-
-  rating INTEGER DEFAULT -1,
-
-  acoustid_id TEXT,
-  acoustid_fingerprint TEXT,
-
-  musicbrainz_album_artist_id TEXT,
-  musicbrainz_artist_id TEXT,
-  musicbrainz_original_artist_id TEXT,
-  musicbrainz_album_id TEXT,
-  musicbrainz_original_album_id TEXT,
-  musicbrainz_recording_id TEXT,
-  musicbrainz_track_id TEXT,
-  musicbrainz_disc_id TEXT,
-  musicbrainz_release_group_id TEXT,
-  musicbrainz_work_id TEXT,
-
-  ebur128_integrated_loudness_lufs REAL,
-  ebur128_loudness_range_lu REAL,
-
-  bpm REAL,
-  mood TEXT,
-  initial_key TEXT
-
-);
-
-CREATE TABLE IF NOT EXISTS dropbox_songs (
-
   title TEXT,
   album TEXT,
   artist TEXT,
@@ -1122,13 +931,9 @@ CREATE TABLE IF NOT EXISTS playlist_items (
   playlist_url TEXT,
 
   title TEXT,
-  titlesort TEXT,
   album TEXT,
-  albumsort TEXT,
   artist TEXT,
-  artistsort TEXT,
   albumartist TEXT,
-  albumartistsort TEXT,
   track INTEGER,
   disc INTEGER,
   year INTEGER,
@@ -1136,9 +941,7 @@ CREATE TABLE IF NOT EXISTS playlist_items (
   genre TEXT,
   compilation INTEGER DEFAULT 0,
   composer TEXT,
-  composersort TEXT,
   performer TEXT,
-  performersort TEXT,
   grouping TEXT,
   comment TEXT,
   lyrics TEXT,
@@ -1202,11 +1005,7 @@ CREATE TABLE IF NOT EXISTS playlist_items (
   musicbrainz_work_id TEXT,
 
   ebur128_integrated_loudness_lufs REAL,
-  ebur128_loudness_range_lu REAL,
+  ebur128_loudness_range_lu REAL
-
-  bpm REAL,
-  mood TEXT,
-  initial_key TEXT
 
 );
 
@@ -1233,22 +1032,10 @@ CREATE INDEX IF NOT EXISTS idx_comp_artist ON songs (compilation_effective, arti
 
 CREATE INDEX IF NOT EXISTS idx_albumartist ON songs (albumartist);
 
-CREATE INDEX IF NOT EXISTS idx_albumartistsort ON songs (albumartistsort);
-
 CREATE INDEX IF NOT EXISTS idx_artist ON songs (artist);
 
-CREATE INDEX IF NOT EXISTS idx_artistsort ON songs (artistsort);
-
 CREATE INDEX IF NOT EXISTS idx_album ON songs (album);
 
-CREATE INDEX IF NOT EXISTS idx_albumsort ON songs (album);
-
 CREATE INDEX IF NOT EXISTS idx_title ON songs (title);
 
-CREATE INDEX IF NOT EXISTS idx_titlesort ON songs (title);
-
-CREATE INDEX IF NOT EXISTS idx_composersort ON songs (title);
-
-CREATE INDEX IF NOT EXISTS idx_performersort ON songs (title);
-
 CREATE VIEW IF NOT EXISTS duplicated_songs as select artist dup_artist, album dup_album, title dup_title from songs as inner_songs where artist != '' and album != '' and title != '' and unavailable = 0 group by artist, album , title having count(*) > 1;

debian/control

@@ -60,11 +60,11 @@ Description: music player and music collection organizer
   - Edit tags on audio files
   - Automatically retrieve tags from MusicBrainz
   - Album cover art from Last.fm, Musicbrainz, Discogs, Musixmatch, Deezer, Tidal, Qobuz and Spotify
-  - Lyrics from multiple sources
+  - Song lyrics from Genius, Musixmatch, ChartLyrics, lyrics.ovh, lololyrics.com, songlyrics.com, azlyrics.com and elyrics.net
   - Audio analyzer
   - Audio equalizer
   - Transfer music to mass-storage USB players, MTP compatible devices and iPod Nano/Classic
-  - Scrobbler with support for Last.fm and ListenBrainz
+  - Scrobbler with support for Last.fm, Libre.fm and ListenBrainz
   - Streaming support for Subsonic-compatible servers
   - Unofficial streaming support for Tidal and Qobuz
  .

dist/macos/macversion.sh

@@ -0,0 +1,22 @@
+#!/bin/sh
+
+macos_version=$(sw_vers -productVersion)
+macos_version_major=$(echo $macos_version | awk -F '[.]' '{print $1}')
+macos_version_minor=$(echo $macos_version | awk -F '[.]' '{print $2}')
+
+if [ "${macos_version_major}" = "10" ]; then
+  macos_codenames=(
+    ["13"]="highsierra"
+    ["14"]="mojave"
+    ["15"]="catalina"
+  )
+  if [[ -n "${macos_codenames[$macos_version_minor]}" ]]; then
+    echo "${macos_codenames[$macos_version_minor]}"
+  else
+    echo "unknown"
+  fi
+elif [ "${macos_version_major}" = "11" ]; then
+  echo "bigsur"
+else
+  echo "unknown"
+fi

dist/unix/org.strawberrymusicplayer.strawberry.appdata.xml

@@ -31,10 +31,10 @@
       <li>Edit tags on audio files</li>
       <li>Automatically retrieve tags from MusicBrainz</li>
       <li>Album cover art from Last.fm, Musicbrainz, Discogs, Musixmatch, Deezer, Tidal, Qobuz and Spotify</li>
-      <li>Lyrics from multiple sources</li>
+      <li>Song lyrics from Genius, Musixmatch, ChartLyrics, lyrics.ovh, lololyrics.com, songlyrics.com, azlyrics.com and elyrics.net</li>
       <li>Audio analyzer and equalizer</li>
       <li>Transfer music to mass-storage USB players, MTP compatible devices and iPod Nano/Classic</li>
-      <li>Scrobbler with support for Last.fm and ListenBrainz</li>
+      <li>Scrobbler with support for Last.fm, Libre.fm and ListenBrainz</li>
       <li>Streaming support for Subsonic-compatible servers</li>
       <li>Unofficial streaming support for Tidal, Spotify and Qobuz</li>
     </ul>
@@ -51,13 +51,6 @@
   </screenshots>
   <update_contact>eclipseo@fedoraproject.org</update_contact>
     <releases>
-        <release version="1.2.16" date="2025-12-16"/>
-        <release version="1.2.15" date="2025-11-25"/>
-        <release version="1.2.14" date="2025-10-25"/>
-        <release version="1.2.13" date="2025-08-31"/>
-        <release version="1.2.12" date="2025-08-12"/>
-        <release version="1.2.11" date="2025-05-15"/>
-        <release version="1.2.10" date="2025-04-18"/>
         <release version="1.2.9" date="2025-04-08"/>
         <release version="1.2.8" date="2025-04-05"/>
         <release version="1.2.7" date="2025-01-31"/>

dist/unix/org.strawberrymusicplayer.strawberry.desktop

@@ -13,7 +13,8 @@ TryExec=strawberry
 Icon=strawberry
 Terminal=false
 Categories=AudioVideo;Player;Qt;Audio;
-Keywords=Audio;Player;Clementine;
+Keywords=Audio;Player;
+StartupNotify=false
 MimeType=x-content/audio-player;application/ogg;application/x-ogg;application/x-ogm-audio;audio/flac;audio/ogg;audio/vorbis;audio/aac;audio/mp4;audio/mpeg;audio/mpegurl;audio/vnd.rn-realaudio;audio/x-flac;audio/x-oggflac;audio/x-vorbis;audio/x-vorbis+ogg;audio/x-speex;audio/x-wav;audio/x-wavpack;audio/x-ape;audio/x-mp3;audio/x-mpeg;audio/x-mpegurl;audio/x-ms-wma;audio/x-musepack;audio/x-pn-realaudio;audio/x-scpls;video/x-ms-asf;x-scheme-handler/tidal;
 StartupWMClass=strawberry
 Actions=Play-Pause;Stop;StopAfterCurrent;Previous;Next;

dist/unix/strawberry.1

@@ -29,7 +29,9 @@ Features:
 .br
 - Album cover art from Last.fm, Musicbrainz, Discogs, Musixmatch, Deezer, Tidal, Qobuz and Spotify
 .br
-- Lyrics from multiple sources
+- Song lyrics from Lyrics.com, Genius, Musixmatch, ChartLyrics, lyrics.ovh and lololyrics.com
+.br
+- Support for multiple backends
 .br
 - Audio analyzer
 .br
@@ -37,7 +39,7 @@ Features:
 .br
 - Transfer music to mass-storage USB players, MTP compatible devices and iPod Nano/Classic
 .br
-- Scrobbler with support for Last.fm and ListenBrainz
+- Scrobbler with support for Last.fm, Libre.fm and ListenBrainz
 .br
 - Streaming support for Subsonic-compatible servers
 .br

dist/unix/strawberry.spec.in

@@ -93,15 +93,16 @@ Features:
   - Edit tags on audio files
   - Automatically retrieve tags from MusicBrainz
   - Album cover art from Last.fm, Musicbrainz, Discogs, Musixmatch, Deezer, Tidal, Qobuz and Spotify
-  - Lyrics from multiple sources
+  - Song lyrics from Genius, Musixmatch, ChartLyrics, lyrics.ovh, lololyrics.com, songlyrics.com, azlyrics.com and elyrics.net
+  - Support for multiple backends
   - Audio analyzer
   - Audio equalizer
-  - Scrobbler with support for Last.fm and ListenBrainz
+  - Scrobbler with support for Last.fm, Libre.fm and ListenBrainz
   - Transfer music to mass-storage USB players, MTP compatible devices and iPod Nano/Classic
   - Streaming support for Subsonic-compatible servers
   - Unofficial streaming support for Tidal and Qobuz
 
-%if 0%{?suse_version} && 0%{?suse_version} < 1600
+%if 0%{?suse_version} && 0%{?suse_version} <= 1600
 %debug_package
 %endif
 

dist/windows/strawberry.nsi.in

@@ -21,10 +21,6 @@
   !define arch_x64
 !else if "@ARCH@" == "x86_64-w64-mingw32.shared"
   !define arch_x64
-!else if "@ARCH@" == "arm64"
-  !define arch_arm64
-!else
-  !error "Missing ARCH"
 !endif
 
 !ifdef arch_x86
@@ -35,10 +31,6 @@
   !define arch "x64"
 !endif
 
-!ifdef arch_arm64
-  !define arch "arm64"
-!endif
-
 
 !if "@CMAKE_BUILD_TYPE@" == "Release"
   !define release
@@ -46,8 +38,6 @@
   !define release
 !else if "@CMAKE_BUILD_TYPE@" == "Debug"
   !define debug
-!else
-  !error "Missing CMAKE_BUILD_TYPE"
 !endif
 
 !ifdef release
@@ -80,7 +70,7 @@
   !ifdef arch_x86
     !define PRODUCT_INSTALL_DIR "$PROGRAMFILES\Strawberry Music Player Debug"
   !endif
-  !ifdef arch_x64 || arch_arm64
+  !ifdef arch_x64
     !define PRODUCT_INSTALL_DIR "$PROGRAMFILES64\Strawberry Music Player Debug"
   !endif
 !else
@@ -90,7 +80,7 @@
   !ifdef arch_x86
     !define PRODUCT_INSTALL_DIR "$PROGRAMFILES\Strawberry Music Player"
   !endif
-  !ifdef arch_x64 || arch_arm64
+  !ifdef arch_x64
     !define PRODUCT_INSTALL_DIR "$PROGRAMFILES64\Strawberry Music Player"
   !endif
 !endif
@@ -224,7 +214,7 @@ Function InstallMSVCRuntime
   ; ${If} $R0 == ""
     SetDetailsView hide
     ; inetc::get /caption "Downloading..." "https://aka.ms/vs/17/release/${vc_redist_file}" "$TEMP\${vc_redist_file}" /end
-    ExecWait '"$TEMP\${vc_redist_file}" /install /passive /norestart'
+    ExecWait '"$TEMP\${vc_redist_file}" /install /passive'
     Delete "$TEMP\${vc_redist_file}"
     SetDetailsView show
   ; ${EndIf}
@@ -334,7 +324,7 @@ Section "Strawberry" Strawberry
   File "libqtsparkle-qt6.dll"
   File "libsoup-3.0-0.dll"
   File "libspeex-1.dll"
-  File "libsqlite3-0.dll"
+  File "libsqlite3.dll"
   File "libssp-0.dll"
   File "libstdc++-6.dll"
   File "libtag.dll"
@@ -377,10 +367,6 @@ Section "Strawberry" Strawberry
   File "libcrypto-3-x64.dll"
   File "libssl-3-x64.dll"
 !endif
-!ifdef arch_arm64
-  File "libcrypto-3-arm64.dll"
-  File "libssl-3-arm64.dll"
-!endif
 
   File "FLAC.dll"
   File "brotlicommon.dll"
@@ -395,6 +381,7 @@ Section "Strawberry" Strawberry
   File "glib-2.0-0.dll"
   File "gme.dll"
   File "gmodule-2.0-0.dll"
+  File "gnutls.dll"
   File "gobject-2.0-0.dll"
   File "gstadaptivedemux-1.0-0.dll"
   File "gstapp-1.0-0.dll"
@@ -415,11 +402,14 @@ Section "Strawberry" Strawberry
   File "gsttag-1.0-0.dll"
   File "gsturidownloader-1.0-0.dll"
   File "gstvideo-1.0-0.dll"
+  File "gstwinrt-1.0-0.dll"
   File "harfbuzz.dll"
   File "intl-8.dll"
   File "jpeg62.dll"
   File "kdsingleapplication-qt6.dll"
   File "libbs2b.dll"
+  File "libfaac_dll.dll"
+  File "liblzma.dll"
   File "libmp3lame.dll"
   File "libopenmpt.dll"
   File "mpcdec.dll"
@@ -437,11 +427,6 @@ Section "Strawberry" Strawberry
   File "vorbisfile.dll"
   File "wavpackdll.dll"
 
-!ifndef arch_arm64
-  File "gnutls.dll"
-  File "libfaac_dll.dll"
-!endif
-
 !ifdef release
   File "freetype.dll"
   File "libiconv.dll"
@@ -449,10 +434,8 @@ Section "Strawberry" Strawberry
   File "libspeex.dll"
   File "pcre2-8.dll"
   File "pcre2-16.dll"
-  File "zlib1.dll"
-!ifndef arch_arm64
   File "twolame.dll"
-!endif
+  File "zlib.dll"
 !endif
 !ifdef debug
   File "freetyped.dll"
@@ -461,10 +444,8 @@ Section "Strawberry" Strawberry
   File "libspeexd.dll"
   File "pcre2-8d.dll"
   File "pcre2-16d.dll"
-  File "zlibd1.dll"
-!ifndef arch_arm64
   File "twolamed.dll"
-!endif
+  File "zlibd.dll"
 !endif
 
   ; Used by libfftw3-3.dll because fftw is compiled with MinGW.
@@ -477,15 +458,11 @@ Section "Strawberry" Strawberry
 
   ; Common files
 
-  File "icudt78.dll"
+  File "icudt77.dll"
-!ifdef msvc && arch_arm64
-  File "fftw3.dll"
-!else
   File "libfftw3-3.dll"
-!endif
 !ifdef msvc && debug
-  File "icuin78d.dll"
+  File "icuin77d.dll"
-  File "icuuc78d.dll"
+  File "icuuc77d.dll"
   File "libxml2d.dll"
   File "Qt6Concurrentd.dll"
   File "Qt6Cored.dll"
@@ -494,8 +471,8 @@ Section "Strawberry" Strawberry
   File "Qt6Sqld.dll"
   File "Qt6Widgetsd.dll"
 !else
-  File "icuin78.dll"
+  File "icuin77.dll"
-  File "icuuc78.dll"
+  File "icuuc77.dll"
   File "libxml2.dll"
   File "Qt6Concurrent.dll"
   File "Qt6Core.dll"
@@ -505,7 +482,6 @@ Section "Strawberry" Strawberry
   File "Qt6Widgets.dll"
 !endif
 
-!ifdef msvc && arch_x86
   File "avcodec-61.dll"
   File "avfilter-10.dll"
   File "avformat-61.dll"
@@ -513,14 +489,6 @@ Section "Strawberry" Strawberry
   File "postproc-58.dll"
   File "swresample-5.dll"
   File "swscale-8.dll"
-!else
-  File "avcodec-62.dll"
-  File "avfilter-11.dll"
-  File "avformat-62.dll"
-  File "avutil-60.dll"
-  File "swresample-6.dll"
-  File "swscale-9.dll"
-!endif
 
   ; Register Strawberry with Default Programs
   Var /GLOBAL AppIcon
@@ -558,13 +526,11 @@ Section "GIO modules" gio-modules
   SetOutPath "$INSTDIR\gio-modules"
 !ifdef mingw
   File "/oname=libgiognutls.dll" "gio-modules\libgiognutls.dll"
+  File "/oname=libgioopenssl.dll" "gio-modules\libgioopenssl.dll"
 !endif
 !ifdef msvc
-!ifdef arch_arm64
-  File "/oname=gioopenssl.dll" "gio-modules\gioopenssl.dll"
-!else
   File "/oname=giognutls.dll" "gio-modules\giognutls.dll"
-!endif
+  File "/oname=gioopenssl.dll" "gio-modules\gioopenssl.dll"
 !endif
 SectionEnd
 
@@ -681,7 +647,6 @@ Section "Gstreamer plugins" gstreamer-plugins
   File "/oname=libgstvolume.dll" "gstreamer-plugins\libgstvolume.dll"
   File "/oname=libgstvorbis.dll" "gstreamer-plugins\libgstvorbis.dll"
   File "/oname=libgstwasapi.dll" "gstreamer-plugins\libgstwasapi.dll"
-  File "/oname=libgstwasapi2.dll" "gstreamer-plugins\libgstwasapi2.dll"
   File "/oname=libgstwaveform.dll" "gstreamer-plugins\libgstwaveform.dll"
   File "/oname=libgstwavenc.dll" "gstreamer-plugins\libgstwavenc.dll"
   File "/oname=libgstwavpack.dll" "gstreamer-plugins\libgstwavpack.dll"
@@ -709,6 +674,7 @@ Section "Gstreamer plugins" gstreamer-plugins
   File "/oname=gstdirectsound.dll" "gstreamer-plugins\gstdirectsound.dll"
   File "/oname=gstdsd.dll" "gstreamer-plugins\gstdsd.dll"
   File "/oname=gstequalizer.dll" "gstreamer-plugins\gstequalizer.dll"
+  File "/oname=gstfaac.dll" "gstreamer-plugins\gstfaac.dll"
   File "/oname=gstfaad.dll" "gstreamer-plugins\gstfaad.dll"
   File "/oname=gstfdkaac.dll" "gstreamer-plugins\gstfdkaac.dll"
   File "/oname=gstflac.dll" "gstreamer-plugins\gstflac.dll"
@@ -741,6 +707,7 @@ Section "Gstreamer plugins" gstreamer-plugins
   File "/oname=gstspeex.dll" "gstreamer-plugins\gstspeex.dll"
   File "/oname=gsttaglib.dll" "gstreamer-plugins\gsttaglib.dll"
   File "/oname=gsttcp.dll" "gstreamer-plugins\gsttcp.dll"
+  File "/oname=gsttwolame.dll" "gstreamer-plugins\gsttwolame.dll"
   File "/oname=gsttypefindfunctions.dll" "gstreamer-plugins\gsttypefindfunctions.dll"
   File "/oname=gstudp.dll" "gstreamer-plugins\gstudp.dll"
   File "/oname=gstvolume.dll" "gstreamer-plugins\gstvolume.dll"
@@ -752,12 +719,8 @@ Section "Gstreamer plugins" gstreamer-plugins
   File "/oname=gstwavpack.dll" "gstreamer-plugins\gstwavpack.dll"
   File "/oname=gstwavparse.dll" "gstreamer-plugins\gstwavparse.dll"
   File "/oname=gstxingmux.dll" "gstreamer-plugins\gstxingmux.dll"
-!ifndef arch_arm64
-  File "/oname=gstfaac.dll" "gstreamer-plugins\gstfaac.dll"
-  File "/oname=gsttwolame.dll" "gstreamer-plugins\gsttwolame.dll"
-!endif
 !ifdef arch_x64
-  File "/oname=gstspotify.dll" "gstreamer-plugins\gstspotify.dll"
+  ;File "/oname=gstspotify.dll" "gstreamer-plugins\gstspotify.dll"
 !endif
 !endif ; MSVC
 
@@ -886,7 +849,7 @@ Section "Uninstall"
   Delete "$INSTDIR\libqtsparkle-qt6.dll"
   Delete "$INSTDIR\libsoup-3.0-0.dll"
   Delete "$INSTDIR\libspeex-1.dll"
-  Delete "$INSTDIR\libsqlite3-0.dll"
+  Delete "$INSTDIR\libsqlite3.dll"
   Delete "$INSTDIR\libssp-0.dll"
   Delete "$INSTDIR\libstdc++-6.dll"
   Delete "$INSTDIR\libtag.dll"
@@ -929,10 +892,6 @@ Section "Uninstall"
   Delete "$INSTDIR\libcrypto-3-x64.dll"
   Delete "$INSTDIR\libssl-3-x64.dll"
 !endif
-!ifdef arch_arm64
-  Delete "$INSTDIR\libcrypto-3-arm64.dll"
-  Delete "$INSTDIR\libssl-3-arm64.dll"
-!endif
 
   Delete "$INSTDIR\FLAC.dll"
   Delete "$INSTDIR\brotlicommon.dll"
@@ -947,6 +906,7 @@ Section "Uninstall"
   Delete "$INSTDIR\glib-2.0-0.dll"
   Delete "$INSTDIR\gme.dll"
   Delete "$INSTDIR\gmodule-2.0-0.dll"
+  Delete "$INSTDIR\gnutls.dll"
   Delete "$INSTDIR\gobject-2.0-0.dll"
   Delete "$INSTDIR\gstadaptivedemux-1.0-0.dll"
   Delete "$INSTDIR\gstapp-1.0-0.dll"
@@ -967,11 +927,14 @@ Section "Uninstall"
   Delete "$INSTDIR\gsttag-1.0-0.dll"
   Delete "$INSTDIR\gsturidownloader-1.0-0.dll"
   Delete "$INSTDIR\gstvideo-1.0-0.dll"
+  Delete "$INSTDIR\gstwinrt-1.0-0.dll"
   Delete "$INSTDIR\harfbuzz.dll"
   Delete "$INSTDIR\intl-8.dll"
   Delete "$INSTDIR\jpeg62.dll"
   Delete "$INSTDIR\kdsingleapplication-qt6.dll"
   Delete "$INSTDIR\libbs2b.dll"
+  Delete "$INSTDIR\libfaac_dll.dll"
+  Delete "$INSTDIR\liblzma.dll"
   Delete "$INSTDIR\libmp3lame.dll"
   Delete "$INSTDIR\libopenmpt.dll"
   Delete "$INSTDIR\mpcdec.dll"
@@ -989,11 +952,6 @@ Section "Uninstall"
   Delete "$INSTDIR\vorbisfile.dll"
   Delete "$INSTDIR\wavpackdll.dll"
 
-!ifndef arch_arm64
-  Delete "$INSTDIR\gnutls.dll"
-  Delete "$INSTDIR\libfaac_dll.dll"
-!endif
-
 !ifdef release
   Delete "$INSTDIR\freetype.dll"
   Delete "$INSTDIR\libiconv.dll"
@@ -1001,10 +959,8 @@ Section "Uninstall"
   Delete "$INSTDIR\libspeex.dll"
   Delete "$INSTDIR\pcre2-8.dll"
   Delete "$INSTDIR\pcre2-16.dll"
-  Delete "$INSTDIR\zlib1.dll"
-!ifndef arch_arm64
   Delete "$INSTDIR\twolame.dll"
-!endif
+  Delete "$INSTDIR\zlib.dll"
 !endif
 !ifdef debug
   Delete "$INSTDIR\freetyped.dll"
@@ -1013,10 +969,8 @@ Section "Uninstall"
   Delete "$INSTDIR\libspeexd.dll"
   Delete "$INSTDIR\pcre2-8d.dll"
   Delete "$INSTDIR\pcre2-16d.dll"
-  Delete "$INSTDIR\zlibd1.dll"
-!ifndef arch_arm64
   Delete "$INSTDIR\twolamed.dll"
-!endif
+  Delete "$INSTDIR\zlibd.dll"
 !endif
 
 !ifdef arch_x86
@@ -1028,15 +982,11 @@ Section "Uninstall"
 
   ; Common files
 
-  Delete "$INSTDIR\icudt78.dll"
+  Delete "$INSTDIR\icudt77.dll"
-!ifdef msvc && arch_arm64
-  Delete "$INSTDIR\fftw3.dll"
-!else
   Delete "$INSTDIR\libfftw3-3.dll"
-!endif
 !ifdef msvc && debug
-  Delete "$INSTDIR\icuin78d.dll"
+  Delete "$INSTDIR\icuin77d.dll"
-  Delete "$INSTDIR\icuuc78d.dll"
+  Delete "$INSTDIR\icuuc77d.dll"
   Delete "$INSTDIR\libxml2d.dll"
   Delete "$INSTDIR\Qt6Concurrentd.dll"
   Delete "$INSTDIR\Qt6Cored.dll"
@@ -1045,8 +995,8 @@ Section "Uninstall"
   Delete "$INSTDIR\Qt6Sqld.dll"
   Delete "$INSTDIR\Qt6Widgetsd.dll"
 !else
-  Delete "$INSTDIR\icuin78.dll"
+  Delete "$INSTDIR\icuin77.dll"
-  Delete "$INSTDIR\icuuc78.dll"
+  Delete "$INSTDIR\icuuc77.dll"
   Delete "$INSTDIR\libxml2.dll"
   Delete "$INSTDIR\Qt6Concurrent.dll"
   Delete "$INSTDIR\Qt6Core.dll"
@@ -1056,7 +1006,6 @@ Section "Uninstall"
   Delete "$INSTDIR\Qt6Widgets.dll"
 !endif
 
-!ifdef msvc && arch_x86
   Delete "$INSTDIR\avcodec-61.dll"
   Delete "$INSTDIR\avfilter-10.dll"
   Delete "$INSTDIR\avformat-61.dll"
@@ -1064,24 +1013,14 @@ Section "Uninstall"
   Delete "$INSTDIR\postproc-58.dll"
   Delete "$INSTDIR\swresample-5.dll"
   Delete "$INSTDIR\swscale-8.dll"
-!else
-  Delete "$INSTDIR\avcodec-62.dll"
-  Delete "$INSTDIR\avfilter-11.dll"
-  Delete "$INSTDIR\avformat-62.dll"
-  Delete "$INSTDIR\avutil-60.dll"
-  Delete "$INSTDIR\swresample-6.dll"
-  Delete "$INSTDIR\swscale-9.dll"
-!endif
 
 !ifdef mingw
   Delete "$INSTDIR\gio-modules\libgiognutls.dll"
+  Delete "$INSTDIR\gio-modules\libgioopenssl.dll"
 !endif
 !ifdef msvc
-!ifdef arch_arm64
-  Delete "$INSTDIR\gio-modules\gioopenssl.dll"
-!else
   Delete "$INSTDIR\gio-modules\giognutls.dll"
-!endif
+  Delete "$INSTDIR\gio-modules\gioopenssl.dll"
 !endif
 
 !ifdef msvc && debug
@@ -1165,7 +1104,6 @@ Section "Uninstall"
   Delete "$INSTDIR\gstreamer-plugins\libgstvolume.dll"
   Delete "$INSTDIR\gstreamer-plugins\libgstvorbis.dll"
   Delete "$INSTDIR\gstreamer-plugins\libgstwasapi.dll"
-  Delete "$INSTDIR\gstreamer-plugins\libgstwasapi2.dll"
   Delete "$INSTDIR\gstreamer-plugins\libgstwaveform.dll"
   Delete "$INSTDIR\gstreamer-plugins\libgstwavenc.dll"
   Delete "$INSTDIR\gstreamer-plugins\libgstwavpack.dll"
@@ -1195,6 +1133,7 @@ Section "Uninstall"
   Delete "$INSTDIR\gstreamer-plugins\gstdirectsound.dll"
   Delete "$INSTDIR\gstreamer-plugins\gstdsd.dll"
   Delete "$INSTDIR\gstreamer-plugins\gstequalizer.dll"
+  Delete "$INSTDIR\gstreamer-plugins\gstfaac.dll"
   Delete "$INSTDIR\gstreamer-plugins\gstfaad.dll"
   Delete "$INSTDIR\gstreamer-plugins\gstfdkaac.dll"
   Delete "$INSTDIR\gstreamer-plugins\gstflac.dll"
@@ -1227,6 +1166,7 @@ Section "Uninstall"
   Delete "$INSTDIR\gstreamer-plugins\gstspeex.dll"
   Delete "$INSTDIR\gstreamer-plugins\gsttaglib.dll"
   Delete "$INSTDIR\gstreamer-plugins\gsttcp.dll"
+  Delete "$INSTDIR\gstreamer-plugins\gsttwolame.dll"
   Delete "$INSTDIR\gstreamer-plugins\gsttypefindfunctions.dll"
   Delete "$INSTDIR\gstreamer-plugins\gstudp.dll"
   Delete "$INSTDIR\gstreamer-plugins\gstvolume.dll"
@@ -1238,14 +1178,9 @@ Section "Uninstall"
   Delete "$INSTDIR\gstreamer-plugins\gstwavpack.dll"
   Delete "$INSTDIR\gstreamer-plugins\gstwavparse.dll"
   Delete "$INSTDIR\gstreamer-plugins\gstxingmux.dll"
-!ifndef arch_arm64
+!ifdef arch_x64
-  Delete "$INSTDIR\gstreamer-plugins\gstfaac.dll"
+  ;Delete "$INSTDIR\gstreamer-plugins\gstspotify.dll"
-  Delete "$INSTDIR\gstreamer-plugins\gsttwolame.dll"
 !endif
-  !ifdef arch_x64
-  Delete "$INSTDIR\gstreamer-plugins\gstspotify.dll"
-!endif
-
 !endif ; msvc
 
   Delete "$INSTDIR\Uninstall.exe"

src/analyzer/analyzerbase.cpp

@@ -18,7 +18,7 @@
 
    You should have received a copy of the GNU General Public License
    along with Strawberry.  If not, see <http://www.gnu.org/licenses/>.
- */
+*/
 
 #include "config.h"
 

src/analyzer/analyzerbase.h

@@ -18,7 +18,7 @@
 
    You should have received a copy of the GNU General Public License
    along with Strawberry.  If not, see <http://www.gnu.org/licenses/>.
- */
+*/
 
 #ifndef ANALYZERBASE_H
 #define ANALYZERBASE_H
@@ -90,3 +90,4 @@ class AnalyzerBase : public QWidget {
 };
 
 #endif  // ANALYZERBASE_H
+

src/analyzer/analyzercontainer.cpp

@@ -15,7 +15,7 @@
 
    You should have received a copy of the GNU General Public License
    along with Strawberry.  If not, see <http://www.gnu.org/licenses/>.
- */
+*/
 
 #include "config.h"
 
@@ -61,7 +61,7 @@ constexpr int kLowFramerate = 20;
 constexpr int kMediumFramerate = 25;
 constexpr int kHighFramerate = 30;
 constexpr int kSuperHighFramerate = 60;
-}  // namespace
+} // namespace
 
 AnalyzerContainer::AnalyzerContainer(QWidget *parent)
     : QWidget(parent),

src/analyzer/analyzercontainer.h

@@ -15,7 +15,7 @@
 
    You should have received a copy of the GNU General Public License
    along with Strawberry.  If not, see <http://www.gnu.org/licenses/>.
- */
+*/
 
 #ifndef ANALYZERCONTAINER_H
 #define ANALYZERCONTAINER_H
@@ -101,7 +101,8 @@ void AnalyzerContainer::AddAnalyzerType() {
   group_->addAction(action);
   action->setCheckable(true);
   actions_ << action;
-  QObject::connect(action, &QAction::triggered, [this, id]() { ChangeAnalyzer(id); });
+  QObject::connect(action, &QAction::triggered, [this, id]() { ChangeAnalyzer(id); } );
+
 }
 
 #endif  // ANALYZERCONTAINER_H

src/analyzer/blockanalyzer.cpp

@@ -19,7 +19,7 @@
    You should have received a copy of the GNU General Public License
    along with Strawberry.  If not, see <http://www.gnu.org/licenses/>.
 
- */
+*/
 
 #include "blockanalyzer.h"
 
@@ -61,12 +61,11 @@ BlockAnalyzer::BlockAnalyzer(QWidget *parent)
       fade_intensity_(1 << 8, 32),
       step_(0) {
 
-  setMinimumSize(kMinColumns * (kWidth + 1) - 1, kMinRows * (kHeight + 1) - 1);  // -1 is padding, no drawing takes place there
+  setMinimumSize(kMinColumns * (kWidth + 1) - 1, kMinRows * (kHeight + 1) - 1);  //-1 is padding, no drawing takes place there
   setMaximumWidth(kMaxColumns * (kWidth + 1) - 1);
 
   // mxcl says null pixmaps cause crashes, so let's play it safe
   std::fill(fade_bars_.begin(), fade_bars_.end(), QPixmap(1, 1));
-
 }
 
 void BlockAnalyzer::resizeEvent(QResizeEvent *e) {
@@ -238,7 +237,7 @@ static inline void adjustToLimits(const int b, int &f, int &amount) {
  * Clever contrast function
  *
  * It will try to adjust the foreground color such that it contrasts well with
- * the background
+ *the background
  * It won't modify the hue of fg unless absolutely necessary
  * @return the adjusted form of fg
  */

src/analyzer/blockanalyzer.h

@@ -19,7 +19,7 @@
    You should have received a copy of the GNU General Public License
    along with Strawberry.  If not, see <http://www.gnu.org/licenses/>.
 
- */
+*/
 
 #ifndef BLOCKANALYZER_H
 #define BLOCKANALYZER_H
@@ -41,14 +41,14 @@ class BlockAnalyzer : public AnalyzerBase {
   Q_OBJECT
 
  public:
-  Q_INVOKABLE explicit BlockAnalyzer(QWidget *parent);
+  Q_INVOKABLE explicit BlockAnalyzer(QWidget*);
 
   static const char *kName;
 
  protected:
-  void transform(Scope &s) override;
+  void transform(Scope&) override;
   void analyze(QPainter &p, const Scope &s, const bool new_frame) override;
-  void resizeEvent(QResizeEvent *e) override;
+  void resizeEvent(QResizeEvent*) override;
   virtual void paletteChange(const QPalette &_palette);
   void framerateChanged() override;
 

src/analyzer/boomanalyzer.cpp

@@ -20,7 +20,7 @@
    You should have received a copy of the GNU General Public License
    along with Strawberry.  If not, see <http://www.gnu.org/licenses/>.
 
- */
+*/
 
 #include "boomanalyzer.h"
 
@@ -143,7 +143,7 @@ void BoomAnalyzer::analyze(QPainter &p, const Scope &scope, const bool new_frame
         bar_height_[i] = std::max(0.0, bar_height_[i]);
       }
 
-      peak_handling:
+    peak_handling:
 
       if (peak_height_[i] > 0.0) {
         peak_height_[i] -= peak_speed_[i];

src/analyzer/boomanalyzer.h

@@ -20,7 +20,7 @@
    You should have received a copy of the GNU General Public License
    along with Strawberry.  If not, see <http://www.gnu.org/licenses/>.
 
- */
+*/
 
 #ifndef BOOMANALYZER_H
 #define BOOMANALYZER_H
@@ -40,7 +40,7 @@ class BoomAnalyzer : public AnalyzerBase {
   Q_OBJECT
 
  public:
-  Q_INVOKABLE explicit BoomAnalyzer(QWidget *parent);
+  Q_INVOKABLE explicit BoomAnalyzer(QWidget*);
 
   static const char *kName;
 
@@ -70,6 +70,7 @@ class BoomAnalyzer : public AnalyzerBase {
 
   QPixmap barPixmap_;
   QPixmap canvas_;
+
 };
 
 #endif  // BOOMANALYZER_H

src/analyzer/fht.cpp

@@ -18,7 +18,7 @@
 
    You should have received a copy of the GNU General Public License
    along with Strawberry.  If not, see <http://www.gnu.org/licenses/>.
- */
+*/
 
 #include "fht.h"
 

src/analyzer/fht.h

@@ -18,7 +18,7 @@
 
    You should have received a copy of the GNU General Public License
    along with Strawberry.  If not, see <http://www.gnu.org/licenses/>.
- */
+*/
 
 #ifndef FHT_H
 #define FHT_H
@@ -55,20 +55,20 @@ class FHT {
   /**
    * Recursive in-place Hartley transform. For internal use only!
    */
-  void _transform(float *p, int n, int k);
+  void _transform(float*, int, int);
 
  public:
   /**
-   * Prepare transform for data sets with @f$2^n@f$ numbers, whereby @f$n@f$
+  * Prepare transform for data sets with @f$2^n@f$ numbers, whereby @f$n@f$
-   * should be at least 3. Values of more than 3 need a trigonometry table.
+  * should be at least 3. Values of more than 3 need a trigonometry table.
-   * @see makeCasTable()
+  * @see makeCasTable()
-   */
+  */
   explicit FHT(uint);
 
   ~FHT();
   int sizeExp() const;
   int size() const;
-  void scale(float *p, float d) const;
+  void scale(float*, float) const;
 
   /**
    * Exponentially Weighted Moving Average (EWMA) filter.
@@ -90,12 +90,12 @@ class FHT {
   /**
    * Semi-logarithmic audio spectrum.
    */
-  void semiLogSpectrum(float *p);
+  void semiLogSpectrum(float*);
 
   /**
    * Fourier spectrum.
    */
-  void spectrum(float *p);
+  void spectrum(float*);
 
   /**
    * Calculates a mathematically correct FFT power spectrum.
@@ -103,7 +103,7 @@ class FHT {
    * and factor the 0.5 in the final scaling factor.
    * @see FHT::power2()
    */
-  void power(float *p);
+  void power(float*);
 
   /**
    * Calculates an FFT power spectrum with doubled values as a
@@ -112,14 +112,14 @@ class FHT {
    * of @f$2^n@f$ input values. This is the fastest transform.
    * @see FHT::power()
    */
-  void power2(float *p);
+  void power2(float*);
 
   /**
    * Discrete Hartley transform of data sets with 8 values.
    */
-  static void transform8(float *p);
+  static void transform8(float*);
 
-  void transform(float *p);
+  void transform(float*);
 };
 
 #endif  // FHT_H

src/analyzer/rainbowanalyzer.cpp

@@ -21,7 +21,7 @@
 
    You should have received a copy of the GNU General Public License
    along with Strawberry.  If not, see <http://www.gnu.org/licenses/>.
- */
+*/
 
 #include "rainbowanalyzer.h"
 

src/analyzer/rainbowanalyzer.h

@@ -21,7 +21,7 @@
 
    You should have received a copy of the GNU General Public License
    along with Strawberry.  If not, see <http://www.gnu.org/licenses/>.
- */
+*/
 
 #ifndef RAINBOWANALYZER_H
 #define RAINBOWANALYZER_H
@@ -85,7 +85,7 @@ class RainbowAnalyzer : public AnalyzerBase {
 
  private:
   // "constants" that get initialized in the constructor
-  float band_scale_[kRainbowBands]{};
+  float band_scale_[kRainbowBands] {};
   QPen colors_[kRainbowBands];
 
   // Rainbow Nyancat & Dash
@@ -96,7 +96,7 @@ class RainbowAnalyzer : public AnalyzerBase {
   int frame_;
 
   // The y positions of each point on the rainbow.
-  float history_[kHistorySize * kRainbowBands]{};
+  float history_[kHistorySize * kRainbowBands] {};
 
   // A cache of the last frame's rainbow,
   // so it can be used in the next frame.

src/analyzer/sonogramanalyzer.h

@@ -19,7 +19,7 @@
 
    You should have received a copy of the GNU General Public License
    along with Strawberry.  If not, see <http://www.gnu.org/licenses/>.
- */
+*/
 
 #ifndef SONOGRAMANALYZER_H
 #define SONOGRAMANALYZER_H

src/analyzer/turbineanalyzer.cpp

@@ -20,7 +20,7 @@
 
    You should have received a copy of the GNU General Public License
    along with Clementine.  If not, see <http://www.gnu.org/licenses/>.
- */
+*/
 
 #include "config.h"
 
@@ -70,7 +70,7 @@ void TurbineAnalyzer::analyze(QPainter &p, const Scope &scope, const bool new_fr
         bar_height_[i] = std::max(0.0, bar_height_[i]);
       }
 
-      peak_handling:
+    peak_handling:
       if (peak_height_[i] > 0.0) {
         peak_height_[i] -= peak_speed_[i];
         peak_speed_[i] *= F_peakSpeed_;  // 1.12

src/analyzer/turbineanalyzer.h

@@ -18,7 +18,7 @@
 
    You should have received a copy of the GNU General Public License
    along with Clementine.  If not, see <http://www.gnu.org/licenses/>.
- */
+*/
 
 #ifndef TURBINEANALYZER_H
 #define TURBINEANALYZER_H

src/analyzer/waverubberanalyzer.h

@@ -14,7 +14,7 @@
 
    You should have received a copy of the GNU General Public License
    along with Strawberry.  If not, see <http://www.gnu.org/licenses/>.
- */
+*/
 
 
 #include <QPixmap>

src/collection/collectionbackend.cpp

@@ -623,7 +623,6 @@ void CollectionBackend::AddOrUpdateSongs(const SongList &songs) {
   QMutexLocker l(db_->Mutex());
   QSqlDatabase db(db_->Connect());
 
-  CollectionTask task(task_manager_, tr("Updating %1 database.").arg(Song::TextForSource(source_)));
   ScopedTransaction transaction(&db);
 
   SongList added_songs;

src/collection/collectionbackend.h

@@ -140,6 +140,7 @@ class CollectionBackend : public CollectionBackendInterface {
   Q_OBJECT
 
  public:
+
   Q_INVOKABLE explicit CollectionBackend(QObject *parent = nullptr);
 
   ~CollectionBackend();
@@ -330,3 +331,4 @@ class CollectionBackend : public CollectionBackendInterface {
 };
 
 #endif  // COLLECTIONBACKEND_H
+

src/collection/collectionfilteroptions.h

@@ -26,6 +26,7 @@
 
 class CollectionFilterOptions {
  public:
+
   explicit CollectionFilterOptions();
 
   // Filter mode:

src/collection/collectionfilterwidget.cpp

@@ -34,7 +34,6 @@
 #include <QVariant>
 #include <QString>
 #include <QStringList>
-#include <QUrl>
 #include <QRegularExpression>
 #include <QInputDialog>
 #include <QList>
@@ -296,21 +295,19 @@ QActionGroup *CollectionFilterWidget::CreateGroupByActions(const QString &saved_
   if (version == 1) {
     QStringList saved = s.childKeys();
     for (int i = 0; i < saved.size(); ++i) {
-      const QString &name = saved.at(i);
+      if (saved.at(i) == "version"_L1) continue;
-      if (name == "version"_L1) continue;
+      QByteArray bytes = s.value(saved.at(i)).toByteArray();
-      QByteArray bytes = s.value(name).toByteArray();
       QDataStream ds(&bytes, QIODevice::ReadOnly);
       CollectionModel::Grouping g;
       ds >> g;
-      ret->addAction(CreateGroupByAction(QUrl::fromPercentEncoding(name.toUtf8()), parent, g));
+      ret->addAction(CreateGroupByAction(saved.at(i), parent, g));
     }
   }
   else {
     QStringList saved = s.childKeys();
     for (int i = 0; i < saved.size(); ++i) {
-      const QString &name = saved.at(i);
+      if (saved.at(i) == "version"_L1) continue;
-      if (name == "version"_L1) continue;
+      s.remove(saved.at(i));
-      s.remove(name);
     }
   }
   s.endGroup();
@@ -342,7 +339,7 @@ void CollectionFilterWidget::SaveGroupBy() {
 
   if (!model_) return;
 
-  const QString name = QInputDialog::getText(this, tr("Grouping Name"), tr("Grouping name:"));
+  QString name = QInputDialog::getText(this, tr("Grouping Name"), tr("Grouping name:"));
   if (name.isEmpty()) return;
 
   qLog(Debug) << "Saving current grouping to" << name;
@@ -358,7 +355,7 @@ void CollectionFilterWidget::SaveGroupBy() {
   QDataStream datastream(&buffer, QIODevice::WriteOnly);
   datastream << model_->GetGroupBy();
   s.setValue("version", u"1"_s);
-  s.setValue(QUrl::toPercentEncoding(name), buffer);
+  s.setValue(name, buffer);
   s.endGroup();
 
   UpdateGroupByActions();

src/collection/collectionfilterwidget.h

@@ -135,3 +135,4 @@ class CollectionFilterWidget : public QWidget {
 };
 
 #endif  // COLLECTIONFILTERWIDGET_H
+

src/collection/collectionlibrary.cpp

@@ -2,7 +2,7 @@
  * Strawberry Music Player
  * This file was part of Clementine.
  * Copyright 2010, David Sansome <me@davidsansome.com>
- * Copyright 2018-2025, Jonas Kvinge <jonas@jkvinge.net>
+ * Copyright 2018-2021, Jonas Kvinge <jonas@jkvinge.net>
  *
  * Strawberry is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by
@@ -78,8 +78,6 @@ CollectionLibrary::CollectionLibrary(const SharedPtr<Database> database,
 
   model_ = new CollectionModel(backend_, albumcover_loader, this);
 
-  full_rescan_revisions_[21] = tr("Support for sort tags artist, album, album artist, title, composer, and performer");
-
   ReloadSettings();
 
 }
@@ -189,26 +187,6 @@ void CollectionLibrary::ReloadSettings() {
 
 }
 
-void CollectionLibrary::CurrentSongChanged(const Song &song) {
-
-  current_song_url_ = song.url();
-
-  if (!pending_song_saves_.isEmpty()) {
-    SavePendingPlaycountsAndRatings();
-  }
-
-}
-
-void CollectionLibrary::Stopped() {
-
-  current_song_url_ = QUrl();
-
-  if (!pending_song_saves_.isEmpty()) {
-    SavePendingPlaycountsAndRatings();
-  }
-
-}
-
 void CollectionLibrary::SyncPlaycountAndRatingToFilesAsync() {
 
   (void)QtConcurrent::run(&CollectionLibrary::SyncPlaycountAndRatingToFiles, this);
@@ -232,85 +210,18 @@ void CollectionLibrary::SyncPlaycountAndRatingToFiles() {
 
 }
 
-void CollectionLibrary::SongsPlaycountChanged(const SongList &songs, const bool save_tags) {
+void CollectionLibrary::SongsPlaycountChanged(const SongList &songs, const bool save_tags) const {
 
   if (save_tags || save_playcounts_to_files_) {
-    SongList songs_to_save_now;
+    tagreader_client_->SaveSongsPlaycountAsync(songs);
-    for (const Song &song : songs) {
-      if (song.url().isLocalFile() && song.url() == current_song_url_ &&
-          (song.filetype() == Song::FileType::OggFlac || song.filetype() == Song::FileType::OggVorbis || song.filetype() == Song::FileType::OggOpus)) {
-        qLog(Debug) << "Deferring playcount save for currently playing file" << song.url().toLocalFile();
-        if (pending_song_saves_.contains(song.url())) {
-          SharedPtr<PendingSongSave> pending_song_save = pending_song_saves_[song.url()];
-          pending_song_save->save_playcount = true;
-          pending_song_save->song.set_playcount(song.playcount());
-        }
-        else {
-          SharedPtr<PendingSongSave> pending_song_save = make_shared<PendingSongSave>();
-          pending_song_save->save_playcount = true;
-          pending_song_save->song = song;
-          pending_song_saves_.insert(song.url(), pending_song_save);
-        }
-      }
-      else {
-        songs_to_save_now << song;
-      }
-    }
-    if (!songs_to_save_now.isEmpty()) {
-      tagreader_client_->SaveSongsPlaycountAsync(songs_to_save_now);
-    }
   }
 
 }
 
-void CollectionLibrary::SongsRatingChanged(const SongList &songs, const bool save_tags) {
+void CollectionLibrary::SongsRatingChanged(const SongList &songs, const bool save_tags) const {
 
   if (save_tags || save_ratings_to_files_) {
-    SongList songs_to_save_now;
+    tagreader_client_->SaveSongsRatingAsync(songs);
-    for (const Song &song : songs) {
-      if (song.url().isLocalFile() && song.url() == current_song_url_ &&
-          (song.filetype() == Song::FileType::OggFlac || song.filetype() == Song::FileType::OggVorbis || song.filetype() == Song::FileType::OggOpus)) {
-        qLog(Debug) << "Deferring rating save for currently playing file" << song.url().toLocalFile();
-        if (pending_song_saves_.contains(song.url())) {
-          SharedPtr<PendingSongSave> pending_song_save = pending_song_saves_[song.url()];
-          pending_song_save->save_rating = true;
-          pending_song_save->song.set_rating(song.rating());
-        }
-        else {
-          SharedPtr<PendingSongSave> pending_song_save = make_shared<PendingSongSave>();
-          pending_song_save->save_rating = true;
-          pending_song_save->song = song;
-          pending_song_saves_.insert(song.url(), pending_song_save);
-        }
-      }
-      else {
-        songs_to_save_now << song;
-      }
-    }
-    if (!songs_to_save_now.isEmpty()) {
-      tagreader_client_->SaveSongsRatingAsync(songs_to_save_now);
-    }
-  }
-
-}
-
-void CollectionLibrary::SavePendingPlaycountsAndRatings() {
-
-  for (auto it = pending_song_saves_.constBegin(); it != pending_song_saves_.constEnd();) {
-    const QUrl url = it.key();
-    SharedPtr<PendingSongSave> pending_song_save = it.value();
-    if (url == current_song_url_) {
-      ++it;
-      continue;
-    }
-    qLog(Debug) << "Saving deferred playcount/rating for" << url.toLocalFile();
-    if (pending_song_save->save_playcount) {
-      tagreader_client_->SaveSongsPlaycountAsync(SongList() << pending_song_save->song);
-    }
-    if (pending_song_save->save_rating) {
-      tagreader_client_->SaveSongsRatingAsync(SongList() << pending_song_save->song);
-    }
-    it = pending_song_saves_.erase(it);
   }
 
 }

src/collection/collectionlibrary.h

@@ -2,7 +2,7 @@
  * Strawberry Music Player
  * This file was part of Clementine.
  * Copyright 2010, David Sansome <me@davidsansome.com>
- * Copyright 2018-2025, Jonas Kvinge <jonas@jkvinge.net>
+ * Copyright 2018-2021, Jonas Kvinge <jonas@jkvinge.net>
  *
  * Strawberry is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by
@@ -27,7 +27,6 @@
 #include <QObject>
 #include <QList>
 #include <QHash>
-#include <QMap>
 #include <QString>
 
 #include "includes/shared_ptr.h"
@@ -72,7 +71,6 @@ class CollectionLibrary : public QObject {
 
  private:
   void SyncPlaycountAndRatingToFiles();
-  void SavePendingPlaycountsAndRatings();
 
  public Q_SLOTS:
   void ReloadSettings();
@@ -86,26 +84,16 @@ class CollectionLibrary : public QObject {
 
   void IncrementalScan();
 
-  void CurrentSongChanged(const Song &song);
-  void Stopped();
-
  private Q_SLOTS:
   void ExitReceived();
-  void SongsPlaycountChanged(const SongList &songs, const bool save_tags = false);
+  void SongsPlaycountChanged(const SongList &songs, const bool save_tags = false) const;
-  void SongsRatingChanged(const SongList &songs, const bool save_tags = false);
+  void SongsRatingChanged(const SongList &songs, const bool save_tags = false) const;
 
  Q_SIGNALS:
   void Error(const QString &error);
   void ExitFinished();
 
  private:
-  class PendingSongSave {
-   public:
-    Song song;
-    bool save_playcount = false;
-    bool save_rating = false;
-  };
-
   const SharedPtr<TaskManager> task_manager_;
   const SharedPtr<TagReaderClient> tagreader_client_;
 
@@ -123,10 +111,6 @@ class CollectionLibrary : public QObject {
 
   bool save_playcounts_to_files_;
   bool save_ratings_to_files_;
-
-  QUrl current_song_url_;
-
-  QMap<QUrl, SharedPtr<PendingSongSave>> pending_song_saves_;
 };
 
 #endif

src/collection/collectionmodel.cpp

@@ -1,6 +1,6 @@
 /*
  * Strawberry Music Player
- * Copyright 2018-2025, Jonas Kvinge <jonas@jkvinge.net>
+ * Copyright 2018-2024, Jonas Kvinge <jonas@jkvinge.net>
  *
  * Strawberry is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by
@@ -54,7 +54,6 @@
 
 #include "includes/scoped_ptr.h"
 #include "includes/shared_ptr.h"
-#include "constants/collectionsettings.h"
 #include "core/logging.h"
 #include "core/standardpaths.h"
 #include "core/database.h"
@@ -72,12 +71,12 @@
 #include "covermanager/albumcoverloaderoptions.h"
 #include "covermanager/albumcoverloaderresult.h"
 #include "covermanager/albumcoverloader.h"
+#include "constants/collectionsettings.h"
 
 using namespace std::chrono_literals;
 using namespace Qt::Literals::StringLiterals;
 
 const int CollectionModel::kPrettyCoverSize = 32;
-
 namespace {
 constexpr char kPixmapDiskCacheDir[] = "pixmapcache";
 constexpr char kVariousArtists[] = QT_TR_NOOP("Various artists");
@@ -89,6 +88,7 @@ CollectionModel::CollectionModel(const SharedPtr<CollectionBackend> backend, con
       albumcover_loader_(albumcover_loader),
       dir_model_(new CollectionDirectoryModel(backend, this)),
       filter_(new CollectionFilter(this)),
+      timer_reload_(new QTimer(this)),
       timer_update_(new QTimer(this)),
       icon_artist_(IconLoader::Load(u"folder-sound"_s)),
       use_disk_cache_(false),
@@ -130,6 +130,10 @@ CollectionModel::CollectionModel(const SharedPtr<CollectionBackend> backend, con
   backend_->UpdateTotalArtistCountAsync();
   backend_->UpdateTotalAlbumCountAsync();
 
+  timer_reload_->setSingleShot(true);
+  timer_reload_->setInterval(300ms);
+  QObject::connect(timer_reload_, &QTimer::timeout, this, &CollectionModel::Reload);
+
   timer_update_->setSingleShot(false);
   timer_update_->setInterval(20ms);
   QObject::connect(timer_update_, &QTimer::timeout, this, &CollectionModel::ProcessUpdate);
@@ -187,9 +191,13 @@ void CollectionModel::EndReset() {
 
 }
 
-void CollectionModel::ResetInternal() {
+void CollectionModel::Reload() {
 
   loading_ = true;
+  if (timer_reload_->isActive()) {
+    timer_reload_->stop();
+  }
+  updates_.clear();
 
   options_active_ = options_current_;
 
@@ -203,16 +211,22 @@ void CollectionModel::ResetInternal() {
 
 }
 
+void CollectionModel::ScheduleReset() {
+
+  if (!timer_reload_->isActive()) {
+    timer_reload_->start();
+  }
+
+}
+
 void CollectionModel::ReloadSettings() {
 
   Settings settings;
   settings.beginGroup(CollectionSettings::kSettingsGroup);
   const bool show_pretty_covers = settings.value(CollectionSettings::kPrettyCovers, true).toBool();
-  const bool show_dividers = settings.value(CollectionSettings::kShowDividers, true).toBool();
+  const bool show_dividers= settings.value(CollectionSettings::kShowDividers, true).toBool();
   const bool show_various_artists = settings.value(CollectionSettings::kVariousArtists, true).toBool();
-  const bool sort_skip_articles_for_artists = settings.value(CollectionSettings::kSkipArticlesForArtists, true).toBool();
+  const bool sort_skips_articles = settings.value(CollectionSettings::kSortSkipsArticles, true).toBool();
-  const bool sort_skip_articles_for_albums = settings.value(CollectionSettings::kSkipArticlesForAlbums, false).toBool();
-  const bool use_sort_tags = settings.value(CollectionSettings::kUseSortTags, true).toBool();
 
   use_disk_cache_ = settings.value(CollectionSettings::kSettingsDiskCacheEnable, false).toBool();
   QPixmapCache::setCacheLimit(static_cast<int>(MaximumCacheSize(&settings, CollectionSettings::kSettingsCacheSize, CollectionSettings::kSettingsCacheSizeUnit, CollectionSettings::kSettingsCacheSizeDefault) / 1024));
@@ -227,15 +241,11 @@ void CollectionModel::ReloadSettings() {
   if (show_pretty_covers != options_current_.show_pretty_covers ||
       show_dividers != options_current_.show_dividers ||
       show_various_artists != options_current_.show_various_artists ||
-      sort_skip_articles_for_artists != options_current_.sort_skip_articles_for_artists ||
+      sort_skips_articles != options_current_.sort_skips_articles) {
-      sort_skip_articles_for_albums != options_current_.sort_skip_articles_for_albums ||
-      use_sort_tags != options_current_.use_sort_tags) {
     options_current_.show_pretty_covers = show_pretty_covers;
     options_current_.show_dividers = show_dividers;
     options_current_.show_various_artists = show_various_artists;
-    options_current_.sort_skip_articles_for_artists = sort_skip_articles_for_artists;
+    options_current_.sort_skips_articles = sort_skips_articles;
-    options_current_.sort_skip_articles_for_albums = sort_skip_articles_for_albums;
-    options_current_.use_sort_tags = use_sort_tags;
     ScheduleReset();
   }
 
@@ -411,15 +421,10 @@ void CollectionModel::RemoveSongs(const SongList &songs) {
 
 void CollectionModel::ScheduleUpdate(const CollectionModelUpdate::Type type, const SongList &songs) {
 
-  if (type == CollectionModelUpdate::Type::Reset) {
+  for (qint64 i = 0; i < songs.count(); i += 400LL) {
-    updates_.enqueue(CollectionModelUpdate(type));
+    const qint64 number = std::min(songs.count() - i, 400LL);
-  }
+    const SongList songs_to_queue = songs.mid(i, number);
-  else {
+    updates_.enqueue(CollectionModelUpdate(type, songs_to_queue));
-    for (qint64 i = 0; i < songs.count(); i += 400LL) {
-      const qint64 number = std::min(songs.count() - i, 400LL);
-      const SongList songs_to_queue = songs.mid(i, number);
-      updates_.enqueue(CollectionModelUpdate(type, songs_to_queue));
-    }
   }
 
   if (!timer_update_->isActive()) {
@@ -428,14 +433,6 @@ void CollectionModel::ScheduleUpdate(const CollectionModelUpdate::Type type, con
 
 }
 
-void CollectionModel::ScheduleReset() {
-
-  if (!updates_.isEmpty() && updates_.first().type == CollectionModelUpdate::Type::Reset) return;
-
-  ScheduleUpdate(CollectionModelUpdate::Type::Reset);
-
-}
-
 void CollectionModel::ScheduleAddSongs(const SongList &songs) {
 
   ScheduleUpdate(CollectionModelUpdate::Type::Add, songs);
@@ -468,9 +465,6 @@ void CollectionModel::ProcessUpdate() {
   }
 
   switch (update.type) {
-    case CollectionModelUpdate::Type::Reset:
-      ResetInternal();
-      break;
     case CollectionModelUpdate::Type::AddReAddOrUpdate:
       AddReAddOrUpdateSongsInternal(update.songs);
       break;
@@ -545,10 +539,7 @@ void CollectionModel::AddSongsInternal(const SongList &songs) {
     // Sanity check to make sure we don't add songs that are outside the user's filter
     if (!options_active_.filter_options.Matches(song)) continue;
 
-    if (song_nodes_.contains(song.id())) {
+    if (song_nodes_.contains(song.id())) continue;
-      qLog(Debug) << song.id() << song.title() << "already exists, skipping";
-      continue;
-    }
 
     // Before we can add each song we need to make sure the required container items already exist in the tree.
     // These depend on which "group by" settings the user has on the collection.
@@ -689,8 +680,8 @@ void CollectionModel::RemoveSongsInternal(const SongList &songs) {
     if (!divider_nodes_.contains(divider_key)) continue;
 
     // Look to see if there are any other items still under this divider
-    QList<CollectionItem *> container_nodes = container_nodes_[0].values();
+    QList<CollectionItem*> container_nodes = container_nodes_[0].values();
-    if (std::any_of(container_nodes.begin(), container_nodes.end(), [this, divider_key](CollectionItem *node) { return DividerKey(options_active_.group_by[0], node->metadata, node->sort_text) == divider_key; })) {
+    if (std::any_of(container_nodes.begin(), container_nodes.end(), [this, divider_key](CollectionItem *node){ return DividerKey(options_active_.group_by[0], node->metadata, node->sort_text) == divider_key; })) {
       continue;
     }
 
@@ -708,7 +699,7 @@ CollectionItem *CollectionModel::CreateContainerItem(const GroupBy group_by, con
 
   QString divider_key;
   if (options_active_.show_dividers && container_level == 0) {
-    divider_key = DividerKey(group_by, song, SortText(group_by, song, options_active_.sort_skip_articles_for_artists, options_active_.sort_skip_articles_for_albums, options_active_.use_sort_tags));
+    divider_key = DividerKey(group_by, song, SortText(group_by, song, options_active_.sort_skips_articles));
     if (!divider_key.isEmpty()) {
       if (!divider_nodes_.contains(divider_key)) {
         CreateDividerItem(divider_key, DividerDisplayText(group_by, divider_key), parent);
@@ -722,7 +713,7 @@ CollectionItem *CollectionModel::CreateContainerItem(const GroupBy group_by, con
   item->container_level = container_level;
   item->container_key = container_key;
   item->display_text = DisplayText(group_by, song);
-  item->sort_text = SortText(group_by, song, options_active_.sort_skip_articles_for_artists, options_active_.sort_skip_articles_for_albums, options_active_.use_sort_tags);
+  item->sort_text = SortText(group_by, song, options_active_.sort_skips_articles);
   if (!divider_key.isEmpty()) {
     item->sort_text.prepend(divider_key + QLatin1Char(' '));
   }
@@ -1077,39 +1068,39 @@ QString CollectionModel::PrettyFormat(const Song &song) {
 
 }
 
-QString CollectionModel::SortText(const GroupBy group_by, const Song &song, const bool sort_skip_articles_for_artists, const bool sort_skip_articles_for_albums, const bool use_sort_tags) {
+QString CollectionModel::SortText(const GroupBy group_by, const Song &song, const bool sort_skips_articles) {
 
   switch (group_by) {
     case GroupBy::AlbumArtist:
-      return SortTextForName(use_sort_tags ? song.effective_albumartistsort() : song.effective_albumartist(), sort_skip_articles_for_artists);
+      return SortTextForArtist(song.effective_albumartist(), sort_skips_articles);
     case GroupBy::Artist:
-      return SortTextForName(use_sort_tags ? song.effective_artistsort() : song.artist(), sort_skip_articles_for_artists);
+      return SortTextForArtist(song.artist(), sort_skips_articles);
     case GroupBy::Album:
-      return SortTextForName(use_sort_tags ? song.effective_albumsort() : song.album(), sort_skip_articles_for_albums);
+      return SortText(song.album());
     case GroupBy::AlbumDisc:
-      return SortTextForName(use_sort_tags ? song.effective_albumsort() : song.album(), sort_skip_articles_for_albums) + SortTextForNumber(std::max(0, song.disc()));
+      return song.album() + SortTextForNumber(std::max(0, song.disc()));
     case GroupBy::YearAlbum:
-      return SortTextForYear(song.year()) + song.grouping() + SortTextForName(use_sort_tags ? song.effective_albumsort() : song.album(), sort_skip_articles_for_albums);
+      return SortTextForNumber(std::max(0, song.year())) + song.grouping() + song.album();
     case GroupBy::YearAlbumDisc:
-      return SortTextForYear(song.year()) + SortTextForName(use_sort_tags ? song.effective_albumsort() : song.album(), sort_skip_articles_for_albums) + SortTextForNumber(std::max(0, song.disc()));
+      return SortTextForNumber(std::max(0, song.year())) + song.album() + SortTextForNumber(std::max(0, song.disc()));
     case GroupBy::OriginalYearAlbum:
-      return SortTextForYear(song.effective_originalyear()) + song.grouping() + SortTextForName(use_sort_tags ? song.effective_albumsort() : song.album(), sort_skip_articles_for_albums);
+      return SortTextForNumber(std::max(0, song.effective_originalyear())) + song.grouping() + song.album();
     case GroupBy::OriginalYearAlbumDisc:
-      return SortTextForYear(song.effective_originalyear()) + SortTextForName(use_sort_tags ? song.effective_albumsort() : song.album(), sort_skip_articles_for_albums) + SortTextForNumber(std::max(0, song.disc()));
+      return SortTextForNumber(std::max(0, song.effective_originalyear())) + song.album() + SortTextForNumber(std::max(0, song.disc()));
     case GroupBy::Disc:
       return SortTextForNumber(std::max(0, song.disc()));
     case GroupBy::Year:
-      return SortTextForYear(song.year()) + QLatin1Char(' ');
+      return SortTextForNumber(std::max(0, song.year())) + QLatin1Char(' ');
     case GroupBy::OriginalYear:
-      return SortTextForYear(song.effective_originalyear()) + QLatin1Char(' ');
+      return SortTextForNumber(std::max(0, song.effective_originalyear())) + QLatin1Char(' ');
     case GroupBy::Genre:
-      return SortText(song.genre());
+      return SortTextForArtist(song.genre(), sort_skips_articles);
     case GroupBy::Composer:
-      return SortTextForName(use_sort_tags ? song.effective_composersort() : song.composer(), sort_skip_articles_for_artists);
+      return SortTextForArtist(song.composer(), sort_skips_articles);
     case GroupBy::Performer:
-      return SortTextForName(use_sort_tags ? song.effective_performersort() : song.performer(), sort_skip_articles_for_artists);
+      return SortTextForArtist(song.performer(), sort_skips_articles);
     case GroupBy::Grouping:
-      return SortText(song.grouping());
+      return SortTextForArtist(song.grouping(), sort_skips_articles);
     case GroupBy::FileType:
       return song.TextForFiletype();
     case GroupBy::Format:
@@ -1144,9 +1135,21 @@ QString CollectionModel::SortText(QString text) {
 
 }
 
-QString CollectionModel::SortTextForName(const QString &name, const bool sort_skip_articles) {
+QString CollectionModel::SortTextForArtist(QString artist, const bool skip_articles) {
 
-  return sort_skip_articles ? SkipArticles(SortText(name)) : SortText(name);
+  artist = SortText(artist);
+
+  if (skip_articles) {
+    for (const auto &i : Song::kArticles) {
+      if (artist.startsWith(i)) {
+        qint64 ilen = i.length();
+        artist = artist.right(artist.length() - ilen) + ", "_L1 + i.left(ilen - 1);
+        break;
+      }
+    }
+  }
+
+  return artist;
 
 }
 
@@ -1165,32 +1168,18 @@ QString CollectionModel::SortTextForSong(const Song &song) {
 
 QString CollectionModel::SortTextForYear(const int year) {
 
-  const QString str = QString::number(std::max(year, 0));
+  QString str = QString::number(year);
   return QStringLiteral("0").repeated(qMax(0, 4 - str.length())) + str;
 
 }
 
 QString CollectionModel::SortTextForBitrate(const int bitrate) {
 
-  const QString str = QString::number(bitrate);
+  QString str = QString::number(bitrate);
   return QStringLiteral("0").repeated(qMax(0, 3 - str.length())) + str;
 
 }
 
-QString CollectionModel::SkipArticles(QString name) {
-
-  for (const auto &i : Song::kArticles) {
-    if (name.startsWith(i)) {
-      qint64 ilen = i.length();
-      name = name.right(name.length() - ilen) + ", "_L1 + i.left(ilen - 1);
-      break;
-    }
-  }
-
-  return name;
-
-}
-
 bool CollectionModel::IsSongTitleDataChanged(const Song &song1, const Song &song2) {
 
   return song1.url() != song2.url() ||
@@ -1221,30 +1210,27 @@ QString CollectionModel::ContainerKey(const GroupBy group_by, const Song &song,
       if (options_active_.separate_albums_by_grouping && !song.grouping().isEmpty()) key.append(QLatin1Char('-') + song.grouping());
       break;
     case GroupBy::AlbumDisc:
-      key = TextOrUnknown(song.album());
+      key = PrettyAlbumDisc(song.album(), song.disc());
-      key.append(QLatin1Char('-') + SortTextForNumber(song.disc()));
       if (!song.album_id().isEmpty()) key.append(QLatin1Char('-') + song.album_id());
       if (options_active_.separate_albums_by_grouping && !song.grouping().isEmpty()) key.append(QLatin1Char('-') + song.grouping());
       break;
     case GroupBy::YearAlbum:
-      key = SortTextForYear(song.year()) + QLatin1Char('-') + TextOrUnknown(song.album());
+      key = PrettyYearAlbum(song.year(), song.album());
       if (!song.album_id().isEmpty()) key.append(QLatin1Char('-') + song.album_id());
       if (options_active_.separate_albums_by_grouping && !song.grouping().isEmpty()) key.append(QLatin1Char('-') + song.grouping());
       break;
     case GroupBy::YearAlbumDisc:
-      key = SortTextForYear(song.year()) + QLatin1Char('-') + TextOrUnknown(song.album());
+      key = PrettyYearAlbumDisc(song.year(), song.album(), song.disc());
-      key.append(QLatin1Char('-') + SortTextForNumber(song.disc()));
       if (!song.album_id().isEmpty()) key.append(QLatin1Char('-') + song.album_id());
       if (options_active_.separate_albums_by_grouping && !song.grouping().isEmpty()) key.append(QLatin1Char('-') + song.grouping());
       break;
     case GroupBy::OriginalYearAlbum:
-      key = SortTextForYear(song.effective_originalyear()) + QLatin1Char('-') + TextOrUnknown(song.album());
+      key = PrettyYearAlbum(song.effective_originalyear(), song.album());
       if (!song.album_id().isEmpty()) key.append(QLatin1Char('-') + song.album_id());
       if (options_active_.separate_albums_by_grouping && !song.grouping().isEmpty()) key.append(QLatin1Char('-') + song.grouping());
       break;
     case GroupBy::OriginalYearAlbumDisc:
-      key = SortTextForYear(song.effective_originalyear()) + QLatin1Char('-') + TextOrUnknown(song.album());
+      key = PrettyYearAlbumDisc(song.effective_originalyear(), song.album(), song.disc());
-      key.append(QLatin1Char('-') + SortTextForNumber(song.disc()));
       if (!song.album_id().isEmpty()) key.append(QLatin1Char('-') + song.album_id());
       if (options_active_.separate_albums_by_grouping && !song.grouping().isEmpty()) key.append(QLatin1Char('-') + song.grouping());
       break;
@@ -1252,10 +1238,10 @@ QString CollectionModel::ContainerKey(const GroupBy group_by, const Song &song,
       key = PrettyDisc(song.disc());
       break;
     case GroupBy::Year:
-      key = SortTextForYear(song.year());
+      key = QString::number(std::max(0, song.year()));
       break;
     case GroupBy::OriginalYear:
-      key = SortTextForYear(song.effective_originalyear());
+      key = QString::number(std::max(0, song.effective_originalyear()));
       break;
     case GroupBy::Genre:
       key = TextOrUnknown(song.genre());
@@ -1347,7 +1333,7 @@ QString CollectionModel::DividerKey(const GroupBy group_by, const Song &song, co
     case GroupBy::Bitdepth:
       return SortTextForNumber(song.bitdepth());
     case GroupBy::Bitrate:
-      return SortTextForBitrate(song.bitrate());
+      return SortTextForNumber(song.bitrate());
     case GroupBy::None:
     case GroupBy::GroupByCount:
       return QString();

src/collection/collectionmodel.h

@@ -1,6 +1,6 @@
 /*
  * Strawberry Music Player
- * Copyright 2018-2025, Jonas Kvinge <jonas@jkvinge.net>
+ * Copyright 2018-2024, Jonas Kvinge <jonas@jkvinge.net>
  *
  * Strawberry is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by
@@ -129,18 +129,14 @@ class CollectionModel : public SimpleTreeModel<CollectionItem> {
                 show_dividers(true),
                 show_pretty_covers(true),
                 show_various_artists(true),
-                sort_skip_articles_for_artists(false),
+                sort_skips_articles(true),
-                sort_skip_articles_for_albums(false),
-                use_sort_tags(true),
                 separate_albums_by_grouping(false) {}
 
     Grouping group_by;
     bool show_dividers;
     bool show_pretty_covers;
     bool show_various_artists;
-    bool sort_skip_articles_for_artists;
+    bool sort_skips_articles;
-    bool sort_skip_articles_for_albums;
-    bool use_sort_tags;
     bool separate_albums_by_grouping;
     CollectionFilterOptions filter_options;
   };
@@ -187,14 +183,13 @@ class CollectionModel : public SimpleTreeModel<CollectionItem> {
   static QString PrettyYearAlbumDisc(const int year, const QString &album, const int disc);
   static QString PrettyDisc(const int disc);
   static QString PrettyFormat(const Song &song);
-  static QString SortText(const GroupBy group_by, const Song &song, const bool sort_skip_articles_for_artists, const bool sort_skip_articles_for_albums, const bool use_sort_tags);
+  QString SortText(const GroupBy group_by, const Song &song, const bool sort_skips_articles);
   static QString SortText(QString text);
-  static QString SortTextForName(const QString &name, const bool sort_skip_articles);
   static QString SortTextForNumber(const int number);
+  static QString SortTextForArtist(QString artist, const bool skip_articles);
   static QString SortTextForSong(const Song &song);
   static QString SortTextForYear(const int year);
   static QString SortTextForBitrate(const int bitrate);
-  static QString SkipArticles(QString name);
   static bool IsSongTitleDataChanged(const Song &song1, const Song &song2);
   QString ContainerKey(const GroupBy group_by, const Song &song, bool &has_unique_album_identifier) const;
 
@@ -233,7 +228,7 @@ class CollectionModel : public SimpleTreeModel<CollectionItem> {
 
   QVariant data(CollectionItem *item, const int role) const;
 
-  void ScheduleUpdate(const CollectionModelUpdate::Type type, const SongList &songs = SongList());
+  void ScheduleUpdate(const CollectionModelUpdate::Type type, const SongList &songs);
   void ScheduleAddSongs(const SongList &songs);
   void ScheduleUpdateSongs(const SongList &songs);
   void ScheduleRemoveSongs(const SongList &songs);
@@ -264,7 +259,7 @@ class CollectionModel : public SimpleTreeModel<CollectionItem> {
   static qint64 MaximumCacheSize(Settings *s, const char *size_id, const char *size_unit_id, const qint64 cache_size_default);
 
  private Q_SLOTS:
-  void ResetInternal();
+  void Reload();
   void ScheduleReset();
   void ProcessUpdate();
   void LoadSongsFromSqlAsyncFinished();
@@ -283,6 +278,7 @@ class CollectionModel : public SimpleTreeModel<CollectionItem> {
   const SharedPtr<AlbumCoverLoader> albumcover_loader_;
   CollectionDirectoryModel *dir_model_;
   CollectionFilter *filter_;
+  QTimer *timer_reload_;
   QTimer *timer_update_;
 
   QPixmap pixmap_no_cover_;

src/collection/collectionmodelupdate.h

@@ -25,13 +25,12 @@
 class CollectionModelUpdate {
  public:
   enum class Type {
-    Reset,
     AddReAddOrUpdate,
     Add,
     Update,
     Remove,
   };
-  explicit CollectionModelUpdate(const Type _type, const SongList &_songs = SongList());
+  explicit CollectionModelUpdate(const Type _type, const SongList &_songs);
   Type type;
   SongList songs;
 };

src/collection/collectionplaylistitem.cpp

@@ -34,6 +34,8 @@ CollectionPlaylistItem::CollectionPlaylistItem(const Song::Source source) : Play
 
 CollectionPlaylistItem::CollectionPlaylistItem(const Song &song) : PlaylistItem(song.source()), song_(song) {}
 
+QUrl CollectionPlaylistItem::Url() const { return song_.url(); }
+
 bool CollectionPlaylistItem::InitFromQuery(const SqlRow &query) {
 
   int col = 0;
@@ -41,11 +43,8 @@ bool CollectionPlaylistItem::InitFromQuery(const SqlRow &query) {
     case Song::Source::Collection:
       col = 0;
       break;
-    case Song::Source::Dropbox:
-      col = static_cast<int>(Song::kRowIdColumns.count());
-      break;
     default:
-      col = static_cast<int>(Song::kRowIdColumns.count() * 2);
+      col = static_cast<int>(Song::kRowIdColumns.count());
       break;
   }
 
@@ -63,7 +62,7 @@ void CollectionPlaylistItem::Reload() {
       qLog(Error) << "Could not reload file" << song_.url() << result.error_string();
       return;
     }
-    UpdateStreamMetadata(song_);
+    UpdateTemporaryMetadata(song_);
   }
 
 }
@@ -79,9 +78,16 @@ QVariant CollectionPlaylistItem::DatabaseValue(const DatabaseColumn database_col
 
 }
 
+Song CollectionPlaylistItem::Metadata() const {
+
+  if (HasTemporaryMetadata()) return temp_metadata_;
+  return song_;
+
+}
+
 void CollectionPlaylistItem::SetArtManual(const QUrl &cover_url) {
 
   song_.set_art_manual(cover_url);
-  if (HasStreamMetadata()) stream_song_.set_art_manual(cover_url);
+  if (HasTemporaryMetadata()) temp_metadata_.set_art_manual(cover_url);
 
 }

src/collection/collectionplaylistitem.h

@@ -35,17 +35,19 @@ class CollectionPlaylistItem : public PlaylistItem {
   explicit CollectionPlaylistItem(const Song::Source source);
   explicit CollectionPlaylistItem(const Song &song);
 
-  Song OriginalMetadata() const override { return song_; }
+  QUrl Url() const override;
-  void SetOriginalMetadata(const Song &song) override { song_ = song; }
-
-  QUrl OriginalUrl() const override { return song_.url(); }
-  bool IsLocalCollectionItem() const override { return song_.source() == Song::Source::Collection; }
 
   bool InitFromQuery(const SqlRow &query) override;
   void Reload() override;
 
+  Song Metadata() const override;
+  Song OriginalMetadata() const override { return song_; }
+  void SetMetadata(const Song &song) override { song_ = song; }
+
   void SetArtManual(const QUrl &cover_url) override;
 
+  bool IsLocalCollectionItem() const override { return song_.source() == Song::Source::Collection; }
+
  protected:
   QVariant DatabaseValue(const DatabaseColumn database_column) const override;
   Song DatabaseSongMetadata() const override { return Song(source_); }
@@ -58,3 +60,4 @@ class CollectionPlaylistItem : public PlaylistItem {
 };
 
 #endif  // COLLECTIONPLAYLISTITEM_H
+

src/collection/collectionquery.cpp

@@ -101,9 +101,9 @@ void CollectionQuery::AddCompilationRequirement(const bool compilation) {
 QString CollectionQuery::GetInnerQuery() const {
   return duplicates_only_
              ? QStringLiteral(" INNER JOIN (select * from duplicated_songs) dsongs        "
-                              "ON (%songs_table.artist = dsongs.dup_artist       "
+                   "ON (%songs_table.artist = dsongs.dup_artist       "
-                              "AND %songs_table.album = dsongs.dup_album     "
+                   "AND %songs_table.album = dsongs.dup_album     "
-                              "AND %songs_table.title = dsongs.dup_title)    ")
+                   "AND %songs_table.title = dsongs.dup_title)    ")
              : QString();
 }
 

src/collection/collectionview.cpp

@@ -65,8 +65,10 @@
 #include "collectionitem.h"
 #include "collectionitemdelegate.h"
 #include "collectionview.h"
-#include "device/devicemanager.h"
+#ifndef Q_OS_WIN32
-#include "device/devicestatefiltermodel.h"
+#  include "device/devicemanager.h"
+#  include "device/devicestatefiltermodel.h"
+#endif
 #include "dialogs/edittagdialog.h"
 #include "dialogs/deleteconfirmationdialog.h"
 #include "organize/organizedialog.h"
@@ -93,7 +95,9 @@ CollectionView::CollectionView(QWidget *parent)
       action_open_in_new_playlist_(nullptr),
       action_organize_(nullptr),
       action_search_for_this_(nullptr),
+#ifndef Q_OS_WIN32
       action_copy_to_device_(nullptr),
+#endif
       action_edit_track_(nullptr),
       action_edit_tracks_(nullptr),
       action_rescan_songs_(nullptr),
@@ -413,7 +417,9 @@ void CollectionView::contextMenuEvent(QContextMenuEvent *e) {
 
     context_menu_->addSeparator();
     action_organize_ = context_menu_->addAction(IconLoader::Load(u"edit-copy"_s), tr("Organize files..."), this, &CollectionView::Organize);
+#ifndef Q_OS_WIN32
     action_copy_to_device_ = context_menu_->addAction(IconLoader::Load(u"device"_s), tr("Copy to device..."), this, &CollectionView::CopyToDevice);
+#endif
     action_delete_files_ = context_menu_->addAction(IconLoader::Load(u"edit-delete"_s), tr("Delete from disk..."), this, &CollectionView::Delete);
 
     context_menu_->addSeparator();
@@ -433,8 +439,10 @@ void CollectionView::contextMenuEvent(QContextMenuEvent *e) {
 
     context_menu_->addMenu(filter_widget_->menu());
 
+#ifndef Q_OS_WIN32
     action_copy_to_device_->setDisabled(device_manager_->connected_devices_model()->rowCount() == 0);
     QObject::connect(device_manager_->connected_devices_model(), &DeviceStateFilterModel::IsEmptyChanged, action_copy_to_device_, &QAction::setDisabled);
+#endif
 
   }
 
@@ -473,7 +481,9 @@ void CollectionView::contextMenuEvent(QContextMenuEvent *e) {
   action_rescan_songs_->setEnabled(regular_editable > 0);
 
   action_organize_->setVisible(regular_elements == regular_editable);
+#ifndef Q_OS_WIN32
   action_copy_to_device_->setVisible(regular_elements == regular_editable);
+#endif
 
   action_delete_files_->setVisible(delete_files_);
 
@@ -482,7 +492,9 @@ void CollectionView::contextMenuEvent(QContextMenuEvent *e) {
 
   // only when all selected items are editable
   action_organize_->setEnabled(regular_elements == regular_editable);
+#ifndef Q_OS_WIN32
   action_copy_to_device_->setEnabled(regular_elements == regular_editable);
+#endif
 
   action_delete_files_->setEnabled(delete_files_);
 
@@ -747,6 +759,7 @@ void CollectionView::RescanSongs() {
 
 void CollectionView::CopyToDevice() {
 
+#ifndef Q_OS_WIN32
   if (!organize_dialog_) {
     organize_dialog_ = make_unique<OrganizeDialog>(task_manager_, tagreader_client_, nullptr, this);
   }
@@ -755,6 +768,7 @@ void CollectionView::CopyToDevice() {
   organize_dialog_->SetCopy(true);
   organize_dialog_->SetSongs(GetSelectedSongs());
   organize_dialog_->show();
+#endif
 
 }
 

src/collection/collectionview.h

@@ -138,6 +138,7 @@ class CollectionView : public AutoExpandingTreeView {
   void DeleteFilesFinished(const SongList &songs_with_errors);
 
  private:
+  void RecheckIsEmpty();
   void SetShowInVarious(const bool on);
   bool RestoreLevelFocus(const QModelIndex &parent = QModelIndex());
   void SaveContainerPath(const QModelIndex &child);
@@ -175,7 +176,9 @@ class CollectionView : public AutoExpandingTreeView {
   QAction *action_organize_;
   QAction *action_search_for_this_;
 
+#ifndef Q_OS_WIN32
   QAction *action_copy_to_device_;
+#endif
   QAction *action_edit_track_;
   QAction *action_edit_tracks_;
   QAction *action_rescan_songs_;

src/collection/collectionwatcher.cpp

@@ -706,14 +706,8 @@ void CollectionWatcher::ScanSubdirectory(const QString &path, const CollectionSu
         qLog(Debug) << file << "is missing EBU R 128 loudness characteristics.";
       }
 
-      // If the song is unavailable and nothing has changed, just mark it as available without re-scanning
-      // For CUE files with multiple sections, all sections share the same file and would have the same availability status
-      if (matching_song.unavailable() && !changed && !missing_fingerprint && !missing_loudness_characteristics) {
-        qLog(Debug) << "Unavailable song" << file << "restored without re-scanning.";
-        t->readded_songs << matching_songs;
-      }
       // The song's changed or missing fingerprint - create fingerprint and reread the metadata from file.
-      else if (t->ignores_mtime() || changed || missing_fingerprint || missing_loudness_characteristics) {
+      if (t->ignores_mtime() || changed || missing_fingerprint || missing_loudness_characteristics) {
 
         QString fingerprint;
 #ifdef HAVE_SONGFINGERPRINTING
@@ -734,6 +728,12 @@ void CollectionWatcher::ScanSubdirectory(const QString &path, const CollectionSu
         }
       }
 
+      // Nothing has changed - mark the song available without re-scanning
+      else if (matching_song.unavailable()) {
+        qLog(Debug) << "Unavailable song" << file << "restored.";
+        t->readded_songs << matching_songs;
+      }
+
     }
     else {  // Search the DB by fingerprint.
       QString fingerprint;
@@ -999,18 +999,6 @@ void CollectionWatcher::AddChangedSong(const QString &file, const Song &matching
       changes << u"file path"_s;
       notify_new = true;
     }
-    if (matching_song.filetype() != new_song.filetype()) {
-      changes << u"filetype"_s;
-      notify_new = true;
-    }
-    if (matching_song.filesize() != new_song.filesize()) {
-      changes << u"filesize"_s;
-      notify_new = true;
-    }
-    if (matching_song.length_nanosec() != new_song.length_nanosec()) {
-      changes << u"length"_s;
-      notify_new = true;
-    }
     if (matching_song.fingerprint() != new_song.fingerprint()) {
       changes << u"fingerprint"_s;
       notify_new = true;
@@ -1046,9 +1034,6 @@ void CollectionWatcher::AddChangedSong(const QString &file, const Song &matching
     if (matching_song.mtime() != new_song.mtime()) {
       changes << u"mtime"_s;
     }
-    if (matching_song.ctime() != new_song.ctime()) {
-      changes << u"ctime"_s;
-    }
 
     if (changes.isEmpty()) {
       qLog(Debug) << "Song" << file << "unchanged.";

src/collection/collectionwatcher.h

@@ -137,7 +137,7 @@ class CollectionWatcher : public QObject {
     QStringList files_changed_path_;
 
    private:
-    ScanTransaction &operator=(const ScanTransaction &transaction) { Q_UNUSED(transaction); return *this; }
+    ScanTransaction &operator=(const ScanTransaction&) { return *this; }
 
     int task_id_;
     quint64 progress_;
@@ -261,6 +261,7 @@ class CollectionWatcher : public QObject {
   static QStringList sValidImages;
 
   qint64 last_scan_time_;
+
 };
 
 inline QString CollectionWatcher::NoExtensionPart(const QString &fileName) {

src/collection/savedgroupingmanager.cpp

@@ -30,7 +30,6 @@
 #include <QByteArray>
 #include <QString>
 #include <QStringList>
-#include <QUrl>
 #include <QIODevice>
 #include <QDataStream>
 #include <QKeySequence>
@@ -168,20 +167,14 @@ void SavedGroupingManager::UpdateModel() {
   if (version == 1) {
     QStringList saved = s.childKeys();
     for (int i = 0; i < saved.size(); ++i) {
-      const QString &name = saved.at(i);
+      if (saved.at(i) == "version"_L1) continue;
-      if (name == "version"_L1) continue;
+      QByteArray bytes = s.value(saved.at(i)).toByteArray();
-      QByteArray bytes = s.value(name).toByteArray();
       QDataStream ds(&bytes, QIODevice::ReadOnly);
       CollectionModel::Grouping g;
       ds >> g;
 
       QList<QStandardItem*> list;
-
+      list << new QStandardItem(saved.at(i))
-      QStandardItem *item = new QStandardItem();
-      item->setText(QUrl::fromPercentEncoding(name.toUtf8()));
-      item->setData(name);
-
-      list << item
            << new QStandardItem(GroupByToString(g.first))
            << new QStandardItem(GroupByToString(g.second))
            << new QStandardItem(GroupByToString(g.third));
@@ -192,9 +185,8 @@ void SavedGroupingManager::UpdateModel() {
   else {
     QStringList saved = s.childKeys();
     for (int i = 0; i < saved.size(); ++i) {
-      const QString &name = saved.at(i);
+      if (saved.at(i) == "version"_L1) continue;
-      if (name == "version"_L1) continue;
+      s.remove(saved.at(i));
-      s.remove(name);
     }
   }
   s.endGroup();
@@ -210,7 +202,7 @@ void SavedGroupingManager::Remove() {
     for (const QModelIndex &idx : indexes) {
       if (idx.isValid()) {
         qLog(Debug) << "Remove saved grouping: " << model_->item(idx.row(), 0)->text();
-        s.remove(model_->item(idx.row(), 0)->data().toString());
+        s.remove(model_->item(idx.row(), 0)->text());
       }
     }
     s.endGroup();

src/config.h.in

@@ -33,8 +33,6 @@
 #cmakedefine HAVE_SPOTIFY
 #cmakedefine HAVE_QOBUZ
 #cmakedefine HAVE_DISCORD_RPC
-#cmakedefine HAVE_DROPBOX
-#cmakedefine HAVE_ONEDRIVE
 
 #cmakedefine HAVE_TAGLIB_DSFFILE
 #cmakedefine HAVE_TAGLIB_DSDIFFFILE

src/constants/appearancesettings.h

@@ -1,21 +1,21 @@
 /*
- * Strawberry Music Player
+* Strawberry Music Player
- * Copyright 2024, Jonas Kvinge <jonas@jkvinge.net>
+* Copyright 2024, Jonas Kvinge <jonas@jkvinge.net>
- *
+*
- * Strawberry is free software: you can redistribute it and/or modify
+* Strawberry is free software: you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
+* it under the terms of the GNU General Public License as published by
- * the Free Software Foundation, either version 3 of the License, or
+* the Free Software Foundation, either version 3 of the License, or
- * (at your option) any later version.
+* (at your option) any later version.
- *
+*
- * Strawberry is distributed in the hope that it will be useful,
+* Strawberry is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
+* but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
+* GNU General Public License for more details.
- *
+*
- * You should have received a copy of the GNU General Public License
+* You should have received a copy of the GNU General Public License
- * along with Strawberry.  If not, see <http://www.gnu.org/licenses/>.
+* along with Strawberry.  If not, see <http://www.gnu.org/licenses/>.
- *
+*
- */
+*/
 
 #ifndef APPEARANCESETTINGS_H
 #define APPEARANCESETTINGS_H
@@ -70,6 +70,6 @@ enum class BackgroundImagePosition {
   BottomRight = 5
 };
 
-}  // namespace AppearanceSettings
+}  // namespace
 
 #endif  // APPEARANCESETTINGS_H

src/constants/backendsettings.h

@@ -1,21 +1,21 @@
 /*
- * Strawberry Music Player
+* Strawberry Music Player
- * Copyright 2024, Jonas Kvinge <jonas@jkvinge.net>
+* Copyright 2024, Jonas Kvinge <jonas@jkvinge.net>
- *
+*
- * Strawberry is free software: you can redistribute it and/or modify
+* Strawberry is free software: you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
+* it under the terms of the GNU General Public License as published by
- * the Free Software Foundation, either version 3 of the License, or
+* the Free Software Foundation, either version 3 of the License, or
- * (at your option) any later version.
+* (at your option) any later version.
- *
+*
- * Strawberry is distributed in the hope that it will be useful,
+* Strawberry is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
+* but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
+* GNU General Public License for more details.
- *
+*
- * You should have received a copy of the GNU General Public License
+* You should have received a copy of the GNU General Public License
- * along with Strawberry.  If not, see <http://www.gnu.org/licenses/>.
+* along with Strawberry.  If not, see <http://www.gnu.org/licenses/>.
- *
+*
- */
+*/
 
 #ifndef BACKENDSETTINGS_H
 #define BACKENDSETTINGS_H
@@ -63,6 +63,6 @@ constexpr qint64 kDefaultBufferDuration = 4000;
 constexpr double kDefaultBufferLowWatermark = 0.33;
 constexpr double kDefaultBufferHighWatermark = 0.99;
 
-}  // namespace BackendSettings
+}  // namespace
 
 #endif  // BACKENDSETTINGS_H

src/constants/behavioursettings.h

@@ -1,21 +1,21 @@
 /*
- * Strawberry Music Player
+* Strawberry Music Player
- * Copyright 2024, Jonas Kvinge <jonas@jkvinge.net>
+* Copyright 2024, Jonas Kvinge <jonas@jkvinge.net>
- *
+*
- * Strawberry is free software: you can redistribute it and/or modify
+* Strawberry is free software: you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
+* it under the terms of the GNU General Public License as published by
- * the Free Software Foundation, either version 3 of the License, or
+* the Free Software Foundation, either version 3 of the License, or
- * (at your option) any later version.
+* (at your option) any later version.
- *
+*
- * Strawberry is distributed in the hope that it will be useful,
+* Strawberry is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
+* but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
+* GNU General Public License for more details.
- *
+*
- * You should have received a copy of the GNU General Public License
+* You should have received a copy of the GNU General Public License
- * along with Strawberry.  If not, see <http://www.gnu.org/licenses/>.
+* along with Strawberry.  If not, see <http://www.gnu.org/licenses/>.
- *
+*
- */
+*/
 
 #ifndef BEHAVIOURSETTINGS_H
 #define BEHAVIOURSETTINGS_H
@@ -71,6 +71,6 @@ constexpr char kDoubleClickPlaylistAddMode[] = "doubleclick_playlist_addmode";
 constexpr char kSeekStepSec[] = "seek_step_sec";
 constexpr char kVolumeIncrement[] = "volume_increment";
 
-}  // namespace BehaviourSettings
+}  // namespace
 
 #endif  // BEHAVIOURSETTINGS_H

src/constants/collectionsettings.h

@@ -1,21 +1,21 @@
 /*
- * Strawberry Music Player
+* Strawberry Music Player
- * Copyright 2024-2025, Jonas Kvinge <jonas@jkvinge.net>
+* Copyright 2024, Jonas Kvinge <jonas@jkvinge.net>
- *
+*
- * Strawberry is free software: you can redistribute it and/or modify
+* Strawberry is free software: you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
+* it under the terms of the GNU General Public License as published by
- * the Free Software Foundation, either version 3 of the License, or
+* the Free Software Foundation, either version 3 of the License, or
- * (at your option) any later version.
+* (at your option) any later version.
- *
+*
- * Strawberry is distributed in the hope that it will be useful,
+* Strawberry is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
+* but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
+* GNU General Public License for more details.
- *
+*
- * You should have received a copy of the GNU General Public License
+* You should have received a copy of the GNU General Public License
- * along with Strawberry.  If not, see <http://www.gnu.org/licenses/>.
+* along with Strawberry.  If not, see <http://www.gnu.org/licenses/>.
- *
+*
- */
+*/
 
 #ifndef COLLECTIONSETTINGS_H
 #define COLLECTIONSETTINGS_H
@@ -24,20 +24,18 @@ namespace CollectionSettings {
 
 constexpr char kSettingsGroup[] = "Collection";
 
-constexpr char kStartupScan[] = "startup_scan";
-constexpr char kMonitor[] = "monitor";
-constexpr char kSongTracking[] = "song_tracking";
-constexpr char kMarkSongsUnavailable[] = "mark_songs_unavailable";
-constexpr char kSongENUR128LoudnessAnalysis[] = "song_ebur128_loudness_analysis";
-constexpr char kExpireUnavailableSongs[] = "expire_unavailable_songs";
-constexpr char kCoverArtPatterns[] = "cover_art_patterns";
 constexpr char kAutoOpen[] = "auto_open";
 constexpr char kShowDividers[] = "show_dividers";
 constexpr char kPrettyCovers[] = "pretty_covers";
 constexpr char kVariousArtists[] = "various_artists";
-constexpr char kSkipArticlesForArtists[] = "skip_articles_for_artists";
+constexpr char kSortSkipsArticles[] = "sort_skips_articles";
-constexpr char kSkipArticlesForAlbums[] = "skip_articles_for_albums";
+constexpr char kStartupScan[] = "startup_scan";
-constexpr char kUseSortTags[] = "use_short_tags";
+constexpr char kMonitor[] = "monitor";
+constexpr char kSongTracking[] = "song_tracking";
+constexpr char kSongENUR128LoudnessAnalysis[] = "song_ebur128_loudness_analysis";
+constexpr char kMarkSongsUnavailable[] = "mark_songs_unavailable";
+constexpr char kExpireUnavailableSongs[] = "expire_unavailable_songs";
+constexpr char kCoverArtPatterns[] = "cover_art_patterns";
 constexpr char kSettingsCacheSize[] = "cache_size";
 constexpr char kSettingsCacheSizeUnit[] = "cache_size_unit";
 constexpr char kSettingsDiskCacheEnable[] = "disk_cache_enable";
@@ -59,6 +57,6 @@ enum class CacheSizeUnit {
   TB
 };
 
-}  // namespace CollectionSettings
+}  // namespace
 
 #endif  // COLLECTIONSETTINGS_H

src/constants/contextsettings.h

@@ -1,21 +1,21 @@
 /*
- * Strawberry Music Player
+* Strawberry Music Player
- * Copyright 2024, Jonas Kvinge <jonas@jkvinge.net>
+* Copyright 2024, Jonas Kvinge <jonas@jkvinge.net>
- *
+*
- * Strawberry is free software: you can redistribute it and/or modify
+* Strawberry is free software: you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
+* it under the terms of the GNU General Public License as published by
- * the Free Software Foundation, either version 3 of the License, or
+* the Free Software Foundation, either version 3 of the License, or
- * (at your option) any later version.
+* (at your option) any later version.
- *
+*
- * Strawberry is distributed in the hope that it will be useful,
+* Strawberry is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
+* but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
+* GNU General Public License for more details.
- *
+*
- * You should have received a copy of the GNU General Public License
+* You should have received a copy of the GNU General Public License
- * along with Strawberry.  If not, see <http://www.gnu.org/licenses/>.
+* along with Strawberry.  If not, see <http://www.gnu.org/licenses/>.
- *
+*
- */
+*/
 
 #ifndef CONTEXTSETTINGS_H
 #define CONTEXTSETTINGS_H
@@ -43,6 +43,6 @@ constexpr char kSettingsSummaryFmt[] = "SummaryFmt";
 constexpr char kDefaultFontFamily[] = "Noto Sans";
 constexpr qreal kDefaultFontSizeHeadline = 11;
 
-}  // namespace ContextSettings
+}  // namespace
 
 #endif  // CONTEXTSETTINGS_H

src/constants/coverssettings.h

@@ -1,21 +1,21 @@
 /*
- * Strawberry Music Player
+* Strawberry Music Player
- * Copyright 2024, Jonas Kvinge <jonas@jkvinge.net>
+* Copyright 2024, Jonas Kvinge <jonas@jkvinge.net>
- *
+*
- * Strawberry is free software: you can redistribute it and/or modify
+* Strawberry is free software: you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
+* it under the terms of the GNU General Public License as published by
- * the Free Software Foundation, either version 3 of the License, or
+* the Free Software Foundation, either version 3 of the License, or
- * (at your option) any later version.
+* (at your option) any later version.
- *
+*
- * Strawberry is distributed in the hope that it will be useful,
+* Strawberry is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
+* but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
+* GNU General Public License for more details.
- *
+*
- * You should have received a copy of the GNU General Public License
+* You should have received a copy of the GNU General Public License
- * along with Strawberry.  If not, see <http://www.gnu.org/licenses/>.
+* along with Strawberry.  If not, see <http://www.gnu.org/licenses/>.
- *
+*
- */
+*/
 
 #ifndef COVERSSETTINGS_H
 #define COVERSSETTINGS_H
@@ -32,6 +32,6 @@ constexpr char kSaveOverwrite[] = "save_overwrite";
 constexpr char kSaveLowercase[] = "save_lowercase";
 constexpr char kSaveReplaceSpaces[] = "save_replace_spaces";
 
-}  // namespace CoversSettings
+}  // namespace
 
 #endif  // COVERSSETTINGS_H

src/constants/dropboxconstants.h

@@ -1,30 +0,0 @@
-/*
-* Strawberry Music Player
-* Copyright 2025, Jonas Kvinge <jonas@jkvinge.net>
-*
-* Strawberry is free software: you can redistribute it and/or modify
-* it under the terms of the GNU General Public License as published by
-* the Free Software Foundation, either version 3 of the License, or
-* (at your option) any later version.
-*
-* Strawberry is distributed in the hope that it will be useful,
-* but WITHOUT ANY WARRANTY; without even the implied warranty of
-* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-* GNU General Public License for more details.
-*
-* You should have received a copy of the GNU General Public License
-* along with Strawberry.  If not, see <http://www.gnu.org/licenses/>.
-*
-*/
-
-#ifndef DROPBOXCONSTANTS_H
-#define DROPBOXCONSTANTS_H
-
-namespace DropboxConstants {
-
-constexpr char kApiUrl[] = "https://api.dropboxapi.com";
-constexpr char kNotifyApiUrl[] = "https://notify.dropboxapi.com";
-
-}  // namespace
-
-#endif  // DROPBOXCONSTANTS_H

src/constants/dropboxsettings.h

@@ -1,46 +0,0 @@
-/*
-* Strawberry Music Player
-* Copyright 2025, Jonas Kvinge <jonas@jkvinge.net>
-*
-* Strawberry is free software: you can redistribute it and/or modify
-* it under the terms of the GNU General Public License as published by
-* the Free Software Foundation, either version 3 of the License, or
-* (at your option) any later version.
-*
-* Strawberry is distributed in the hope that it will be useful,
-* but WITHOUT ANY WARRANTY; without even the implied warranty of
-* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-* GNU General Public License for more details.
-*
-* You should have received a copy of the GNU General Public License
-* along with Strawberry.  If not, see <http://www.gnu.org/licenses/>.
-*
-*/
-
-#ifndef DROPBOXSETTINGS_H
-#define DROPBOXSETTINGS_H
-
-namespace DropboxSettings {
-
-constexpr char kSettingsGroup[] = "Dropbox";
-
-constexpr char kEnabled[] = "enabled";
-constexpr char kSearchDelay[] = "searchdelay";
-constexpr char kArtistsSearchLimit[] = "artistssearchlimit";
-constexpr char kAlbumsSearchLimit[] = "albumssearchlimit";
-constexpr char kSongsSearchLimit[] = "songssearchlimit";
-constexpr char kFetchAlbums[] = "fetchalbums";
-constexpr char kDownloadAlbumCovers[] = "downloadalbumcovers";
-
-constexpr char kTokenType[] = "token_type";
-constexpr char kAccessToken[] = "access_token";
-constexpr char kRefreshToken[] = "refresh_token";
-constexpr char kExpiresIn[] = "expires_in";
-constexpr char kLoginTime[] = "login_time";
-
-constexpr char kApiUrl[] = "https://api.dropboxapi.com";
-constexpr char kNotifyApiUrl[] = "https://notify.dropboxapi.com";
-
-}  // namespace
-
-#endif  // DROPBOXSETTINGS_H

src/constants/filefilterconstants.h

@@ -1,21 +1,21 @@
 /*
- * Strawberry Music Player
+* Strawberry Music Player
- * Copyright 2024, Jonas Kvinge <jonas@jkvinge.net>
+* Copyright 2024, Jonas Kvinge <jonas@jkvinge.net>
- *
+*
- * Strawberry is free software: you can redistribute it and/or modify
+* Strawberry is free software: you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
+* it under the terms of the GNU General Public License as published by
- * the Free Software Foundation, either version 3 of the License, or
+* the Free Software Foundation, either version 3 of the License, or
- * (at your option) any later version.
+* (at your option) any later version.
- *
+*
- * Strawberry is distributed in the hope that it will be useful,
+* Strawberry is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
+* but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
+* GNU General Public License for more details.
- *
+*
- * You should have received a copy of the GNU General Public License
+* You should have received a copy of the GNU General Public License
- * along with Strawberry.  If not, see <http://www.gnu.org/licenses/>.
+* along with Strawberry.  If not, see <http://www.gnu.org/licenses/>.
- *
+*
- */
+*/
 
 #ifndef FILEFILTERCONSTANTS_H
 #define FILEFILTERCONSTANTS_H
@@ -27,10 +27,10 @@ constexpr char kAllFilesFilterSpec[] = QT_TRANSLATE_NOOP("FileFilter", "All File
 constexpr char kFileFilter[] =
     "*.wav *.flac *.wv *.ogg *.oga *.opus *.spx *.ape *.mpc "
     "*.mp2 *.mp3 *.m4a *.mp4 *.aac *.asf *.asx *.wma "
-    "*.aif *.aiff *.mka *.tta *.dsf *.dsd *.webm "
+    "*.aif *.aiff *.mka *.tta *.dsf *.dsd "
     "*.cue *.m3u *.m3u8 *.pls *.xspf *.asxini "
     "*.ac3 *.dts "
-    "*.mod *.s3m *.xm *.it "
+    "*.mod *.s3m *.xm *.it"
     "*.spc *.vgm";
 
 constexpr char kLoadImageFileFilter[] = QT_TRANSLATE_NOOP("FileFilter", "Images (*.png *.jpg *.jpeg *.bmp *.gif *.xpm *.pbm *.pgm *.ppm *.xbm)");

src/constants/filenameconstants.h

@@ -1,21 +1,21 @@
 /*
- * Strawberry Music Player
+* Strawberry Music Player
- * Copyright 2023, Jonas Kvinge <jonas@jkvinge.net>
+* Copyright 2023, Jonas Kvinge <jonas@jkvinge.net>
- *
+*
- * Strawberry is free software: you can redistribute it and/or modify
+* Strawberry is free software: you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
+* it under the terms of the GNU General Public License as published by
- * the Free Software Foundation, either version 3 of the License, or
+* the Free Software Foundation, either version 3 of the License, or
- * (at your option) any later version.
+* (at your option) any later version.
- *
+*
- * Strawberry is distributed in the hope that it will be useful,
+* Strawberry is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
+* but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
+* GNU General Public License for more details.
- *
+*
- * You should have received a copy of the GNU General Public License
+* You should have received a copy of the GNU General Public License
- * along with Strawberry.  If not, see <http://www.gnu.org/licenses/>.
+* along with Strawberry.  If not, see <http://www.gnu.org/licenses/>.
- *
+*
- */
+*/
 
 #ifndef FILENAMECONSTANTS_H
 #define FILENAMECONSTANTS_H

src/constants/filesystemconstants.h

@@ -1,21 +1,21 @@
 /*
- * Strawberry Music Player
+* Strawberry Music Player
- * Copyright 2025, Jonas Kvinge <jonas@jkvinge.net>
+* Copyright 2025, Jonas Kvinge <jonas@jkvinge.net>
- *
+*
- * Strawberry is free software: you can redistribute it and/or modify
+* Strawberry is free software: you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
+* it under the terms of the GNU General Public License as published by
- * the Free Software Foundation, either version 3 of the License, or
+* the Free Software Foundation, either version 3 of the License, or
- * (at your option) any later version.
+* (at your option) any later version.
- *
+*
- * Strawberry is distributed in the hope that it will be useful,
+* Strawberry is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
+* but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
+* GNU General Public License for more details.
- *
+*
- * You should have received a copy of the GNU General Public License
+* You should have received a copy of the GNU General Public License
- * along with Strawberry.  If not, see <http://www.gnu.org/licenses/>.
+* along with Strawberry.  If not, see <http://www.gnu.org/licenses/>.
- *
+*
- */
+*/
 
 #ifndef FILESYSTEMCONSTANTS_H
 #define FILESYSTEMCONSTANTS_H

src/constants/globalshortcutssettings.h

@@ -1,21 +1,21 @@
 /*
- * Strawberry Music Player
+* Strawberry Music Player
- * Copyright 2024, Jonas Kvinge <jonas@jkvinge.net>
+* Copyright 2024, Jonas Kvinge <jonas@jkvinge.net>
- *
+*
- * Strawberry is free software: you can redistribute it and/or modify
+* Strawberry is free software: you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
+* it under the terms of the GNU General Public License as published by
- * the Free Software Foundation, either version 3 of the License, or
+* the Free Software Foundation, either version 3 of the License, or
- * (at your option) any later version.
+* (at your option) any later version.
- *
+*
- * Strawberry is distributed in the hope that it will be useful,
+* Strawberry is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
+* but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
+* GNU General Public License for more details.
- *
+*
- * You should have received a copy of the GNU General Public License
+* You should have received a copy of the GNU General Public License
- * along with Strawberry.  If not, see <http://www.gnu.org/licenses/>.
+* along with Strawberry.  If not, see <http://www.gnu.org/licenses/>.
- *
+*
- */
+*/
 
 #ifndef GLOBALSHORTCUTSSETTINGS_H
 #define GLOBALSHORTCUTSSETTINGS_H
@@ -26,6 +26,6 @@ constexpr char kSettingsGroup[] = "GlobalShortcuts";
 constexpr char kUseKGlobalAccel[] = "use_kglobalaccel";
 constexpr char kUseX11[] = "use_x11";
 
-}  // namespace GlobalShortcutsSettings
+}  // namespace
 
 #endif  // GLOBALSHORTCUTSSETTINGS_H

src/constants/lyricssettings.h

@@ -1,21 +1,21 @@
 /*
- * Strawberry Music Player
+* Strawberry Music Player
- * Copyright 2024, Jonas Kvinge <jonas@jkvinge.net>
+* Copyright 2024, Jonas Kvinge <jonas@jkvinge.net>
- *
+*
- * Strawberry is free software: you can redistribute it and/or modify
+* Strawberry is free software: you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
+* it under the terms of the GNU General Public License as published by
- * the Free Software Foundation, either version 3 of the License, or
+* the Free Software Foundation, either version 3 of the License, or
- * (at your option) any later version.
+* (at your option) any later version.
- *
+*
- * Strawberry is distributed in the hope that it will be useful,
+* Strawberry is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
+* but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
+* GNU General Public License for more details.
- *
+*
- * You should have received a copy of the GNU General Public License
+* You should have received a copy of the GNU General Public License
- * along with Strawberry.  If not, see <http://www.gnu.org/licenses/>.
+* along with Strawberry.  If not, see <http://www.gnu.org/licenses/>.
- *
+*
- */
+*/
 
 #ifndef LYRICSSETTINGS_H
 #define LYRICSSETTINGS_H
@@ -25,6 +25,6 @@ namespace LyricsSettings {
 constexpr char kSettingsGroup[] = "Lyrics";
 constexpr char kProviders[] = "providers";
 
-}  // namespace LyricsSettings
+}  // namespace
 
 #endif  // LYRICSSETTINGS_H

src/constants/mainwindowsettings.h

@@ -1,21 +1,21 @@
 /*
- * Strawberry Music Player
+* Strawberry Music Player
- * Copyright 2024, Jonas Kvinge <jonas@jkvinge.net>
+* Copyright 2024, Jonas Kvinge <jonas@jkvinge.net>
- *
+*
- * Strawberry is free software: you can redistribute it and/or modify
+* Strawberry is free software: you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
+* it under the terms of the GNU General Public License as published by
- * the Free Software Foundation, either version 3 of the License, or
+* the Free Software Foundation, either version 3 of the License, or
- * (at your option) any later version.
+* (at your option) any later version.
- *
+*
- * Strawberry is distributed in the hope that it will be useful,
+* Strawberry is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
+* but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
+* GNU General Public License for more details.
- *
+*
- * You should have received a copy of the GNU General Public License
+* You should have received a copy of the GNU General Public License
- * along with Strawberry.  If not, see <http://www.gnu.org/licenses/>.
+* along with Strawberry.  If not, see <http://www.gnu.org/licenses/>.
- *
+*
- */
+*/
 
 #ifndef MAINWINDOWSETTINGS_H
 #define MAINWINDOWSETTINGS_H
@@ -32,6 +32,6 @@ constexpr char kGeometry[] = "geometry";
 constexpr char kSplitterState[] = "splitter_state";
 constexpr char kDoNotShowSponsorMessage[] = "do_not_show_sponsor_message";
 
-}  // namespace MainWindowSettings
+} // namespace
 
-#endif  // MAINWINDOWSETTINGS_H
+#endif // MAINWINDOWSETTINGS_H

src/constants/moodbarsettings.h

@@ -1,21 +1,21 @@
 /*
- * Strawberry Music Player
+* Strawberry Music Player
- * Copyright 2024, Jonas Kvinge <jonas@jkvinge.net>
+* Copyright 2024, Jonas Kvinge <jonas@jkvinge.net>
- *
+*
- * Strawberry is free software: you can redistribute it and/or modify
+* Strawberry is free software: you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
+* it under the terms of the GNU General Public License as published by
- * the Free Software Foundation, either version 3 of the License, or
+* the Free Software Foundation, either version 3 of the License, or
- * (at your option) any later version.
+* (at your option) any later version.
- *
+*
- * Strawberry is distributed in the hope that it will be useful,
+* Strawberry is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
+* but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
+* GNU General Public License for more details.
- *
+*
- * You should have received a copy of the GNU General Public License
+* You should have received a copy of the GNU General Public License
- * along with Strawberry.  If not, see <http://www.gnu.org/licenses/>.
+* along with Strawberry.  If not, see <http://www.gnu.org/licenses/>.
- *
+*
- */
+*/
 
 #ifndef MOODBARSETTINGS_H
 #define MOODBARSETTINGS_H
@@ -38,6 +38,6 @@ constexpr char kShow[] = "show";
 constexpr char kStyle[] = "style";
 constexpr char kSave[] = "save";
 
-}  // namespace MoodbarSettings
+}  // namespace
 
 #endif  // MOODBARSETTINGS_H

src/constants/networkproxysettings.h

@@ -1,21 +1,21 @@
 /*
- * Strawberry Music Player
+* Strawberry Music Player
- * Copyright 2024, Jonas Kvinge <jonas@jkvinge.net>
+* Copyright 2024, Jonas Kvinge <jonas@jkvinge.net>
- *
+*
- * Strawberry is free software: you can redistribute it and/or modify
+* Strawberry is free software: you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
+* it under the terms of the GNU General Public License as published by
- * the Free Software Foundation, either version 3 of the License, or
+* the Free Software Foundation, either version 3 of the License, or
- * (at your option) any later version.
+* (at your option) any later version.
- *
+*
- * Strawberry is distributed in the hope that it will be useful,
+* Strawberry is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
+* but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
+* GNU General Public License for more details.
- *
+*
- * You should have received a copy of the GNU General Public License
+* You should have received a copy of the GNU General Public License
- * along with Strawberry.  If not, see <http://www.gnu.org/licenses/>.
+* along with Strawberry.  If not, see <http://www.gnu.org/licenses/>.
- *
+*
- */
+*/
 
 #ifndef NETWORKPROXYSETTINGS_H
 #define NETWORKPROXYSETTINGS_H
@@ -32,6 +32,6 @@ constexpr char kUsername[] = "username";
 constexpr char kPassword[] = "password";
 constexpr char kEngine[] = "engine";
 
-}  // namespace NetworkProxySettings
+}  // namespace
 
 #endif  // NETWORKPROXYSETTINGS_H

src/constants/notificationssettings.h

@@ -1,21 +1,21 @@
 /*
- * Strawberry Music Player
+* Strawberry Music Player
- * Copyright 2024, Jonas Kvinge <jonas@jkvinge.net>
+* Copyright 2024, Jonas Kvinge <jonas@jkvinge.net>
- *
+*
- * Strawberry is free software: you can redistribute it and/or modify
+* Strawberry is free software: you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
+* it under the terms of the GNU General Public License as published by
- * the Free Software Foundation, either version 3 of the License, or
+* the Free Software Foundation, either version 3 of the License, or
- * (at your option) any later version.
+* (at your option) any later version.
- *
+*
- * Strawberry is distributed in the hope that it will be useful,
+* Strawberry is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
+* but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
+* GNU General Public License for more details.
- *
+*
- * You should have received a copy of the GNU General Public License
+* You should have received a copy of the GNU General Public License
- * along with Strawberry.  If not, see <http://www.gnu.org/licenses/>.
+* along with Strawberry.  If not, see <http://www.gnu.org/licenses/>.
- *
+*
- */
+*/
 
 #ifndef NOTIFICATIONSSETTINGS_H
 #define NOTIFICATIONSSETTINGS_H
@@ -45,7 +45,7 @@ constexpr char kCustomTextEnabled[] = "CustomTextEnabled";
 constexpr char kCustomText1[] = "CustomText1";
 constexpr char kCustomText2[] = "CustomText2";
 
-}  // namespace OSDSettings
+}  // namespace
 
 namespace OSDPrettySettings {
 
@@ -63,7 +63,7 @@ constexpr char kFading[] = "fading";
 constexpr QRgb kPresetBlue = qRgb(102, 150, 227);
 constexpr QRgb kPresetRed = qRgb(202, 22, 16);
 
-}  // namespace OSDPrettySettings
+}  // namespace
 
 namespace DiscordRPCSettings {
 
@@ -71,14 +71,6 @@ constexpr char kSettingsGroup[] = "DiscordRPC";
 
 constexpr char kEnabled[] = "enabled";
 
-constexpr char kStatusDisplayType[] = "StatusDisplayType";
+}  // namespace
-
-enum class StatusDisplayType {
-  App = 0,
-  Artist,
-  Song
-};
-
-}  // namespace DiscordRPCSettings
 
 #endif  // NOTIFICATIONSSETTINGS_H

src/constants/playlistsettings.h

@@ -1,21 +1,21 @@
 /*
- * Strawberry Music Player
+* Strawberry Music Player
- * Copyright 2024, Jonas Kvinge <jonas@jkvinge.net>
+* Copyright 2024, Jonas Kvinge <jonas@jkvinge.net>
- *
+*
- * Strawberry is free software: you can redistribute it and/or modify
+* Strawberry is free software: you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
+* it under the terms of the GNU General Public License as published by
- * the Free Software Foundation, either version 3 of the License, or
+* the Free Software Foundation, either version 3 of the License, or
- * (at your option) any later version.
+* (at your option) any later version.
- *
+*
- * Strawberry is distributed in the hope that it will be useful,
+* Strawberry is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
+* but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
+* GNU General Public License for more details.
- *
+*
- * You should have received a copy of the GNU General Public License
+* You should have received a copy of the GNU General Public License
- * along with Strawberry.  If not, see <http://www.gnu.org/licenses/>.
+* along with Strawberry.  If not, see <http://www.gnu.org/licenses/>.
- *
+*
- */
+*/
 
 #ifndef PLAYLISTSETTINGS_H
 #define PLAYLISTSETTINGS_H
@@ -63,7 +63,7 @@ constexpr char kLastSaveExtension[] = "last_save_extension";
 constexpr char kLastSaveAllPath[] = "last_save_all_path";
 constexpr char kLastSaveAllExtension[] = "last_save_all_extension";
 
-}  // namespace PlaylistSettings
+}  // namespace
 
 Q_DECLARE_METATYPE(PlaylistSettings::PathType)
 

src/constants/qobuzsettings.h

@@ -1,21 +1,21 @@
 /*
- * Strawberry Music Player
+* Strawberry Music Player
- * Copyright 2024, Jonas Kvinge <jonas@jkvinge.net>
+* Copyright 2024, Jonas Kvinge <jonas@jkvinge.net>
- *
+*
- * Strawberry is free software: you can redistribute it and/or modify
+* Strawberry is free software: you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
+* it under the terms of the GNU General Public License as published by
- * the Free Software Foundation, either version 3 of the License, or
+* the Free Software Foundation, either version 3 of the License, or
- * (at your option) any later version.
+* (at your option) any later version.
- *
+*
- * Strawberry is distributed in the hope that it will be useful,
+* Strawberry is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
+* but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
+* GNU General Public License for more details.
- *
+*
- * You should have received a copy of the GNU General Public License
+* You should have received a copy of the GNU General Public License
- * along with Strawberry.  If not, see <http://www.gnu.org/licenses/>.
+* along with Strawberry.  If not, see <http://www.gnu.org/licenses/>.
- *
+*
- */
+*/
 
 #ifndef QOBUZSETTINGS_H
 #define QOBUZSETTINGS_H
@@ -36,13 +36,12 @@ constexpr char kAlbumsSearchLimit[] = "albumssearchlimit";
 constexpr char kSongsSearchLimit[] = "songssearchlimit";
 constexpr char kBase64Secret[] = "base64secret";
 constexpr char kDownloadAlbumCovers[] = "downloadalbumcovers";
-constexpr char kRemoveRemastered[] = "remove_remastered";
 
 constexpr char kUserId[] = "user_id";
 constexpr char kCredentialsId[] = "credentials_id";
 constexpr char kDeviceId[] = "device_id";
 constexpr char kUserAuthToken[] = "user_auth_token";
 
-}  // namespace QobuzSettings
+}  // namespace
 
 #endif  // QOBUZSETTINGS_H

src/constants/scrobblersettings.h

@@ -1,21 +1,21 @@
 /*
- * Strawberry Music Player
+* Strawberry Music Player
- * Copyright 2024, Jonas Kvinge <jonas@jkvinge.net>
+* Copyright 2024, Jonas Kvinge <jonas@jkvinge.net>
- *
+*
- * Strawberry is free software: you can redistribute it and/or modify
+* Strawberry is free software: you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
+* it under the terms of the GNU General Public License as published by
- * the Free Software Foundation, either version 3 of the License, or
+* the Free Software Foundation, either version 3 of the License, or
- * (at your option) any later version.
+* (at your option) any later version.
- *
+*
- * Strawberry is distributed in the hope that it will be useful,
+* Strawberry is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
+* but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
+* GNU General Public License for more details.
- *
+*
- * You should have received a copy of the GNU General Public License
+* You should have received a copy of the GNU General Public License
- * along with Strawberry.  If not, see <http://www.gnu.org/licenses/>.
+* along with Strawberry.  If not, see <http://www.gnu.org/licenses/>.
- *
+*
- */
+*/
 
 #ifndef SCROBBLERSETTINGS_H
 #define SCROBBLERSETTINGS_H
@@ -35,6 +35,6 @@ constexpr char kStripRemastered[] = "strip_remastered";
 constexpr char kSources[] = "sources";
 constexpr char kUserToken[] = "user_token";
 
-}  // namespace ScrobblerSettings
+}  // namespace
 
 #endif  // SCROBBLERSETTINGS_H

src/constants/spotifysettings.h

@@ -1,21 +1,21 @@
 /*
- * Strawberry Music Player
+* Strawberry Music Player
- * Copyright 2024, Jonas Kvinge <jonas@jkvinge.net>
+* Copyright 2024, Jonas Kvinge <jonas@jkvinge.net>
- *
+*
- * Strawberry is free software: you can redistribute it and/or modify
+* Strawberry is free software: you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
+* it under the terms of the GNU General Public License as published by
- * the Free Software Foundation, either version 3 of the License, or
+* the Free Software Foundation, either version 3 of the License, or
- * (at your option) any later version.
+* (at your option) any later version.
- *
+*
- * Strawberry is distributed in the hope that it will be useful,
+* Strawberry is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
+* but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
+* GNU General Public License for more details.
- *
+*
- * You should have received a copy of the GNU General Public License
+* You should have received a copy of the GNU General Public License
- * along with Strawberry.  If not, see <http://www.gnu.org/licenses/>.
+* along with Strawberry.  If not, see <http://www.gnu.org/licenses/>.
- *
+*
- */
+*/
 
 #ifndef SPOTIFYSETTINGS_H
 #define SPOTIFYSETTINGS_H
@@ -31,13 +31,12 @@ constexpr char kAlbumsSearchLimit[] = "albumssearchlimit";
 constexpr char kSongsSearchLimit[] = "songssearchlimit";
 constexpr char kFetchAlbums[] = "fetchalbums";
 constexpr char kDownloadAlbumCovers[] = "downloadalbumcovers";
-constexpr char kRemoveRemastered[] = "remove_remastered";
 
 constexpr char kAccessToken[] = "access_token";
 constexpr char kRefreshToken[] = "refresh_token";
 constexpr char kExpiresIn[] = "expires_in";
 constexpr char kLoginTime[] = "login_time";
 
-}  // namespace SpotifySettings
+}  // namespace
 
 #endif  // SPOTIFYSETTINGS_H

src/constants/subsonicsettings.h

@@ -1,21 +1,21 @@
 /*
- * Strawberry Music Player
+* Strawberry Music Player
- * Copyright 2024, Jonas Kvinge <jonas@jkvinge.net>
+* Copyright 2024, Jonas Kvinge <jonas@jkvinge.net>
- *
+*
- * Strawberry is free software: you can redistribute it and/or modify
+* Strawberry is free software: you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
+* it under the terms of the GNU General Public License as published by
- * the Free Software Foundation, either version 3 of the License, or
+* the Free Software Foundation, either version 3 of the License, or
- * (at your option) any later version.
+* (at your option) any later version.
- *
+*
- * Strawberry is distributed in the hope that it will be useful,
+* Strawberry is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
+* but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
+* GNU General Public License for more details.
- *
+*
- * You should have received a copy of the GNU General Public License
+* You should have received a copy of the GNU General Public License
- * along with Strawberry.  If not, see <http://www.gnu.org/licenses/>.
+* along with Strawberry.  If not, see <http://www.gnu.org/licenses/>.
- *
+*
- */
+*/
 
 
 #ifndef SUBSONICETTINGS_H
@@ -41,6 +41,6 @@ constexpr char kUseAlbumIdForAlbumCovers[] = "usealbumidforalbumcovers";
 constexpr char kServerSideScrobbling[] = "serversidescrobbling";
 constexpr char kAuthMethod[] = "authmethod";
 
-}  // namespace SubsonicSettings
+}  // namespace
 
 #endif  // SUBSONICETTINGS_H

src/constants/tidalsettings.h

@@ -1,21 +1,21 @@
 /*
- * Strawberry Music Player
+* Strawberry Music Player
- * Copyright 2024, Jonas Kvinge <jonas@jkvinge.net>
+* Copyright 2024, Jonas Kvinge <jonas@jkvinge.net>
- *
+*
- * Strawberry is free software: you can redistribute it and/or modify
+* Strawberry is free software: you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
+* it under the terms of the GNU General Public License as published by
- * the Free Software Foundation, either version 3 of the License, or
+* the Free Software Foundation, either version 3 of the License, or
- * (at your option) any later version.
+* (at your option) any later version.
- *
+*
- * Strawberry is distributed in the hope that it will be useful,
+* Strawberry is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
+* but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
+* GNU General Public License for more details.
- *
+*
- * You should have received a copy of the GNU General Public License
+* You should have received a copy of the GNU General Public License
- * along with Strawberry.  If not, see <http://www.gnu.org/licenses/>.
+* along with Strawberry.  If not, see <http://www.gnu.org/licenses/>.
- *
+*
- */
+*/
 
 #ifndef TIDALSETTINGS_H
 #define TIDALSETTINGS_H
@@ -40,7 +40,6 @@ constexpr char kDownloadAlbumCovers[] = "downloadalbumcovers";
 constexpr char kCoverSize[] = "coversize";
 constexpr char kStreamUrl[] = "streamurl";
 constexpr char kAlbumExplicit[] = "album_explicit";
-constexpr char kRemoveRemastered[] = "remove_remastered";
 
 enum class StreamUrlMethod {
   StreamUrl,
@@ -48,6 +47,6 @@ enum class StreamUrlMethod {
   PlaybackInfoPostPaywall
 };
 
-}  // namespace TidalSettings
+}
 
 #endif  // TIDALSETTINGS_H

src/constants/timeconstants.h

@@ -1,21 +1,21 @@
 /*
- * Strawberry Music Player
+* Strawberry Music Player
- * Copyright 2024, Jonas Kvinge <jonas@jkvinge.net>
+* Copyright 2024, Jonas Kvinge <jonas@jkvinge.net>
- *
+*
- * Strawberry is free software: you can redistribute it and/or modify
+* Strawberry is free software: you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
+* it under the terms of the GNU General Public License as published by
- * the Free Software Foundation, either version 3 of the License, or
+* the Free Software Foundation, either version 3 of the License, or
- * (at your option) any later version.
+* (at your option) any later version.
- *
+*
- * Strawberry is distributed in the hope that it wiLL be useful,
+* Strawberry is distributed in the hope that it wiLL be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
+* but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
+* GNU General Public License for more details.
- *
+*
- * You should have received a copy of the GNU General Public License
+* You should have received a copy of the GNU General Public License
- * along with Strawberry.  If not, see <http://www.gnu.org/licenses/>.
+* along with Strawberry.  If not, see <http://www.gnu.org/licenses/>.
- *
+*
- */
+*/
 
 #ifndef TIMECONSTANTS_H
 #define TIMECONSTANTS_H